mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
Hazel KimandGitHub
c6bebde733
## What changed? <!-- Describe what has changed in this PR --> - added EnableShadowReadMode config (default to false) - if shadow read mode is enabled, perform shadow read from the secondary visibility store for visibility read requests ## Why? <!-- Tell your future self why have you made these changes --> - to measure latency metrics from both visibility stores ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> - tested locally, and verified that visibility read requests from both visibility stores are getting reasonably same latencies ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) -->
60 lines
2.4 KiB
Go
60 lines
2.4 KiB
Go
// The MIT License
|
|
//
|
|
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
|
|
//
|
|
// Copyright (c) 2020 Uber Technologies, Inc.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
// THE SOFTWARE.
|
|
|
|
package visibility
|
|
|
|
import (
|
|
"go.temporal.io/server/common/dynamicconfig"
|
|
"go.temporal.io/server/common/persistence/sql/sqlplugin/mysql"
|
|
"go.temporal.io/server/common/persistence/sql/sqlplugin/postgresql"
|
|
"go.temporal.io/server/common/persistence/sql/sqlplugin/sqlite"
|
|
)
|
|
|
|
const (
|
|
// SecondaryVisibilityWritingModeOff means do not write to advanced visibility store
|
|
SecondaryVisibilityWritingModeOff = "off"
|
|
// SecondaryVisibilityWritingModeOn means only write to advanced visibility store
|
|
SecondaryVisibilityWritingModeOn = "on"
|
|
// SecondaryVisibilityWritingModeDual means write to both normal visibility and advanced visibility store
|
|
SecondaryVisibilityWritingModeDual = "dual"
|
|
)
|
|
|
|
func AllowListForValidation(
|
|
storeNames []string,
|
|
allowList dynamicconfig.BoolPropertyFnWithNamespaceFilter,
|
|
) dynamicconfig.BoolPropertyFnWithNamespaceFilter {
|
|
if len(storeNames) == 0 {
|
|
return dynamicconfig.GetBoolPropertyFnFilteredByNamespace(false)
|
|
}
|
|
|
|
switch storeNames[0] {
|
|
case mysql.PluginName, postgresql.PluginName, postgresql.PluginNamePGX, sqlite.PluginName:
|
|
// Advanced visibility with SQL DB don't support list of values
|
|
return dynamicconfig.GetBoolPropertyFnFilteredByNamespace(false)
|
|
default:
|
|
// Otherwise (ES), check dynamic config
|
|
return allowList
|
|
}
|
|
}
|