Files
tasks/common/pprof/pprof.go
Derek WilsonandGitHub c6c5975b51 Improve ipv6 support (#4766)
Temporal works with ipv6, but there are some clarifications in documentation and additional settings that could make support cleaner. Specifically:

* specify pprof host to override localhost default
* use net.JoinHostPort instead of fmt.Sprintf
* lookup `localhost` in various code paths
* add a test for ringpop using ipv6
* fixes comments to remove claim of ipv4 only

tested via added unit tests and local verification
2023-09-07 21:10:45 +00:00

91 lines
2.8 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package pprof
import (
"fmt"
"net"
"net/http"
_ "net/http/pprof" // DO NOT REMOVE THE LINE
"sync/atomic"
"go.temporal.io/server/common/config"
"go.temporal.io/server/common/log"
"go.temporal.io/server/common/log/tag"
)
const (
pprofNotInitialized int32 = 0
pprofInitialized int32 = 1
)
type (
// PProfInitializerImpl initialize the pprof based on config
PProfInitializerImpl struct {
PProf *config.PProf
Logger log.Logger
}
)
// the pprof should only be initialized once per process
// otherwise, the caller / worker will experience weird issue
var pprofStatus = pprofNotInitialized
// NewInitializer create a new instance of PProf Initializer
func NewInitializer(cfg *config.PProf, logger log.Logger) *PProfInitializerImpl {
return &PProfInitializerImpl{
PProf: cfg,
Logger: logger,
}
}
// Start the pprof based on config
func (initializer *PProfInitializerImpl) Start() error {
port := initializer.PProf.Port
if port == 0 {
initializer.Logger.Info("PProf not started due to port not set")
return nil
}
host := initializer.PProf.Host
if host == "" {
// default to localhost which will favor ipv4 on dual stack
// environments - configure host as `::1` to bind on ipv6 localhost
host = "localhost"
}
hostPort := net.JoinHostPort(host, fmt.Sprint(port))
if atomic.CompareAndSwapInt32(&pprofStatus, pprofNotInitialized, pprofInitialized) {
go func() {
initializer.Logger.Info("PProf listen on ", tag.Host(host), tag.Port(port))
err := http.ListenAndServe(hostPort, nil)
if err != nil {
initializer.Logger.Error("listen and serve err", tag.Error(err))
}
}()
}
return nil
}