Files
tasks/common/predicates/and_test.go
Roey BermanandGitHub 7c82b51d1a Add dynamic config to limit multi cursor predicate size (#6458)
## What changed?

Add dynamic config to limit multi-cursor predicate size.
There are two separate configs:
- `history.queueMaxPredicateSize` for all history queues except for the
outbound queue - set to unlimited by default to avoid changing behavior
- `history.outboundQueueMaxPredicateSize` for the outbound queue - set
to 10K by default

## Why?

Limit the size of the shard info record. In stress test scenarios we've
seen this record grow to over 10MB.

## How did you test it?

Added unit tests.

## Is hotfix candidate?

This should be applied to any server deployments enabling Nexus
workloads.
2024-08-29 17:21:16 +00:00

153 lines
3.6 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package predicates
import (
"testing"
"github.com/stretchr/testify/require"
"github.com/stretchr/testify/suite"
)
type (
andSuite struct {
suite.Suite
*require.Assertions
}
)
func TestAndSuite(t *testing.T) {
s := new(andSuite)
suite.Run(t, s)
}
func (s *andSuite) SetupTest() {
s.Assertions = require.New(s.T())
}
func (s *andSuite) TestAnd_Normal() {
p1 := newTestPredicate(1, 2, 6)
p2 := And[int](
newTestPredicate(3, 4, 6),
newTestPredicate(4, 5, 6),
)
p := And[int](p1, p2)
for i := 1; i != 6; i++ {
s.False(p.Test(i))
}
s.True(p.Test(6))
}
func (s *andSuite) TestAnd_All() {
p := And[int](
newTestPredicate(1, 2, 3),
Universal[int](),
)
for i := 1; i != 4; i++ {
s.True(p.Test(i))
}
for i := 4; i != 7; i++ {
s.False(p.Test(i))
}
p = And(
Universal[int](),
Universal[int](),
)
for i := 1; i != 7; i++ {
s.True(p.Test(i))
}
}
func (s *andSuite) TestAnd_None() {
p := And[int](
newTestPredicate(1, 2, 3),
Empty[int](),
)
for i := 1; i != 7; i++ {
s.False(p.Test(i))
}
}
func (s *andSuite) TestAnd_Duplication() {
p1 := newTestPredicate(1, 2, 3)
p2 := newTestPredicate(2, 3, 4)
p3 := newTestPredicate(3, 4, 5)
_, ok := And[int](p1, p1).(*testPredicate)
s.True(ok)
p := And[int](p1, p2)
pAnd, ok := And[int](p, p1).(*AndImpl[int])
s.True(ok)
s.Len(pAnd.Predicates, 2)
pAnd, ok = And(p, p).(*AndImpl[int])
s.True(ok)
s.Len(pAnd.Predicates, 2)
pAnd, ok = And(p, And[int](p1, p2)).(*AndImpl[int])
s.True(ok)
s.Len(pAnd.Predicates, 2)
pAnd, ok = And(p, And[int](p1, p2, p3)).(*AndImpl[int])
s.True(ok)
s.Len(pAnd.Predicates, 3)
}
func (s *andSuite) TestAnd_Equals() {
p1 := newTestPredicate(1, 2, 3)
p2 := newTestPredicate(2, 3, 4)
p := And[int](p1, p2)
s.True(p.Equals(p))
s.True(p.Equals(And[int](p1, p2)))
s.True(p.Equals(And[int](p2, p1)))
s.True(p.Equals(And[int](p1, p1, p2)))
s.True(p.Equals(And[int](
newTestPredicate(4, 3, 2),
newTestPredicate(3, 2, 1),
)))
s.False(p.Equals(p1))
s.False(p.Equals(And[int](p2, p2)))
s.False(p.Equals(And[int](p2, newTestPredicate(5, 6, 7))))
s.False(p.Equals(Or[int](p1, p2)))
s.False(p.Equals(Not(p)))
s.False(p.Equals(Empty[int]()))
s.False(p.Equals(Universal[int]()))
}
func (s *andSuite) TestAnd_Size() {
p1 := newTestPredicate(1, 2, 3)
p2 := newTestPredicate(2, 3, 4)
p := And(p1, p2)
s.Equal(52, p.Size()) // 8 bytes per int64 * 6 ints + 4 bytes of overhead.
}