mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
pdoernerandGitHub
26fb9cc5f3
## What changed? <!-- Describe what has changed in this PR --> Adding back a cap for durations at 250 years. ## Why? <!-- Tell your future self why have you made these changes --> To prevent serialization errors for very large proto durations. ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> New unit test
93 lines
2.9 KiB
Go
93 lines
2.9 KiB
Go
// The MIT License
|
|
//
|
|
// Copyright (c) 2024 Temporal Technologies Inc. All rights reserved.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
// THE SOFTWARE.
|
|
|
|
package timestamp
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"google.golang.org/protobuf/types/known/durationpb"
|
|
)
|
|
|
|
func TestValidateAndCapProtoDuration(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
testCases := []struct {
|
|
name string
|
|
timerDuration *durationpb.Duration
|
|
expectedErr error
|
|
expectedTimerDuration *durationpb.Duration
|
|
}{
|
|
{
|
|
name: "nil timer duration",
|
|
timerDuration: nil,
|
|
expectedErr: nil,
|
|
expectedTimerDuration: nil,
|
|
},
|
|
{
|
|
name: "negative timer duration",
|
|
timerDuration: durationpb.New(-time.Minute),
|
|
expectedErr: errNegativeDuration,
|
|
expectedTimerDuration: nil,
|
|
},
|
|
{
|
|
name: "zero timer duration",
|
|
timerDuration: durationpb.New(0),
|
|
expectedErr: nil,
|
|
expectedTimerDuration: durationpb.New(0),
|
|
},
|
|
{
|
|
name: "valid timer duration",
|
|
timerDuration: durationpb.New(time.Hour),
|
|
expectedErr: nil,
|
|
expectedTimerDuration: durationpb.New(time.Hour),
|
|
},
|
|
{
|
|
name: "mismatched signs",
|
|
timerDuration: &durationpb.Duration{Seconds: 360, Nanos: -100},
|
|
expectedErr: errMismatchedSigns,
|
|
expectedTimerDuration: nil,
|
|
},
|
|
{
|
|
name: "large duration",
|
|
timerDuration: durationpb.New(280 * 365 * 24 * time.Hour),
|
|
expectedErr: nil,
|
|
expectedTimerDuration: durationpb.New(maxAllowedDuration),
|
|
},
|
|
}
|
|
|
|
for _, tc := range testCases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
actualErr := ValidateAndCapProtoDuration(tc.timerDuration)
|
|
|
|
assert.Equal(t, tc.expectedErr, actualErr)
|
|
if tc.expectedErr == nil {
|
|
assert.Equal(t, tc.expectedTimerDuration, tc.timerDuration)
|
|
}
|
|
})
|
|
}
|
|
}
|