Files
tasks/common/quotas/multi_rate_limiter_impl.go
4ba82252da Recycle task tokens for invalid matching tasks (#6599)
## What changed?
Add a `RecycleToken` function to our custom rate limiters. It seems that
most of the rate limiters just wrap the `ClockedRateLimiter`, so let the
`ClockedRateLimiter`'s `WaitN` function unblock the waiter if recycle is
called, thus allowing us to recycle tokens and give them to any waiters
if they exist.

## Why?
Lots of invalid tasks combined with Activity task dispatch rate limiting
can cause the actual rate to be noticeably below the maximum rate. This
will make the actual rate match the max rps, as long as
`time_to_recycle` is reasonably short and `recycle_rate` is reasonable
(see discussion in the comments)

## How did you test it?
ClockedRateLimiter unit test.

## Potential risks
The max Activity RPS could break.

## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->

---------

Co-authored-by: David Reiss <[email protected]>
2024-10-12 01:46:05 +00:00

202 lines
5.6 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package quotas
import (
"context"
"fmt"
"math"
"time"
"golang.org/x/time/rate"
)
const (
InfDuration = rate.InfDuration
)
type (
// MultiRateLimiterImpl is a wrapper around the limiter interface
MultiRateLimiterImpl struct {
rateLimiters []RateLimiter
}
)
var _ RateLimiter = (*MultiRateLimiterImpl)(nil)
// NewMultiRateLimiter returns a new rate limiter that have multiple stage
func NewMultiRateLimiter(
rateLimiters []RateLimiter,
) *MultiRateLimiterImpl {
if len(rateLimiters) == 0 {
panic("expect at least one rate limiter")
}
return &MultiRateLimiterImpl{
rateLimiters: rateLimiters,
}
}
// Allow immediately returns with true or false indicating if a rate limit
// token is available or not
func (rl *MultiRateLimiterImpl) Allow() bool {
return rl.AllowN(time.Now(), 1)
}
// AllowN immediately returns with true or false indicating if n rate limit
// token is available or not
func (rl *MultiRateLimiterImpl) AllowN(now time.Time, numToken int) bool {
length := len(rl.rateLimiters)
reservations := make([]Reservation, 0, length)
for _, rateLimiter := range rl.rateLimiters {
reservation := rateLimiter.ReserveN(now, numToken)
if !reservation.OK() || reservation.DelayFrom(now) > 0 {
if reservation.OK() {
reservation.CancelAt(now)
}
// cancel all existing reservation
for _, reservation := range reservations {
reservation.CancelAt(now)
}
return false
}
reservations = append(reservations, reservation)
}
return true
}
// Reserve returns a Reservation that indicates how long the caller
// must wait before event happen.
func (rl *MultiRateLimiterImpl) Reserve() Reservation {
return rl.ReserveN(time.Now(), 1)
}
// ReserveN calls ReserveN on its list of rate limiters and returns a MultiReservation that is a list of the
// individual reservation objects indicating how long the caller must wait before the event can happen.
func (rl *MultiRateLimiterImpl) ReserveN(now time.Time, numToken int) Reservation {
length := len(rl.rateLimiters)
reservations := make([]Reservation, 0, length)
for _, rateLimiter := range rl.rateLimiters {
reservation := rateLimiter.ReserveN(now, numToken)
if !reservation.OK() {
// cancel all existing reservation
for _, reservation := range reservations {
reservation.CancelAt(now)
}
return NewMultiReservation(false, nil)
}
reservations = append(reservations, reservation)
}
return NewMultiReservation(true, reservations)
}
// Wait waits up till maximum deadline for a rate limit token
func (rl *MultiRateLimiterImpl) Wait(ctx context.Context) error {
return rl.WaitN(ctx, 1)
}
// WaitN waits up till maximum deadline for n rate limit tokens
func (rl *MultiRateLimiterImpl) WaitN(ctx context.Context, numToken int) error {
select {
case <-ctx.Done():
return ctx.Err()
default:
}
now := time.Now().UTC()
reservation := rl.ReserveN(now, numToken)
if !reservation.OK() {
return fmt.Errorf("rate: Wait(n=%d) would exceed context deadline", numToken)
}
delay := reservation.DelayFrom(now)
if delay == 0 {
return nil
}
waitLimit := InfDuration
if deadline, ok := ctx.Deadline(); ok {
waitLimit = deadline.Sub(now)
}
if waitLimit < delay {
reservation.CancelAt(now)
return fmt.Errorf("rate: Wait(n=%d) would exceed context deadline", numToken)
}
t := time.NewTimer(delay)
defer t.Stop()
select {
case <-t.C:
return nil
case <-ctx.Done():
reservation.CancelAt(time.Now())
return ctx.Err()
}
}
// Rate returns the minimum rate per second for this rate limiter
func (rl *MultiRateLimiterImpl) Rate() float64 {
result := rl.rateLimiters[0].Rate()
for _, rateLimiter := range rl.rateLimiters {
newRate := rateLimiter.Rate()
if result > newRate {
result = newRate
}
}
return result
}
// Burst returns the minimum burst for this rate limiter
func (rl *MultiRateLimiterImpl) Burst() int {
result := rl.rateLimiters[0].Burst()
for _, rateLimiter := range rl.rateLimiters {
newBurst := rateLimiter.Burst()
if result > newBurst {
result = newBurst
}
}
return result
}
func (rl *MultiRateLimiterImpl) TokensAt(t time.Time) int {
tokens := math.MaxInt
for _, rateLimiter := range rl.rateLimiters {
tokens = min(tokens, rateLimiter.TokensAt(t))
}
return tokens
}
// RecycleToken returns a token to each sub-rate-limiter, unblocking each
// sub-rate-limiter's WaitN callers.
func (rl *MultiRateLimiterImpl) RecycleToken() {
for _, rateLimiter := range rl.rateLimiters {
rateLimiter.RecycleToken()
}
}