mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
Michael SnowdenandGitHub
1d6e8d5d6b
## What changed? <!-- Describe what has changed in this PR --> I migrated our usage of `gofakeit` to `go-faker`. ## Why? <!-- Tell your future self why have you made these changes --> Because `go-faker` does not handle circular references, which we have in our `Failure` proto. See https://github.com/brianvoe/gofakeit/issues/281#issue-2071796056 ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> I added a test which verifies that these cases are handled gracefully. I also removed the workaround we had for this in our `ActivityInfo` generator. ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> By default, this is less performant than `gofakeit`. However, by calling `SetRandomMapAndSliceMaxSize(2)` (down from the default of 100), we have comparable performance (on the order of 100 micro seconds for large structs). ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) --> No.