mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
## What changed? - Fixed the callback executor to not fail a task on retryable error (a regression introduced while refactoring to support HSM callbacks) - No longer use `ValidateNotTransitioned` in task validation logic. We can deprecate the `transition_count` field on the state machine node proto after this. ## Why? The first fix is a simple bug fix, the second change is for unblocking the state replication efforts. ## How did you test it? Leveraged existing tests.
117 lines
3.4 KiB
Go
117 lines
3.4 KiB
Go
// The MIT License
|
|
//
|
|
// Copyright (c) 2024 Temporal Technologies Inc. All rights reserved.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
// THE SOFTWARE.
|
|
|
|
package callbacks
|
|
|
|
import (
|
|
"time"
|
|
|
|
enumsspb "go.temporal.io/server/api/enums/v1"
|
|
persistencespb "go.temporal.io/server/api/persistence/v1"
|
|
"go.temporal.io/server/service/history/hsm"
|
|
)
|
|
|
|
const (
|
|
TaskTypeInvocation = "callbacks.Invocation"
|
|
TaskTypeBackoff = "callbacks.Backoff"
|
|
)
|
|
|
|
type InvocationTask struct {
|
|
// The base URL for nexus callbacks.
|
|
// Will have other meanings as more callback use cases are added.
|
|
destination string
|
|
}
|
|
|
|
var _ hsm.Task = InvocationTask{}
|
|
|
|
func NewInvocationTask(destination string) InvocationTask {
|
|
return InvocationTask{destination: destination}
|
|
}
|
|
|
|
func (InvocationTask) Type() string {
|
|
return TaskTypeInvocation
|
|
}
|
|
|
|
func (t InvocationTask) Destination() string {
|
|
return t.destination
|
|
}
|
|
|
|
func (t InvocationTask) Deadline() time.Time {
|
|
return hsm.Immediate
|
|
}
|
|
|
|
func (InvocationTask) Validate(ref *persistencespb.StateMachineRef, node *hsm.Node) error {
|
|
return hsm.ValidateState[enumsspb.CallbackState, Callback](node, enumsspb.CALLBACK_STATE_SCHEDULED)
|
|
}
|
|
|
|
type InvocationTaskSerializer struct{}
|
|
|
|
func (InvocationTaskSerializer) Deserialize(data []byte, attrs hsm.TaskAttributes) (hsm.Task, error) {
|
|
return InvocationTask{destination: attrs.Destination}, nil
|
|
}
|
|
|
|
func (InvocationTaskSerializer) Serialize(hsm.Task) ([]byte, error) {
|
|
return nil, nil
|
|
}
|
|
|
|
type BackoffTask struct {
|
|
deadline time.Time
|
|
}
|
|
|
|
var _ hsm.Task = BackoffTask{}
|
|
|
|
func (BackoffTask) Type() string {
|
|
return TaskTypeBackoff
|
|
}
|
|
|
|
func (t BackoffTask) Deadline() time.Time {
|
|
return t.deadline
|
|
}
|
|
|
|
func (BackoffTask) Destination() string {
|
|
return ""
|
|
}
|
|
|
|
func (BackoffTask) Validate(ref *persistencespb.StateMachineRef, node *hsm.Node) error {
|
|
return hsm.ValidateState[enumsspb.CallbackState, Callback](node, enumsspb.CALLBACK_STATE_BACKING_OFF)
|
|
}
|
|
|
|
type BackoffTaskSerializer struct{}
|
|
|
|
func (BackoffTaskSerializer) Deserialize(data []byte, attrs hsm.TaskAttributes) (hsm.Task, error) {
|
|
return BackoffTask{deadline: attrs.Deadline}, nil
|
|
}
|
|
|
|
func (BackoffTaskSerializer) Serialize(hsm.Task) ([]byte, error) {
|
|
return nil, nil
|
|
}
|
|
|
|
func RegisterTaskSerializers(reg *hsm.Registry) error {
|
|
if err := reg.RegisterTaskSerializer(TaskTypeInvocation, InvocationTaskSerializer{}); err != nil {
|
|
return err
|
|
}
|
|
if err := reg.RegisterTaskSerializer(TaskTypeBackoff, BackoffTaskSerializer{}); err != nil { // nolint:revive
|
|
return err
|
|
}
|
|
return nil
|
|
}
|