Files
tasks/internal/effect/buffer.go
42235478a5 Reduce logging on WFTCompletedHandler.Invoke error (#7195)
## What changed?
<!-- Describe what has changed in this PR -->
Reduce logging on `WFTCompletedHandler.Invoke` error. Now it is emitted
only when effects were actually cleared.

## Why?
<!-- Tell your future self why have you made these changes -->
Remove noisy logs.

## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
Didn't test.

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
No risks.

## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->
No.

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->
No.

---------

Co-authored-by: Stephan Behnke <[email protected]>
2025-01-31 18:56:17 +00:00

77 lines
2.7 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package effect
import "context"
// Buffer holds a set of effect and rollback functions that can be invoked as a
// batch with a defined order. Once either Apply or Cancel is called, all
// buffered effects are cleared. This type is not threadsafe. The zero-value of
// a Buffer is a valid state.
type Buffer struct {
effects []func(context.Context)
cancels []func(context.Context)
}
// OnAfterCommit adds the provided effect function to set of such functions to
// be invoked when Buffer.Apply is called.
func (b *Buffer) OnAfterCommit(effect func(context.Context)) {
b.effects = append(b.effects, effect)
}
// OnAfterRollback adds the provided effect function to set of such functions to
// be invoked when Buffer.Cancel is called.
func (b *Buffer) OnAfterRollback(effect func(context.Context)) {
b.cancels = append(b.cancels, effect)
}
// Apply invokes the buffered effect functions in the order that they were added
// to this Buffer.
// It returns true if any effects were applied.
func (b *Buffer) Apply(ctx context.Context) bool {
applied := false
b.cancels = nil
for _, effect := range b.effects {
effect(ctx)
applied = true
}
b.effects = nil
return applied
}
// Cancel invokes the buffered rollback functions in the reverse of the order
// that they were added to this Buffer.
// It returns true if any effects were canceled.
func (b *Buffer) Cancel(ctx context.Context) bool {
canceled := false
b.effects = nil
for i := len(b.cancels) - 1; i >= 0; i-- {
b.cancels[i](ctx)
canceled = true
}
b.cancels = nil
return canceled
}