mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-30 14:56:19 +00:00
Stephan BehnkeandGitHub
b43c4b0f8e
## What changed?
<!-- Describe what has changed in this PR -->
Linter to enforce import aliases for protobuf imports.
Enforced rules across entire codebase.
## Why?
<!-- Tell your future self why have you made these changes -->
Consistency. Relief reviewers from pointing it out.
We had 100+ violations.
## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
Running
```
make lint-code
.bin/golangci-lint-dafd65537336fdce063c492a7ab2a68cc89f8d52 run --config=.golangci.yml | grep importas
```
comes up empty (compared to say `grep typecheck`).
Plus compiler and tests ofc.
## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
Me smuggling in an easter egg into the code (I didn't, I swear 🙃)
## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->
## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->
105 lines
3.7 KiB
Go
105 lines
3.7 KiB
Go
// The MIT License
|
|
//
|
|
// Copyright (c) 2024 Temporal Technologies Inc. All rights reserved.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
// THE SOFTWARE.
|
|
|
|
package resetworkflow
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/suite"
|
|
enumspb "go.temporal.io/api/enums/v1"
|
|
)
|
|
|
|
type (
|
|
resetWorkflowSuite struct {
|
|
suite.Suite
|
|
}
|
|
)
|
|
|
|
func TestResetWorkflowSuite(t *testing.T) {
|
|
s := new(resetWorkflowSuite)
|
|
suite.Run(t, s)
|
|
}
|
|
|
|
func (s *resetWorkflowSuite) TestGetResetReapplyExcludeTypes() {
|
|
// Include all with no exclusions => no exclusions
|
|
s.Equal(
|
|
map[enumspb.ResetReapplyExcludeType]struct{}{},
|
|
GetResetReapplyExcludeTypes(
|
|
[]enumspb.ResetReapplyExcludeType{},
|
|
enumspb.RESET_REAPPLY_TYPE_ALL_ELIGIBLE,
|
|
),
|
|
)
|
|
// Include all with one exclusion => one exclusion (honor exclude in presence of default value of deprecated option)
|
|
s.Equal(
|
|
map[enumspb.ResetReapplyExcludeType]struct{}{enumspb.RESET_REAPPLY_EXCLUDE_TYPE_SIGNAL: {}},
|
|
GetResetReapplyExcludeTypes(
|
|
[]enumspb.ResetReapplyExcludeType{enumspb.RESET_REAPPLY_EXCLUDE_TYPE_SIGNAL},
|
|
enumspb.RESET_REAPPLY_TYPE_ALL_ELIGIBLE,
|
|
),
|
|
)
|
|
// Include signal with no exclusions => exclude updates
|
|
// (honor non-default value of deprecated option in presence of default value of non-deprecated option)
|
|
s.Equal(
|
|
map[enumspb.ResetReapplyExcludeType]struct{}{enumspb.RESET_REAPPLY_EXCLUDE_TYPE_UPDATE: {}},
|
|
GetResetReapplyExcludeTypes(
|
|
[]enumspb.ResetReapplyExcludeType{},
|
|
enumspb.RESET_REAPPLY_TYPE_SIGNAL,
|
|
),
|
|
)
|
|
// Include signal with exclude signal => include signal means they want to exclude updates, and then the explicit
|
|
// exclusion of signal trumps the deprecated inclusion
|
|
s.Equal(
|
|
map[enumspb.ResetReapplyExcludeType]struct{}{
|
|
enumspb.RESET_REAPPLY_EXCLUDE_TYPE_SIGNAL: {},
|
|
enumspb.RESET_REAPPLY_EXCLUDE_TYPE_UPDATE: {},
|
|
},
|
|
GetResetReapplyExcludeTypes(
|
|
[]enumspb.ResetReapplyExcludeType{enumspb.RESET_REAPPLY_EXCLUDE_TYPE_SIGNAL},
|
|
enumspb.RESET_REAPPLY_TYPE_SIGNAL,
|
|
),
|
|
)
|
|
// Include none with no exclusions => all excluded
|
|
// (honor non-default value of deprecated option in presence of default value of non-deprecated option)
|
|
s.Equal(
|
|
map[enumspb.ResetReapplyExcludeType]struct{}{
|
|
enumspb.RESET_REAPPLY_EXCLUDE_TYPE_SIGNAL: {},
|
|
enumspb.RESET_REAPPLY_EXCLUDE_TYPE_UPDATE: {},
|
|
},
|
|
GetResetReapplyExcludeTypes(
|
|
[]enumspb.ResetReapplyExcludeType{},
|
|
enumspb.RESET_REAPPLY_TYPE_NONE,
|
|
),
|
|
)
|
|
// Include none with exclude signal is all excluded
|
|
s.Equal(
|
|
map[enumspb.ResetReapplyExcludeType]struct{}{
|
|
enumspb.RESET_REAPPLY_EXCLUDE_TYPE_SIGNAL: {},
|
|
enumspb.RESET_REAPPLY_EXCLUDE_TYPE_UPDATE: {},
|
|
},
|
|
GetResetReapplyExcludeTypes(
|
|
[]enumspb.ResetReapplyExcludeType{enumspb.RESET_REAPPLY_EXCLUDE_TYPE_SIGNAL},
|
|
enumspb.RESET_REAPPLY_TYPE_NONE,
|
|
),
|
|
)
|
|
}
|