Files
Rodrigo ZhouandGitHub 0de527be90 Add OnConflictOptions to StartWorkflowExecution (#7080)
## What changed?
<!-- Describe what has changed in this PR -->
Add `OnConflictOptions` to `StartWorkflowExecution`.
- if the workflow id conflict policy is not `USE_EXISTING`, then no-op;
- if the field is nil, then no-op;
- otherwise, then it will add a `WorkflowExecutionOptionsUpdatedEvent`
to the existing running workflow.

## Why?
<!-- Tell your future self why have you made these changes -->
Ability to attach completion callbacks to existing running workflows.

## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
WIP: writing tests

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->

## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->
2025-02-03 15:53:42 -06:00

167 lines
6.0 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package updateworkflowoptions
import (
"context"
"fmt"
"go.temporal.io/api/serviceerror"
workflowpb "go.temporal.io/api/workflow/v1"
"go.temporal.io/server/api/historyservice/v1"
"go.temporal.io/server/common/definition"
"go.temporal.io/server/common/namespace"
"go.temporal.io/server/common/util"
"go.temporal.io/server/common/worker_versioning"
"go.temporal.io/server/service/history/api"
"go.temporal.io/server/service/history/consts"
"go.temporal.io/server/service/history/shard"
"go.temporal.io/server/service/history/workflow"
"google.golang.org/protobuf/proto"
"google.golang.org/protobuf/types/known/fieldmaskpb"
)
func Invoke(
ctx context.Context,
request *historyservice.UpdateWorkflowExecutionOptionsRequest,
shardCtx shard.Context,
workflowConsistencyChecker api.WorkflowConsistencyChecker,
) (*historyservice.UpdateWorkflowExecutionOptionsResponse, error) {
ns, err := api.GetActiveNamespace(shardCtx, namespace.ID(request.GetNamespaceId()))
if err != nil {
return nil, err
}
req := request.GetUpdateRequest()
ret := &historyservice.UpdateWorkflowExecutionOptionsResponse{}
opts := req.GetWorkflowExecutionOptions()
if err := worker_versioning.ValidateVersioningOverride(opts.GetVersioningOverride()); err != nil {
return nil, err
}
err = api.GetAndUpdateWorkflowWithNew(
ctx,
nil,
definition.NewWorkflowKey(
ns.ID().String(),
req.GetWorkflowExecution().GetWorkflowId(),
req.GetWorkflowExecution().GetRunId(),
),
func(workflowLease api.WorkflowLease) (*api.UpdateWorkflowAction, error) {
mutableState := workflowLease.GetMutableState()
if !mutableState.IsWorkflowExecutionRunning() {
// in-memory mutable state is still clean, let updateError=nil in the defer func()
// to prevent clearing and reloading mutable state while releasing the lock
return nil, consts.ErrWorkflowCompleted
}
// Merge the requested options mentioned in the field mask with the current options in the mutable state
mergedOpts, err := applyWorkflowExecutionOptions(
getOptionsFromMutableState(mutableState),
opts,
req.GetUpdateMask(),
)
if err != nil {
return nil, serviceerror.NewInvalidArgument(fmt.Sprintf("error applying update_options: %v", err))
}
// Set options for gRPC response
ret.WorkflowExecutionOptions = mergedOpts
// If there is no mutable state change at all, return with no new history event and Noop=true
if proto.Equal(mergedOpts, getOptionsFromMutableState(mutableState)) {
return &api.UpdateWorkflowAction{
Noop: true,
CreateWorkflowTask: false,
}, nil
}
unsetOverride := false
if mergedOpts.GetVersioningOverride() == nil {
unsetOverride = true
}
_, err = mutableState.AddWorkflowExecutionOptionsUpdatedEvent(mergedOpts.GetVersioningOverride(), unsetOverride, "", nil, nil)
if err != nil {
return nil, err
}
// TODO (carly) part 2: handle safe deployment change --> CreateWorkflowTask=true
return &api.UpdateWorkflowAction{
Noop: false,
CreateWorkflowTask: false,
}, nil
},
nil,
shardCtx,
workflowConsistencyChecker,
)
if err != nil {
return nil, err
}
return ret, nil
}
func getOptionsFromMutableState(ms workflow.MutableState) *workflowpb.WorkflowExecutionOptions {
opts := &workflowpb.WorkflowExecutionOptions{}
if versioningInfo := ms.GetExecutionInfo().GetVersioningInfo(); versioningInfo != nil {
override, ok := proto.Clone(versioningInfo.GetVersioningOverride()).(*workflowpb.VersioningOverride)
if !ok {
return nil
}
opts.VersioningOverride = override
}
return opts
}
// applyWorkflowExecutionOptions copies the given paths in `src` struct to `dst` struct
func applyWorkflowExecutionOptions(
mergeInto, mergeFrom *workflowpb.WorkflowExecutionOptions,
updateMask *fieldmaskpb.FieldMask,
) (*workflowpb.WorkflowExecutionOptions, error) {
_, err := fieldmaskpb.New(mergeInto, updateMask.GetPaths()...)
if err != nil { // errors if any paths are not valid for the struct we are merging into
return nil, err
}
updateFields := util.ParseFieldMask(updateMask)
if _, ok := updateFields["versioningOverride"]; ok {
mergeInto.VersioningOverride = mergeFrom.GetVersioningOverride()
}
if _, ok := updateFields["versioningOverride.deployment"]; ok {
if _, ok := updateFields["versioningOverride.behavior"]; !ok {
return nil, serviceerror.NewInvalidArgument("versioning_override fields must be updated together")
}
mergeInto.VersioningOverride = mergeFrom.GetVersioningOverride()
}
if _, ok := updateFields["versioningOverride.behavior"]; ok {
if _, ok := updateFields["versioningOverride.deployment"]; !ok {
return nil, serviceerror.NewInvalidArgument("versioning_override fields must be updated together")
}
mergeInto.VersioningOverride = mergeFrom.GetVersioningOverride()
}
return mergeInto, nil
}