mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-30 14:56:19 +00:00
## What changed?
<!-- Describe what has changed in this PR -->
Linter to enforce import aliases for protobuf imports.
Enforced rules across entire codebase.
## Why?
<!-- Tell your future self why have you made these changes -->
Consistency. Relief reviewers from pointing it out.
We had 100+ violations.
## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
Running
```
make lint-code
.bin/golangci-lint-dafd65537336fdce063c492a7ab2a68cc89f8d52 run --config=.golangci.yml | grep importas
```
comes up empty (compared to say `grep typecheck`).
Plus compiler and tests ofc.
## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
Me smuggling in an easter egg into the code (I didn't, I swear 🙃)
## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->
## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->
303 lines
5.9 KiB
Go
303 lines
5.9 KiB
Go
// The MIT License
|
|
//
|
|
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
|
|
//
|
|
// Copyright (c) 2020 Uber Technologies, Inc.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
// THE SOFTWARE.
|
|
|
|
package ndc
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/pborman/uuid"
|
|
"github.com/stretchr/testify/require"
|
|
"github.com/stretchr/testify/suite"
|
|
enumspb "go.temporal.io/api/enums/v1"
|
|
historypb "go.temporal.io/api/history/v1"
|
|
"go.temporal.io/server/common/cluster"
|
|
"go.temporal.io/server/common/definition"
|
|
"go.uber.org/mock/gomock"
|
|
)
|
|
|
|
type (
|
|
replicationTaskSuite struct {
|
|
suite.Suite
|
|
*require.Assertions
|
|
|
|
controller *gomock.Controller
|
|
clusterMetadata *cluster.MockMetadata
|
|
}
|
|
)
|
|
|
|
func TestReplicationTaskSuite(t *testing.T) {
|
|
s := new(replicationTaskSuite)
|
|
suite.Run(t, s)
|
|
}
|
|
|
|
func (s *replicationTaskSuite) SetupSuite() {
|
|
s.Assertions = require.New(s.T())
|
|
s.controller = gomock.NewController(s.T())
|
|
s.clusterMetadata = cluster.NewMockMetadata(s.controller)
|
|
s.clusterMetadata.EXPECT().ClusterNameForFailoverVersion(gomock.Any(), gomock.Any()).Return("some random cluster name").AnyTimes()
|
|
}
|
|
|
|
func (s *replicationTaskSuite) TearDownSuite() {
|
|
|
|
}
|
|
|
|
func (s *replicationTaskSuite) TestValidateEventsSlice() {
|
|
eS1 := []*historypb.HistoryEvent{
|
|
{
|
|
EventId: 1,
|
|
Version: 2,
|
|
},
|
|
{
|
|
EventId: 2,
|
|
Version: 2,
|
|
},
|
|
}
|
|
eS2 := []*historypb.HistoryEvent{
|
|
{
|
|
EventId: 3,
|
|
Version: 2,
|
|
},
|
|
}
|
|
|
|
eS3 := []*historypb.HistoryEvent{
|
|
{
|
|
EventId: 4,
|
|
Version: 2,
|
|
},
|
|
}
|
|
|
|
v, err := validateEventsSlice(eS1, eS2)
|
|
s.Equal(int64(2), v)
|
|
s.Nil(err)
|
|
|
|
v, err = validateEventsSlice(eS1, eS3)
|
|
s.Equal(int64(0), v)
|
|
s.IsType(ErrEventSlicesNotConsecutive, err)
|
|
|
|
v, err = validateEventsSlice(eS1, nil)
|
|
s.Equal(int64(0), v)
|
|
s.IsType(ErrEmptyEventSlice, err)
|
|
}
|
|
|
|
func (s *replicationTaskSuite) TestValidateEvents() {
|
|
eS1 := []*historypb.HistoryEvent{
|
|
{
|
|
EventId: 1,
|
|
Version: 2,
|
|
},
|
|
{
|
|
EventId: 2,
|
|
Version: 2,
|
|
},
|
|
}
|
|
|
|
eS2 := []*historypb.HistoryEvent{
|
|
{
|
|
EventId: 1,
|
|
Version: 2,
|
|
},
|
|
{
|
|
EventId: 3,
|
|
Version: 2,
|
|
},
|
|
}
|
|
|
|
eS3 := []*historypb.HistoryEvent{
|
|
{
|
|
EventId: 1,
|
|
Version: 1,
|
|
},
|
|
{
|
|
EventId: 2,
|
|
Version: 2,
|
|
},
|
|
}
|
|
|
|
v, err := validateEvents(eS1)
|
|
s.Nil(err)
|
|
s.Equal(int64(2), v)
|
|
|
|
v, err = validateEvents(eS2)
|
|
s.Equal(int64(0), v)
|
|
s.IsType(ErrEventIDMismatch, err)
|
|
|
|
v, err = validateEvents(eS3)
|
|
s.Equal(int64(0), v)
|
|
s.IsType(ErrEventVersionMismatch, err)
|
|
}
|
|
|
|
func (s *replicationTaskSuite) TestSkipDuplicatedEvents_ValidInput_SkipEvents() {
|
|
workflowKey := definition.WorkflowKey{
|
|
WorkflowID: uuid.New(),
|
|
RunID: uuid.New(),
|
|
}
|
|
slice1 := []*historypb.HistoryEvent{
|
|
{
|
|
EventId: 11,
|
|
},
|
|
{
|
|
EventId: 12,
|
|
},
|
|
}
|
|
slice2 := []*historypb.HistoryEvent{
|
|
{
|
|
EventId: 13,
|
|
},
|
|
{
|
|
EventId: 14,
|
|
},
|
|
}
|
|
|
|
task, _ := newReplicationTask(
|
|
s.clusterMetadata,
|
|
nil,
|
|
workflowKey,
|
|
nil,
|
|
nil,
|
|
[][]*historypb.HistoryEvent{slice1, slice2},
|
|
nil,
|
|
"",
|
|
nil,
|
|
false,
|
|
)
|
|
err := task.skipDuplicatedEvents(1)
|
|
s.NoError(err)
|
|
s.Equal(1, len(task.getEvents()))
|
|
s.Equal(slice2, task.getEvents()[0])
|
|
s.Equal(int64(13), task.getFirstEvent().EventId)
|
|
s.Equal(int64(14), task.getLastEvent().EventId)
|
|
}
|
|
|
|
func (s *replicationTaskSuite) TestSkipDuplicatedEvents_InvalidInput_ErrorOut() {
|
|
workflowKey := definition.WorkflowKey{
|
|
WorkflowID: uuid.New(),
|
|
RunID: uuid.New(),
|
|
}
|
|
slice1 := []*historypb.HistoryEvent{
|
|
{
|
|
EventId: 11,
|
|
},
|
|
{
|
|
EventId: 12,
|
|
},
|
|
}
|
|
slice2 := []*historypb.HistoryEvent{
|
|
{
|
|
EventId: 13,
|
|
},
|
|
{
|
|
EventId: 14,
|
|
},
|
|
}
|
|
|
|
task, _ := newReplicationTask(
|
|
s.clusterMetadata,
|
|
nil,
|
|
workflowKey,
|
|
nil,
|
|
nil,
|
|
[][]*historypb.HistoryEvent{slice1, slice2},
|
|
nil,
|
|
"",
|
|
nil,
|
|
false,
|
|
)
|
|
err := task.skipDuplicatedEvents(2)
|
|
s.Error(err)
|
|
}
|
|
|
|
func (s *replicationTaskSuite) TestSkipDuplicatedEvents_ZeroInput_DoNothing() {
|
|
workflowKey := definition.WorkflowKey{
|
|
WorkflowID: uuid.New(),
|
|
RunID: uuid.New(),
|
|
}
|
|
slice1 := []*historypb.HistoryEvent{
|
|
{
|
|
EventId: 11,
|
|
},
|
|
{
|
|
EventId: 12,
|
|
},
|
|
}
|
|
slice2 := []*historypb.HistoryEvent{
|
|
{
|
|
EventId: 13,
|
|
},
|
|
{
|
|
EventId: 14,
|
|
},
|
|
}
|
|
|
|
task, _ := newReplicationTask(
|
|
s.clusterMetadata,
|
|
nil,
|
|
workflowKey,
|
|
nil,
|
|
nil,
|
|
[][]*historypb.HistoryEvent{slice1, slice2},
|
|
nil,
|
|
"",
|
|
nil,
|
|
false,
|
|
)
|
|
err := task.skipDuplicatedEvents(0)
|
|
s.NoError(err)
|
|
s.Equal(2, len(task.getEvents()))
|
|
s.Equal(slice1, task.getEvents()[0])
|
|
s.Equal(slice2, task.getEvents()[1])
|
|
}
|
|
|
|
func (s *replicationTaskSuite) TestResetInfo() {
|
|
workflowKey := definition.WorkflowKey{
|
|
WorkflowID: uuid.New(),
|
|
RunID: uuid.New(),
|
|
}
|
|
slice1 := []*historypb.HistoryEvent{
|
|
{
|
|
EventId: 13,
|
|
EventType: enumspb.EVENT_TYPE_WORKFLOW_TASK_FAILED,
|
|
},
|
|
{
|
|
EventId: 14,
|
|
},
|
|
}
|
|
|
|
task, _ := newReplicationTask(
|
|
s.clusterMetadata,
|
|
nil,
|
|
workflowKey,
|
|
nil,
|
|
nil,
|
|
[][]*historypb.HistoryEvent{slice1},
|
|
nil,
|
|
"",
|
|
nil,
|
|
false,
|
|
)
|
|
info := task.getBaseWorkflowInfo()
|
|
s.Nil(info)
|
|
s.False(task.isWorkflowReset())
|
|
}
|