mirror of
https://github.com/hanzoai/tasks.git
synced 2026-11-03 03:56:04 +00:00
Stephan BehnkeandGitHub
b43c4b0f8e
## What changed?
<!-- Describe what has changed in this PR -->
Linter to enforce import aliases for protobuf imports.
Enforced rules across entire codebase.
## Why?
<!-- Tell your future self why have you made these changes -->
Consistency. Relief reviewers from pointing it out.
We had 100+ violations.
## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
Running
```
make lint-code
.bin/golangci-lint-dafd65537336fdce063c492a7ab2a68cc89f8d52 run --config=.golangci.yml | grep importas
```
comes up empty (compared to say `grep typecheck`).
Plus compiler and tests ofc.
## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
Me smuggling in an easter egg into the code (I didn't, I swear 🙃)
## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->
## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->
81 lines
2.8 KiB
Go
81 lines
2.8 KiB
Go
// The MIT License
|
|
//
|
|
// Copyright (c) 2024 Temporal Technologies Inc. All rights reserved.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
// THE SOFTWARE.
|
|
|
|
package queues
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
persistencespb "go.temporal.io/server/api/persistence/v1"
|
|
"go.temporal.io/server/common/definition"
|
|
"go.temporal.io/server/service/history/tasks"
|
|
)
|
|
|
|
func TestGrouperNamespaceID_Key(t *testing.T) {
|
|
g := GrouperNamespaceID{}
|
|
k := g.Key(tasks.NewFakeTask(definition.NewWorkflowKey("nid", "", ""), tasks.CategoryTransfer, time.Now()))
|
|
require.Equal(t, "nid", k)
|
|
}
|
|
|
|
func TestGrouperNamespaceID_Predicate(t *testing.T) {
|
|
g := GrouperNamespaceID{}
|
|
p := g.Predicate([]any{"n1", "n2"})
|
|
require.Equal(t, tasks.NewNamespacePredicate([]string{"n1", "n2"}), p)
|
|
}
|
|
|
|
func TestGrouperStateMachineNamespaceIDAndDestination_Key(t *testing.T) {
|
|
g := GrouperStateMachineNamespaceIDAndDestination{}
|
|
task := &tasks.StateMachineOutboundTask{
|
|
StateMachineTask: tasks.StateMachineTask{
|
|
WorkflowKey: definition.NewWorkflowKey("nid", "", ""),
|
|
Info: &persistencespb.StateMachineTaskInfo{
|
|
Type: "3",
|
|
},
|
|
},
|
|
Destination: "dest",
|
|
}
|
|
k := g.Key(task)
|
|
require.Equal(t, tasks.TaskGroupNamespaceIDAndDestination{
|
|
TaskGroup: "3",
|
|
NamespaceID: "nid",
|
|
Destination: "dest",
|
|
}, k)
|
|
}
|
|
|
|
func TestGrouperStateMachineNamespaceIDAndDestination_Predicate(t *testing.T) {
|
|
g := GrouperStateMachineNamespaceIDAndDestination{}
|
|
groups := []tasks.TaskGroupNamespaceIDAndDestination{
|
|
{TaskGroup: "1", NamespaceID: "n1", Destination: "d1"},
|
|
{TaskGroup: "2", NamespaceID: "n2", Destination: "d2"},
|
|
}
|
|
untypedGroups := []any{}
|
|
for _, g := range groups {
|
|
untypedGroups = append(untypedGroups, g)
|
|
}
|
|
p := g.Predicate(untypedGroups)
|
|
|
|
expected := tasks.NewOutboundTaskPredicate(groups)
|
|
require.Equal(t, expected, p)
|
|
}
|