mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
## What changed? <!-- Describe what has changed in this PR --> Delete Namespace: move Nexus endpoint validation to workflow. ## Why? <!-- Tell your future self why have you made these changes --> Consolidate all delete namespace validation logic in one place. ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> Modified existing and new unit tests. ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> This is a breaking change for `DeleteNamespace` workflow. But this workflow is very short lived and chances of being upgraded while running are very low. ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> No. ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) --> No.
121 lines
4.7 KiB
Go
121 lines
4.7 KiB
Go
// The MIT License
|
|
//
|
|
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
|
|
//
|
|
// Copyright (c) 2020 Uber Technologies, Inc.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
// THE SOFTWARE.
|
|
|
|
package deletenamespace
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
"go.temporal.io/api/serviceerror"
|
|
"go.temporal.io/sdk/temporal"
|
|
persistencespb "go.temporal.io/server/api/persistence/v1"
|
|
"go.temporal.io/server/common/log"
|
|
"go.temporal.io/server/common/namespace"
|
|
"go.temporal.io/server/common/persistence"
|
|
"go.uber.org/mock/gomock"
|
|
)
|
|
|
|
func Test_GenerateDeletedNamespaceNameActivity(t *testing.T) {
|
|
ctrl := gomock.NewController(t)
|
|
metadataManager := persistence.NewMockMetadataManager(ctrl)
|
|
|
|
a := &localActivities{
|
|
metadataManager: metadataManager,
|
|
logger: log.NewTestLogger(),
|
|
}
|
|
|
|
metadataManager.EXPECT().GetNamespace(gomock.Any(), &persistence.GetNamespaceRequest{
|
|
Name: "namespace-deleted-names",
|
|
}).Return(nil, serviceerror.NewNamespaceNotFound("namespace-deleted-names"))
|
|
deletedName, err := a.GenerateDeletedNamespaceNameActivity(context.Background(), "namespace-id", "namespace")
|
|
require.NoError(t, err)
|
|
require.Equal(t, namespace.Name("namespace-deleted-names"), deletedName)
|
|
|
|
deletedName, err = a.GenerateDeletedNamespaceNameActivity(context.Background(), "namespace-id", "namespace-deleted-names")
|
|
require.NoError(t, err)
|
|
require.Equal(t, namespace.Name("namespace-deleted-names"), deletedName)
|
|
|
|
metadataManager.EXPECT().GetNamespace(gomock.Any(), &persistence.GetNamespaceRequest{
|
|
Name: "namespace-deleted-names",
|
|
}).Return(nil, nil)
|
|
metadataManager.EXPECT().GetNamespace(gomock.Any(), &persistence.GetNamespaceRequest{
|
|
Name: "namespace-deleted-namesp",
|
|
}).Return(nil, serviceerror.NewNamespaceNotFound("namespace-deleted-namesp"))
|
|
deletedName, err = a.GenerateDeletedNamespaceNameActivity(context.Background(), "namespace-id", "namespace")
|
|
require.NoError(t, err)
|
|
require.Equal(t, namespace.Name("namespace-deleted-namesp"), deletedName)
|
|
|
|
ctrl.Finish()
|
|
}
|
|
func Test_ValidateNexusEndpointsActivity(t *testing.T) {
|
|
ctrl := gomock.NewController(t)
|
|
nexusEndpointManager := persistence.NewMockNexusEndpointManager(ctrl)
|
|
|
|
a := &localActivities{
|
|
nexusEndpointManager: nexusEndpointManager,
|
|
logger: log.NewTestLogger(),
|
|
|
|
allowDeleteNamespaceIfNexusEndpointTarget: func() bool { return false },
|
|
nexusEndpointListDefaultPageSize: func() int { return 100 },
|
|
}
|
|
|
|
// The "fake" namespace ID is associated with a Nexus endoint.
|
|
nexusEndpointManager.EXPECT().ListNexusEndpoints(gomock.Any(), gomock.Any()).Return(&persistence.ListNexusEndpointsResponse{
|
|
Entries: []*persistencespb.NexusEndpointEntry{
|
|
{
|
|
Endpoint: &persistencespb.NexusEndpoint{
|
|
Spec: &persistencespb.NexusEndpointSpec{
|
|
Name: "test-endpoint",
|
|
Target: &persistencespb.NexusEndpointTarget{
|
|
Variant: &persistencespb.NexusEndpointTarget_Worker_{
|
|
Worker: &persistencespb.NexusEndpointTarget_Worker{
|
|
NamespaceId: "namespace-id",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}, nil).Times(2)
|
|
|
|
err := a.ValidateNexusEndpointsActivity(context.Background(), "namespace-id", "namespace")
|
|
require.Error(t, err)
|
|
var appErr *temporal.ApplicationError
|
|
require.ErrorAs(t, err, &appErr)
|
|
|
|
err = a.ValidateNexusEndpointsActivity(context.Background(), "namespace2-id", "namespace2")
|
|
require.NoError(t, err)
|
|
|
|
nexusEndpointManager.EXPECT().ListNexusEndpoints(gomock.Any(), gomock.Any()).Return(nil, errors.New("persistence failure"))
|
|
err = a.ValidateNexusEndpointsActivity(context.Background(), "namespace-id", "namespace")
|
|
require.Error(t, err)
|
|
require.Equal(t, err.Error(), "unable to list Nexus endpoints for namespace namespace: persistence failure")
|
|
|
|
ctrl.Finish()
|
|
}
|