mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
Alex ShtinandGitHub
0b33d20bec
## What changed? <!-- Describe what has changed in this PR --> Delete Namespace: make RPS dynamic. ## Why? <!-- Tell your future self why have you made these changes --> Previously `frontend.deleteNamespaceDeleteActivityRPS` was read once, before deletion of namespace is started and changes of that dynamic config didn't affect already started deletion. It was very inconvenient when huge namespaces were deleted because default RPS is just 100. Now it can be increased and decreased on the fly. NOTE: because delete workflow execution is async process, this RPS essentially controls rate at which delete execution tasks are created. This means that decrease of this value (let's say from `1000` to `10`) doesn't immediately slow down the process because already created tasks in transfer queue need to be drained first. ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> Existing tests and few manual runs. ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> No risks. Change is backward compatible. Old parameter is marked as deprecated and needs to be removed after next release (1.27). This is to cover rare case when new `DeleteExecutionsWorkflow` starts old `DeleteExecutionsActivity` during server deployment. ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> No. ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) --> No.
82 lines
3.0 KiB
Go
82 lines
3.0 KiB
Go
// The MIT License
|
|
//
|
|
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
|
|
//
|
|
// Copyright (c) 2020 Uber Technologies, Inc.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
// THE SOFTWARE.
|
|
|
|
package deleteexecutions
|
|
|
|
import (
|
|
"encoding/json"
|
|
)
|
|
|
|
const (
|
|
// Deprecated.
|
|
// TODO: Remove after 1.27 release.
|
|
defaultDeleteActivityRPS = 100
|
|
defaultPageSize = 1000
|
|
defaultPagesPerExecution = 256
|
|
defaultConcurrentDeleteExecutionsActivities = 4
|
|
maxConcurrentDeleteExecutionsActivities = 256
|
|
)
|
|
|
|
type (
|
|
DeleteExecutionsConfig struct {
|
|
// Deprecated.
|
|
// TODO: Remove after 1.27 release. RPS is now read directly by activity from config.
|
|
DeleteActivityRPS int
|
|
// Page size to read executions from visibility.
|
|
PageSize int
|
|
// Number of pages before returning ContinueAsNew.
|
|
PagesPerExecution int
|
|
// Number of concurrent delete executions activities.
|
|
// Must be not greater than PagesPerExecution and number of worker cores in the cluster.
|
|
ConcurrentDeleteExecutionsActivities int
|
|
}
|
|
)
|
|
|
|
func (cfg *DeleteExecutionsConfig) ApplyDefaults() {
|
|
if cfg.DeleteActivityRPS <= 0 {
|
|
cfg.DeleteActivityRPS = defaultDeleteActivityRPS
|
|
}
|
|
if cfg.PageSize <= 0 {
|
|
cfg.PageSize = defaultPageSize
|
|
}
|
|
if cfg.PagesPerExecution <= 0 {
|
|
cfg.PagesPerExecution = defaultPagesPerExecution
|
|
}
|
|
if cfg.ConcurrentDeleteExecutionsActivities <= 0 {
|
|
cfg.ConcurrentDeleteExecutionsActivities = defaultConcurrentDeleteExecutionsActivities
|
|
}
|
|
if cfg.ConcurrentDeleteExecutionsActivities > maxConcurrentDeleteExecutionsActivities {
|
|
cfg.ConcurrentDeleteExecutionsActivities = maxConcurrentDeleteExecutionsActivities
|
|
}
|
|
// It won't be able to start more than PagesPerExecution activities.
|
|
if cfg.ConcurrentDeleteExecutionsActivities > cfg.PagesPerExecution {
|
|
cfg.ConcurrentDeleteExecutionsActivities = cfg.PagesPerExecution
|
|
}
|
|
}
|
|
|
|
func (cfg *DeleteExecutionsConfig) String() string {
|
|
cfgBytes, _ := json.Marshal(cfg)
|
|
return string(cfgBytes)
|
|
}
|