Files
Carly de Frondevilleandrodrigozhou 28fdecaa07 Remove all sources of worker deployment NDE detectable by static workflowcheck (#7366)
## What changed?
Replace time.Now and range over map with deterministic equivalents.

Add replay tests validating no intrinsic NDE.

## Why?
<!-- Tell your future self why have you made these changes -->

## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->

## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->
2025-02-20 15:21:11 -08:00

83 lines
3.1 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package workerdeployment
import (
"compress/gzip"
"os"
"path/filepath"
"testing"
"time"
"github.com/stretchr/testify/require"
"go.temporal.io/sdk/client"
"go.temporal.io/sdk/worker"
"go.temporal.io/sdk/workflow"
deploymentspb "go.temporal.io/server/api/deployment/v1"
"go.temporal.io/server/common/log"
)
// TestReplays tests workflow logic backwards compatibility from previous versions.
func TestReplays(t *testing.T) {
replayer := worker.NewWorkflowReplayer()
drainageWorkflow := func(ctx workflow.Context, args *deploymentspb.DrainageWorkflowArgs) error {
refreshIntervalGetter := func() any {
return time.Minute
}
visibilityGracePeriodGetter := func() any {
return time.Minute
}
return DrainageWorkflow(ctx, refreshIntervalGetter, visibilityGracePeriodGetter, args)
}
deploymentWorkflow := func(ctx workflow.Context, args *deploymentspb.WorkerDeploymentWorkflowArgs) error {
maxVersionsGetter := func() int {
return 100
}
return Workflow(ctx, maxVersionsGetter, args)
}
replayer.RegisterWorkflowWithOptions(VersionWorkflow, workflow.RegisterOptions{Name: WorkerDeploymentVersionWorkflowType})
replayer.RegisterWorkflowWithOptions(deploymentWorkflow, workflow.RegisterOptions{Name: WorkerDeploymentWorkflowType})
replayer.RegisterWorkflowWithOptions(drainageWorkflow, workflow.RegisterOptions{Name: WorkerDeploymentDrainageWorkflowType})
files, err := filepath.Glob("testdata/replay_*.json.gz")
require.NoError(t, err)
logger := log.NewSdkLogger(log.NewTestLogger())
for _, filename := range files {
logger.Info("Replaying", "file", filename)
f, err := os.Open(filename)
require.NoError(t, err)
r, err := gzip.NewReader(f)
require.NoError(t, err)
history, err := client.HistoryFromJSON(r, client.HistoryJSONOptions{})
require.NoError(t, err)
err = replayer.ReplayWorkflowHistory(logger, history)
require.NoError(t, err)
_ = r.Close()
_ = f.Close()
}
}