Files
ShivamandStephan Behnke b63ae3fb51 stop infinite activity retries in the entity workflows (#7448)
## What changed?
<!-- Describe what has changed in this PR -->
- Right now, entity workflows related to versioning have infinite number
of retries happening. In the case of an unforeseen error, this might
leave our internal entity workflows locked and might require manual
intervention.
- The activity context, being used in all of the activities related to
the worker-deployment workflows, now has a maximum number of attempts
set to 5. This shall ensure that on the eve of an unforeseen error, the
deployment workflow will unlock itself after a maximum time of ~5 mins.
[ ~5 mins calculated by doing math involving backoff coefficient,
initial interval and maximum attempts ]

## Why?
<!-- Tell your future self why have you made these changes -->
- To not lock our own workflows.

## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
- Current Suite of tests to verify nothing is broken. 

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->

## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->
2025-03-25 15:43:26 -07:00

169 lines
7.1 KiB
Go

// The MIT License
//
// Copyright (c) 2024 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2024 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package workerdeployment
import (
"fmt"
"strings"
"time"
commonpb "go.temporal.io/api/common/v1"
enumspb "go.temporal.io/api/enums/v1"
"go.temporal.io/api/serviceerror"
"go.temporal.io/sdk/temporal"
"go.temporal.io/sdk/workflow"
deploymentspb "go.temporal.io/server/api/deployment/v1"
"go.temporal.io/server/common"
"go.temporal.io/server/common/sdk"
"go.temporal.io/server/common/searchattribute"
"go.temporal.io/server/common/worker_versioning"
)
const (
// Workflow types
WorkerDeploymentVersionWorkflowType = "temporal-sys-worker-deployment-version-workflow"
WorkerDeploymentWorkflowType = "temporal-sys-worker-deployment-workflow"
WorkerDeploymentDrainageWorkflowType = "temporal-sys-worker-deployment-version-drainage-workflow"
// Namespace division
WorkerDeploymentNamespaceDivision = "TemporalWorkerDeployment"
// Updates
RegisterWorkerInDeployment = "register-task-queue-worker" // for Worker Deployment Version wf
SyncVersionState = "sync-version-state" // for Worker Deployment Version wfs
UpdateVersionMetadata = "update-version-metadata" // for Worker Deployment Version wfs
SetCurrentVersion = "set-current-version" // for Worker Deployment wfs
SetRampingVersion = "set-ramping-version" // for Worker Deployment wfs
AddVersionToWorkerDeployment = "add-version-to-worker-deployment" // for Worker Deployment wfs
DeleteVersion = "delete-version" // for WorkerDeployment wfs
DeleteDeployment = "delete-deployment" // for WorkerDeployment wfs
// Signals
ForceCANSignalName = "force-continue-as-new" // for Worker Deployment Version _and_ Worker Deployment wfs
SyncDrainageSignalName = "sync-drainage-status"
TerminateDrainageSignal = "terminate-drainage"
SyncVersionSummarySignal = "sync-version-summary"
// Queries
QueryDescribeVersion = "describe-version" // for Worker Deployment Version wf
QueryDescribeDeployment = "describe-deployment" // for Worker Deployment wf
// Memos
WorkerDeploymentMemoField = "WorkerDeploymentMemo" // for Worker Deployment wf
// Prefixes, Delimeters and Keys
WorkerDeploymentVersionWorkflowIDPrefix = "temporal-sys-worker-deployment-version"
WorkerDeploymentVersionWorkflowIDDelimeter = ":"
WorkerDeploymentVersionWorkflowIDInitialSize = len(WorkerDeploymentVersionWorkflowIDDelimeter) + len(WorkerDeploymentVersionWorkflowIDPrefix)
WorkerDeploymentNameFieldName = "WorkerDeploymentName"
WorkerDeploymentBuildIDFieldName = "BuildID"
// Application error names for rejected updates
errNoChangeType = "errNoChange"
errTooManyVersions = "errTooManyVersions"
errTooManyDeployments = "errTooManyDeployments"
errVersionAlreadyExistsType = "errVersionAlreadyExists"
errMaxTaskQueuesInVersionType = "errMaxTaskQueuesInVersion"
errVersionAlreadyCurrentType = "errVersionAlreadyCurrent"
errVersionIsDraining = "Version cannot be deleted since it is draining."
errVersionNotFound = "Version not found in deployment"
errVersionHasPollers = "Version cannot be deleted since it has active pollers."
errVersionIsCurrentOrRamping = "Version cannot be deleted since it is current or ramping."
errConflictTokenMismatchType = "errConflictTokenMismatch"
)
var (
WorkerDeploymentVisibilityBaseListQuery = fmt.Sprintf(
"%s = '%s' AND %s = '%s' AND %s = '%s'",
searchattribute.WorkflowType,
WorkerDeploymentWorkflowType,
searchattribute.TemporalNamespaceDivision,
WorkerDeploymentNamespaceDivision,
searchattribute.ExecutionStatus,
enumspb.WORKFLOW_EXECUTION_STATUS_RUNNING.String(),
)
)
var (
defaultActivityOptions = workflow.ActivityOptions{
StartToCloseTimeout: 1 * time.Minute,
RetryPolicy: &temporal.RetryPolicy{
InitialInterval: 100 * time.Millisecond,
MaximumAttempts: 5,
},
}
)
// validateVersionWfParams is a helper that verifies if the fields used for generating
// Worker Deployment Version related workflowID's are valid
func validateVersionWfParams(fieldName string, field string, maxIDLengthLimit int) error {
// Length checks
if field == "" {
return serviceerror.NewInvalidArgument(fmt.Sprintf("%v cannot be empty", fieldName))
}
// Length of each field should be: (MaxIDLengthLimit - (prefix + delimeter length)) / 2
if len(field) > (maxIDLengthLimit-WorkerDeploymentVersionWorkflowIDInitialSize)/2 {
return serviceerror.NewInvalidArgument(fmt.Sprintf("size of %v larger than the maximum allowed", fieldName))
}
// deploymentName cannot have "."
if fieldName == WorkerDeploymentNameFieldName && strings.Contains(field, worker_versioning.WorkerDeploymentVersionIdDelimiter) {
return serviceerror.NewInvalidArgument(fmt.Sprintf("worker deployment name cannot contain '%s'", worker_versioning.WorkerDeploymentVersionIdDelimiter))
}
// buildID or deployment name cannot start with "__"
if strings.HasPrefix(field, "__") {
return serviceerror.NewInvalidArgument(fmt.Sprintf("%v cannot start with '__'", fieldName))
}
// UTF-8 check
return common.ValidateUTF8String(fieldName, field)
}
func DecodeWorkerDeploymentMemo(memo *commonpb.Memo) *deploymentspb.WorkerDeploymentWorkflowMemo {
var workerDeploymentWorkflowMemo deploymentspb.WorkerDeploymentWorkflowMemo
err := sdk.PreferProtoDataConverter.FromPayload(memo.Fields[WorkerDeploymentMemoField], &workerDeploymentWorkflowMemo)
if err != nil {
return nil
}
return &workerDeploymentWorkflowMemo
}
func getSafeDurationConfig(ctx workflow.Context, id string, unsafeGetter func() any, defaultValue time.Duration) (time.Duration, error) {
get := func(_ workflow.Context) interface{} {
return unsafeGetter()
}
var value time.Duration
if err := workflow.MutableSideEffect(ctx, id, get, durationEq).Get(&value); err != nil {
return defaultValue, err
}
return value, nil
}
func durationEq(a, b any) bool {
return a == b
}