Files
tasks/tests/eager_workflow_start_test.go
Alex ShtinandGitHub 9964c549b8 Refactor: move functional test suite scaffolding code to FunctionalTestBase (#7085)
## What changed?
<!-- Describe what has changed in this PR -->
Main change is: move functional test suite scaffolding code to
`FunctionalTestBase`. Most of the scaffolding code and test helpers
(more to move) are now in `FunctionalTestBase`. Hierarchy is the
following:
```
- FunctionalTestBase - base for all functional tests
  - FunctionalTestSuite - has TaskPoller in it and should be used as base for all non-SDK based tests
    - many test suites such as TestUpdateWorkflowSuite.
    - ...
    - ...
  - FunctionalTestSdkSuite - has SdkClient and SdkWorker in it and should be used as base for all SDK based tests
    - many test suites such as UpdateWorkflowSdkSuite
    - ...
    - ...
  - some test suites which don't need neither task poller nor SDK. Such as TLSFunctionalSuite
```


Few minor refactorings:
- replace `SetDynamicConfigOverrides` method with
`WithDynamicConfigOverrides` option for `SetupTestCluster()` method.
More DC cleanups are needed there.
- Many renames for better readability. 
- Left few TODOs for myself, for later.

## Why?
<!-- Tell your future self why have you made these changes -->

## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
Run it.

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
No risks.

## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->
No.

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->
No.
2025-01-15 22:39:16 -08:00

227 lines
9.0 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package tests
import (
"fmt"
"testing"
"time"
"github.com/pborman/uuid"
"github.com/stretchr/testify/suite"
commandpb "go.temporal.io/api/command/v1"
commonpb "go.temporal.io/api/common/v1"
enumspb "go.temporal.io/api/enums/v1"
taskqueuepb "go.temporal.io/api/taskqueue/v1"
"go.temporal.io/api/workflowservice/v1"
"go.temporal.io/sdk/client"
"go.temporal.io/sdk/converter"
"go.temporal.io/server/common/dynamicconfig"
"go.temporal.io/server/tests/testcore"
"google.golang.org/protobuf/proto"
"google.golang.org/protobuf/types/known/durationpb"
)
type EagerWorkflowTestSuite struct {
testcore.FunctionalTestSuite
}
func TestEagerWorkflowTestSuite(t *testing.T) {
t.Parallel()
suite.Run(t, new(EagerWorkflowTestSuite))
}
func (s *EagerWorkflowTestSuite) defaultWorkflowID() string {
return fmt.Sprintf("functional-%v", s.T().Name())
}
func (s *EagerWorkflowTestSuite) defaultTaskQueue() *taskqueuepb.TaskQueue {
name := fmt.Sprintf("functional-queue-%v", s.T().Name())
return &taskqueuepb.TaskQueue{Name: name, Kind: enumspb.TASK_QUEUE_KIND_NORMAL}
}
func (s *EagerWorkflowTestSuite) startEagerWorkflow(baseOptions *workflowservice.StartWorkflowExecutionRequest) *workflowservice.StartWorkflowExecutionResponse {
options := proto.Clone(baseOptions).(*workflowservice.StartWorkflowExecutionRequest) //nolint:revive
options.RequestEagerExecution = true
if options.GetNamespace() == "" {
options.Namespace = s.Namespace().String()
}
if options.Identity == "" {
options.Identity = "test"
}
if options.WorkflowId == "" {
options.WorkflowId = s.defaultWorkflowID()
}
if options.WorkflowType == nil {
options.WorkflowType = &commonpb.WorkflowType{Name: "Workflow"}
}
if options.TaskQueue == nil {
options.TaskQueue = s.defaultTaskQueue()
}
if options.RequestId == "" {
options.RequestId = uuid.New()
}
response, err := s.FrontendClient().StartWorkflowExecution(testcore.NewContext(), options)
s.Require().NoError(err)
return response
}
func (s *EagerWorkflowTestSuite) respondWorkflowTaskCompleted(task *workflowservice.PollWorkflowTaskQueueResponse, result interface{}) {
dataConverter := converter.GetDefaultDataConverter()
payloads, err := dataConverter.ToPayloads(result)
s.Require().NoError(err)
completion := workflowservice.RespondWorkflowTaskCompletedRequest{
Namespace: s.Namespace().String(),
Identity: "test",
TaskToken: task.TaskToken,
Commands: []*commandpb.Command{{CommandType: enumspb.COMMAND_TYPE_COMPLETE_WORKFLOW_EXECUTION, Attributes: &commandpb.Command_CompleteWorkflowExecutionCommandAttributes{
CompleteWorkflowExecutionCommandAttributes: &commandpb.CompleteWorkflowExecutionCommandAttributes{
Result: payloads,
},
}}},
}
_, err = s.FrontendClient().RespondWorkflowTaskCompleted(testcore.NewContext(), &completion)
s.Require().NoError(err)
}
func (s *EagerWorkflowTestSuite) pollWorkflowTaskQueue() *workflowservice.PollWorkflowTaskQueueResponse {
task, err := s.FrontendClient().PollWorkflowTaskQueue(testcore.NewContext(), &workflowservice.PollWorkflowTaskQueueRequest{
Namespace: s.Namespace().String(),
TaskQueue: s.defaultTaskQueue(),
Identity: "test",
})
s.Require().NotNil(task, "PollWorkflowTaskQueue response was empty")
s.Require().NoError(err)
return task
}
func (s *EagerWorkflowTestSuite) getWorkflowStringResult(workflowID, runID string) string {
c, err := client.Dial(client.Options{HostPort: s.FrontendGRPCAddress(), Namespace: s.Namespace().String()})
s.Require().NoError(err)
run := c.GetWorkflow(testcore.NewContext(), workflowID, runID)
var result string
err = run.Get(testcore.NewContext(), &result)
s.Require().NoError(err)
return result
}
func (s *EagerWorkflowTestSuite) TestEagerWorkflowStart_StartNew() {
// Add a search attribute to verify that per namespace search attribute mapping is properly applied in the
// response.
response := s.startEagerWorkflow(&workflowservice.StartWorkflowExecutionRequest{
SearchAttributes: &commonpb.SearchAttributes{
IndexedFields: map[string]*commonpb.Payload{
"CustomKeywordField": {
Metadata: map[string][]byte{"encoding": []byte("json/plain")},
Data: []byte(`"value"`),
},
},
},
})
task := response.GetEagerWorkflowTask()
s.Require().NotNil(task, "StartWorkflowExecution response did not contain a workflow task")
kwData := task.History.Events[0].GetWorkflowExecutionStartedEventAttributes().SearchAttributes.IndexedFields["CustomKeywordField"].Data
s.Require().Equal(`"value"`, string(kwData))
s.respondWorkflowTaskCompleted(task, "ok")
// Verify workflow completes and client can get the result
result := s.getWorkflowStringResult(s.defaultWorkflowID(), response.RunId)
s.Require().Equal("ok", result)
}
func (s *EagerWorkflowTestSuite) TestEagerWorkflowStart_RetryTaskAfterTimeout() {
response := s.startEagerWorkflow(&workflowservice.StartWorkflowExecutionRequest{
// Should give enough grace time even in slow CI
WorkflowTaskTimeout: durationpb.New(2 * time.Second),
})
task := response.GetEagerWorkflowTask()
s.Require().NotNil(task, "StartWorkflowExecution response did not contain a workflow task")
// Let it timeout so it can be polled via standard matching based dispatch
task = s.pollWorkflowTaskQueue()
s.respondWorkflowTaskCompleted(task, "ok")
// Verify workflow completes and client can get the result
result := s.getWorkflowStringResult(s.defaultWorkflowID(), response.RunId)
s.Require().Equal("ok", result)
}
func (s *EagerWorkflowTestSuite) TestEagerWorkflowStart_RetryStartAfterTimeout() {
request := &workflowservice.StartWorkflowExecutionRequest{
// Should give enough grace time even in slow CI
WorkflowTaskTimeout: durationpb.New(2 * time.Second),
RequestId: uuid.New(),
}
response := s.startEagerWorkflow(request)
task := response.GetEagerWorkflowTask()
s.Require().NotNil(task, "StartWorkflowExecution response did not contain a workflow task")
// Let it timeout
time.Sleep(request.WorkflowTaskTimeout.AsDuration()) //nolint:forbidigo
response = s.startEagerWorkflow(request)
task = response.GetEagerWorkflowTask()
s.Require().Nil(task, "StartWorkflowExecution response contained a workflow task")
task = s.pollWorkflowTaskQueue()
s.respondWorkflowTaskCompleted(task, "ok")
// Verify workflow completes and client can get the result
result := s.getWorkflowStringResult(s.defaultWorkflowID(), response.RunId)
s.Require().Equal("ok", result)
}
func (s *EagerWorkflowTestSuite) TestEagerWorkflowStart_RetryStartImmediately() {
request := &workflowservice.StartWorkflowExecutionRequest{RequestId: uuid.New()}
response := s.startEagerWorkflow(request)
task := response.GetEagerWorkflowTask()
s.Require().NotNil(task, "StartWorkflowExecution response did not contain a workflow task")
response = s.startEagerWorkflow(request)
task = response.GetEagerWorkflowTask()
s.Require().NotNil(task, "StartWorkflowExecution response did not contain a workflow task")
s.respondWorkflowTaskCompleted(task, "ok")
// Verify workflow completes and client can get the result
result := s.getWorkflowStringResult(s.defaultWorkflowID(), response.RunId)
s.Require().Equal("ok", result)
}
func (s *EagerWorkflowTestSuite) TestEagerWorkflowStart_TerminateDuplicate() {
// reset reuse minimal interval to allow workflow termination
s.OverrideDynamicConfig(dynamicconfig.WorkflowIdReuseMinimalInterval, 0)
request := &workflowservice.StartWorkflowExecutionRequest{
WorkflowIdReusePolicy: enumspb.WORKFLOW_ID_REUSE_POLICY_TERMINATE_IF_RUNNING,
}
s.startEagerWorkflow(request)
response := s.startEagerWorkflow(request)
task := response.GetEagerWorkflowTask()
s.Require().NotNil(task, "StartWorkflowExecution response did not contain a workflow task")
s.respondWorkflowTaskCompleted(task, "ok")
// Verify workflow completes and client can get the result
result := s.getWorkflowStringResult(s.defaultWorkflowID(), response.RunId)
s.Require().Equal("ok", result)
}