Files
tasks/tests/tls_test.go
Alex ShtinandGitHub 9964c549b8 Refactor: move functional test suite scaffolding code to FunctionalTestBase (#7085)
## What changed?
<!-- Describe what has changed in this PR -->
Main change is: move functional test suite scaffolding code to
`FunctionalTestBase`. Most of the scaffolding code and test helpers
(more to move) are now in `FunctionalTestBase`. Hierarchy is the
following:
```
- FunctionalTestBase - base for all functional tests
  - FunctionalTestSuite - has TaskPoller in it and should be used as base for all non-SDK based tests
    - many test suites such as TestUpdateWorkflowSuite.
    - ...
    - ...
  - FunctionalTestSdkSuite - has SdkClient and SdkWorker in it and should be used as base for all SDK based tests
    - many test suites such as UpdateWorkflowSdkSuite
    - ...
    - ...
  - some test suites which don't need neither task poller nor SDK. Such as TLSFunctionalSuite
```


Few minor refactorings:
- replace `SetDynamicConfigOverrides` method with
`WithDynamicConfigOverrides` option for `SetupTestCluster()` method.
More DC cleanups are needed there.
- Many renames for better readability. 
- Left few TODOs for myself, for later.

## Why?
<!-- Tell your future self why have you made these changes -->

## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
Run it.

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
No risks.

## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->
No.

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->
No.
2025-01-15 22:39:16 -08:00

150 lines
4.8 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package tests
import (
"context"
"net/http"
"sync"
"testing"
"time"
"github.com/stretchr/testify/suite"
"go.temporal.io/api/workflowservice/v1"
sdkclient "go.temporal.io/sdk/client"
"go.temporal.io/server/common/authorization"
"go.temporal.io/server/common/rpc"
"go.temporal.io/server/tests/testcore"
)
type TLSFunctionalSuite struct {
testcore.FunctionalTestBase
sdkClient sdkclient.Client
}
func TestTLSFunctionalSuite(t *testing.T) {
t.Parallel()
suite.Run(t, new(TLSFunctionalSuite))
}
func (s *TLSFunctionalSuite) SetupSuite() {
s.FunctionalTestBase.SetupSuiteWithCluster("testdata/tls_cluster.yaml")
}
func (s *TLSFunctionalSuite) TearDownSuite() {
s.FunctionalTestBase.TearDownCluster()
}
func (s *TLSFunctionalSuite) SetupTest() {
s.FunctionalTestBase.SetupTest()
var err error
s.sdkClient, err = sdkclient.Dial(sdkclient.Options{
HostPort: s.FrontendGRPCAddress(),
Namespace: s.Namespace().String(),
ConnectionOptions: sdkclient.ConnectionOptions{
TLS: s.GetTestCluster().Host().TlsConfigProvider().FrontendClientConfig,
},
})
s.NoError(err)
}
func (s *TLSFunctionalSuite) TearDownTest() {
if s.sdkClient != nil {
s.sdkClient.Close()
}
}
func (s *TLSFunctionalSuite) TestGRPCMTLS() {
ctx, cancel := rpc.NewContextWithTimeoutAndVersionHeaders(time.Minute)
defer cancel()
// Track auth info
calls := s.trackAuthInfoByCall()
// Make a list-open call
_, _ = s.sdkClient.ListOpenWorkflow(ctx, &workflowservice.ListOpenWorkflowExecutionsRequest{})
// Confirm auth info as expected
authInfo, ok := calls.Load("/temporal.api.workflowservice.v1.WorkflowService/ListOpenWorkflowExecutions")
s.Require().True(ok)
s.Require().Equal(testcore.TlsCertCommonName, authInfo.(*authorization.AuthInfo).TLSSubject.CommonName)
}
func (s *TLSFunctionalSuite) TestHTTPMTLS() {
if s.HttpAPIAddress() == "" {
s.T().Skip("HTTP API server not enabled")
}
// Track auth info
calls := s.trackAuthInfoByCall()
// Confirm non-HTTPS call is rejected with 400
resp, err := http.Get("http://" + s.HttpAPIAddress() + "/namespaces/" + s.Namespace().String() + "/workflows")
s.Require().NoError(err)
s.Require().Equal(http.StatusBadRequest, resp.StatusCode)
// Create HTTP client with TLS config
httpClient := http.Client{
Transport: &http.Transport{
TLSClientConfig: s.GetTestCluster().Host().TlsConfigProvider().FrontendClientConfig,
},
}
// Make a list call
req, err := http.NewRequest("GET", "https://"+s.HttpAPIAddress()+"/namespaces/"+s.Namespace().String()+"/workflows", nil)
s.Require().NoError(err)
resp, err = httpClient.Do(req)
s.Require().NoError(err)
s.Require().Equal(http.StatusOK, resp.StatusCode)
// Confirm auth info as expected
authInfo, ok := calls.Load("/temporal.api.workflowservice.v1.WorkflowService/ListWorkflowExecutions")
s.Require().True(ok)
s.Require().Equal(testcore.TlsCertCommonName, authInfo.(*authorization.AuthInfo).TLSSubject.CommonName)
}
func (s *TLSFunctionalSuite) trackAuthInfoByCall() *sync.Map {
var calls sync.Map
// Put auth info on claim, then use authorizer to set on the map by call
s.GetTestCluster().Host().SetOnGetClaims(func(authInfo *authorization.AuthInfo) (*authorization.Claims, error) {
return &authorization.Claims{
System: authorization.RoleAdmin,
Extensions: authInfo,
}, nil
})
s.GetTestCluster().Host().SetOnAuthorize(func(
ctx context.Context,
caller *authorization.Claims,
target *authorization.CallTarget,
) (authorization.Result, error) {
//nolint:revive
if authInfo, _ := caller.Extensions.(*authorization.AuthInfo); authInfo != nil {
calls.Store(target.APIName, authInfo)
}
return authorization.Result{Decision: authorization.DecisionAllow}, nil
})
return &calls
}