Files
tasks/tools/tdbg/app.go
Alex ShtinandGitHub e9bf129fdc Unalias and validate search attributes when import workflow history (#6563)
## What changed?
<!-- Describe what has changed in this PR -->
Unalias and validate search attributes when import workflow history.

## Why?
<!-- Tell your future self why have you made these changes -->
Search attributes in workflow histostory JSON file might use aliases (if
history was exported using `temporal` cli) or be invalid
(name/type/length). Previously import blindly accepted any search
attributes and then background visibility task processing could fail.
Now search attributes are validated and unaliased (if needed) before
getting to the history service.

## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
Added new unit tests for both valid and invalid cases.

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
No risks.

## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->
No.
2024-10-04 22:43:34 +00:00

169 lines
5.2 KiB
Go

// The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package tdbg
import (
"fmt"
"io"
"os"
"runtime/debug"
"github.com/temporalio/tctl-kit/pkg/color"
"github.com/urfave/cli/v2"
"go.temporal.io/server/common/headers"
"go.temporal.io/server/service/history/tasks"
)
type (
// Params which are customizable for the CLI application.
Params struct {
// ClientFactory creates Temporal service clients for tdbg to use.
ClientFactory ClientFactory
// TaskCategoryRegistry is used to determine which task categories are available for tdbg to use.
TaskCategoryRegistry tasks.TaskCategoryRegistry
// Writer is used to write output from tdbg. The default is os.Stdout.
Writer io.Writer
// ErrWriter is used to write errors from tdbg. The default is os.Stderr.
ErrWriter io.Writer
// TaskBlobEncoder is needed for custom task serialization. The default uses PredefinedTaskBlobDeserializer.
TaskBlobEncoder TaskBlobEncoder
}
// Option modifies the Params for tdbg.
Option func(params *Params)
)
// NewCliApp instantiates a new instance of the CLI application.
func NewCliApp(opts ...Option) *cli.App {
params := Params{
ClientFactory: NewClientFactory(),
TaskCategoryRegistry: tasks.NewDefaultTaskCategoryRegistry(),
Writer: os.Stdout,
ErrWriter: os.Stderr,
TaskBlobEncoder: NewProtoTaskBlobEncoder(NewPredefinedTaskBlobDeserializer()),
}
for _, opt := range opts {
opt(&params)
}
app := cli.NewApp()
app.Name = "tdbg"
app.Usage = "A command-line tool for Temporal server debugging"
app.Version = headers.ServerVersion
app.Flags = []cli.Flag{
&cli.StringFlag{
Name: FlagAddress,
Value: "",
Usage: "host:port for Temporal frontend service",
EnvVars: []string{"TEMPORAL_CLI_ADDRESS"},
},
&cli.StringFlag{
Name: FlagNamespace,
Aliases: FlagNamespaceAlias,
Value: "default",
Usage: "Temporal workflow namespace",
EnvVars: []string{"TEMPORAL_CLI_NAMESPACE"},
},
&cli.IntFlag{
Name: FlagContextTimeout,
Aliases: FlagContextTimeoutAlias,
Value: defaultContextTimeoutInSeconds,
Usage: "Optional timeout for context of RPC call in seconds",
EnvVars: []string{"TEMPORAL_CONTEXT_TIMEOUT"},
},
&cli.BoolFlag{
Name: FlagYes,
Usage: "Automatically confirm all prompts",
},
&cli.StringFlag{
Name: FlagTLSCertPath,
Value: "",
Usage: "Path to x509 certificate",
EnvVars: []string{"TEMPORAL_CLI_TLS_CERT"},
},
&cli.StringFlag{
Name: FlagTLSKeyPath,
Value: "",
Usage: "Path to private key",
EnvVars: []string{"TEMPORAL_CLI_TLS_KEY"},
},
&cli.StringFlag{
Name: FlagTLSCaPath,
Value: "",
Usage: "Path to server CA certificate",
EnvVars: []string{"TEMPORAL_CLI_TLS_CA"},
},
&cli.BoolFlag{
Name: FlagTLSDisableHostVerification,
Usage: "Disable tls host name verification (tls must be enabled)",
EnvVars: []string{"TEMPORAL_CLI_TLS_DISABLE_HOST_VERIFICATION"},
},
&cli.StringFlag{
Name: FlagTLSServerName,
Value: "",
Usage: "Override for target server name",
EnvVars: []string{"TEMPORAL_CLI_TLS_SERVER_NAME"},
},
&cli.StringFlag{
Name: color.FlagColor,
Usage: fmt.Sprintf("When to use color: %v, %v, %v.", color.Auto, color.Always, color.Never),
Value: string(color.Auto),
},
}
prompterFactory := NewPrompterFactory()
app.Commands = getCommands(
params.ClientFactory,
NewDLQServiceProvider(
params.ClientFactory,
params.TaskBlobEncoder,
params.TaskCategoryRegistry,
params.Writer,
prompterFactory,
),
params.TaskCategoryRegistry,
prompterFactory,
params.TaskBlobEncoder,
)
app.ExitErrHandler = handleError
app.Writer = params.Writer
app.ErrWriter = params.ErrWriter
return app
}
func handleError(c *cli.Context, err error) {
if err == nil {
return
}
_, _ = fmt.Fprintf(c.App.ErrWriter, "%s %+v\n", color.Red(c, "Error:"), err)
if os.Getenv(showErrorStackEnv) != `` {
_, _ = fmt.Fprintln(c.App.ErrWriter, color.Magenta(c, "Stack trace:"))
debug.PrintStack()
} else {
_, _ = fmt.Fprintf(c.App.ErrWriter, "('export %s=1' to see stack traces)\n", showErrorStackEnv)
}
cli.OsExiter(1)
}