mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
David ReissandGitHub
57625312ab
## What changed? - Add counter metric for total suspected deadlocks - Add gauge metric for current unresolved suspected deadlocks ## Why? These could be used in alerting or health checking. ## How did you test it? - [ ] built - [ ] run locally and tested manually - [ ] covered by existing tests - [x] added new unit test(s) - [ ] added new functional test(s)
77 lines
2.1 KiB
Go
77 lines
2.1 KiB
Go
package deadlock
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
"go.temporal.io/server/common/clock"
|
|
"go.temporal.io/server/common/dynamicconfig"
|
|
"go.temporal.io/server/common/goro"
|
|
"go.temporal.io/server/common/log"
|
|
"go.temporal.io/server/common/metrics"
|
|
"go.temporal.io/server/common/metrics/metricstest"
|
|
"go.temporal.io/server/common/pingable"
|
|
)
|
|
|
|
type blockingPingable struct{ done chan struct{} }
|
|
|
|
func (b *blockingPingable) GetPingChecks() []pingable.Check {
|
|
return []pingable.Check{{
|
|
Name: "test",
|
|
Timeout: 10 * time.Millisecond,
|
|
Ping: func() []pingable.Pingable {
|
|
<-b.done
|
|
return nil
|
|
},
|
|
}}
|
|
}
|
|
|
|
func TestCurrentCounterAndGauge(t *testing.T) {
|
|
mh := metricstest.NewCaptureHandler()
|
|
dd := NewDeadlockDetector(params{
|
|
Logger: log.NewNoopLogger(),
|
|
Collection: dynamicconfig.NewNoopCollection(),
|
|
MetricsHandler: mh,
|
|
})
|
|
|
|
lc := &loopContext{
|
|
dd: dd,
|
|
p: goro.NewAdaptivePool(clock.NewRealTimeSource(), 0, 1, 10*time.Millisecond, 10),
|
|
root: nil,
|
|
}
|
|
defer lc.p.Stop()
|
|
|
|
b := &blockingPingable{done: make(chan struct{})}
|
|
check := b.GetPingChecks()[0]
|
|
|
|
capture := mh.StartCapture()
|
|
go lc.check(context.Background(), check)
|
|
|
|
require.EventuallyWithT(t, func(collect *assert.CollectT) {
|
|
require.Equal(collect, int64(1), dd.CurrentSuspected())
|
|
}, time.Second, time.Millisecond)
|
|
|
|
snapshot := capture.Snapshot()
|
|
current := snapshot[metrics.DDCurrentSuspectedDeadlocks.Name()]
|
|
counter := snapshot[metrics.DDSuspectedDeadlocks.Name()]
|
|
require.Len(t, current, 1)
|
|
require.Equal(t, 1.0, current[0].Value)
|
|
require.Len(t, counter, 1)
|
|
require.Equal(t, int64(1), counter[0].Value)
|
|
|
|
close(b.done)
|
|
require.EventuallyWithT(t, func(collect *assert.CollectT) {
|
|
require.Equal(collect, int64(0), dd.CurrentSuspected())
|
|
}, time.Second, time.Millisecond)
|
|
|
|
snapshot = capture.Snapshot()
|
|
current = snapshot[metrics.DDCurrentSuspectedDeadlocks.Name()]
|
|
counter = snapshot[metrics.DDSuspectedDeadlocks.Name()]
|
|
require.Len(t, current, 2)
|
|
require.Equal(t, 0.0, current[1].Value)
|
|
require.Len(t, counter, 1)
|
|
}
|