mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-30 14:56:19 +00:00
## What changed? Refactor: use new `serviceerror.New...f` constructors. ## Why? Most of service errors now supports `fmt.Sprintf` format and they should be used instead of `fmt.Sprintf`. ## How did you test it? - [ ] built - [ ] run locally and tested manually - [x] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s)
115 lines
3.6 KiB
Go
115 lines
3.6 KiB
Go
package addtasks
|
|
|
|
import (
|
|
"context"
|
|
|
|
commonpb "go.temporal.io/api/common/v1"
|
|
"go.temporal.io/api/serviceerror"
|
|
"go.temporal.io/server/api/historyservice/v1"
|
|
"go.temporal.io/server/common/definition"
|
|
"go.temporal.io/server/common/persistence"
|
|
"go.temporal.io/server/service/history/api"
|
|
historyi "go.temporal.io/server/service/history/interfaces"
|
|
"go.temporal.io/server/service/history/tasks"
|
|
)
|
|
|
|
type (
|
|
// TaskDeserializer is a trimmed version of [go.temporal.io/server/common/persistence/serialization.Serializer] that
|
|
// requires only the DeserializeTask method.
|
|
TaskDeserializer interface {
|
|
DeserializeTask(category tasks.Category, blob *commonpb.DataBlob) (tasks.Task, error)
|
|
}
|
|
)
|
|
|
|
const (
|
|
// maxTasksPerRequest is the maximum number of tasks that can be added in a single AddTasks API call. We set this to
|
|
// prevent the history service from OOMing when a client sends a request with a large number of tasks because we
|
|
// will deserialize all tasks in memory before adding them to the queue.
|
|
maxTasksPerRequest = 1000
|
|
)
|
|
|
|
// Invoke is the implementation of the history service's AddTasks API. This exposes the [shard.Context.AddTasks] API via
|
|
// the history service. This method works by batching tasks by workflow run, and then invoking the relevant shard's
|
|
// AddTasks API for each task batch. See [historyservice.HistoryServiceClient.AddTasks] for more details. We don't do
|
|
// any validation on the shard ID because that must have been done by whoever provided the shard.Context to this method.
|
|
func Invoke(
|
|
ctx context.Context,
|
|
shardContext historyi.ShardContext,
|
|
deserializer TaskDeserializer,
|
|
numShards int,
|
|
req *historyservice.AddTasksRequest,
|
|
taskRegistry tasks.TaskCategoryRegistry,
|
|
) (*historyservice.AddTasksResponse, error) {
|
|
if len(req.Tasks) > maxTasksPerRequest {
|
|
return nil, serviceerror.NewInvalidArgumentf(
|
|
"Too many tasks in request: %d > %d",
|
|
len(req.Tasks),
|
|
maxTasksPerRequest,
|
|
)
|
|
}
|
|
|
|
if len(req.Tasks) == 0 {
|
|
return nil, serviceerror.NewInvalidArgument("No tasks in request")
|
|
}
|
|
|
|
taskBatches := make(map[definition.WorkflowKey]map[tasks.Category][]tasks.Task)
|
|
|
|
for i, task := range req.Tasks {
|
|
if task == nil {
|
|
return nil, serviceerror.NewInvalidArgumentf("Nil task at index: %d", i)
|
|
}
|
|
|
|
category, err := api.GetTaskCategory(int(task.CategoryId), taskRegistry)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
if task.Blob == nil {
|
|
return nil, serviceerror.NewInvalidArgumentf(
|
|
"Task blob is nil at index: %d",
|
|
i,
|
|
)
|
|
}
|
|
|
|
deserializedTask, err := deserializer.DeserializeTask(category, task.Blob)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
shardID := tasks.GetShardIDForTask(deserializedTask, numShards)
|
|
if shardID != int(req.ShardId) {
|
|
return nil, serviceerror.NewInvalidArgumentf(
|
|
"Task is for wrong shard: index = %d, task shard = %d, request shard = %d",
|
|
i, shardID, req.ShardId,
|
|
)
|
|
}
|
|
|
|
// group by namespaceID + workflowID
|
|
workflowKey := definition.NewWorkflowKey(
|
|
deserializedTask.GetNamespaceID(),
|
|
deserializedTask.GetWorkflowID(),
|
|
"",
|
|
)
|
|
if _, ok := taskBatches[workflowKey]; !ok {
|
|
taskBatches[workflowKey] = make(map[tasks.Category][]tasks.Task, 1)
|
|
}
|
|
|
|
taskBatches[workflowKey][category] = append(taskBatches[workflowKey][category], deserializedTask)
|
|
}
|
|
|
|
for workflowKey, taskBatch := range taskBatches {
|
|
err := shardContext.AddTasks(ctx, &persistence.AddHistoryTasksRequest{
|
|
ShardID: shardContext.GetShardID(),
|
|
RangeID: shardContext.GetRangeID(),
|
|
NamespaceID: workflowKey.NamespaceID,
|
|
WorkflowID: workflowKey.WorkflowID,
|
|
Tasks: taskBatch,
|
|
})
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
}
|
|
|
|
return &historyservice.AddTasksResponse{}, nil
|
|
}
|