mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
Kent GruberandGitHub
eadf754dc8
## What changed? This PR aims to avoid usage of [`strings.Split`](https://pkg.go.dev/strings#Split) where possible in favor of better string splitting techniques, speficially: [`strings.SplitN`](https://pkg.go.dev/strings#SplitN) and [`strings.SplitSeq`](https://pkg.go.dev/strings#SplitSeq) where appropriate. There was also a [`strings.Fields`](https://pkg.go.dev/strings#Fields) change I made to use [`strings.FieldsSeq`](https://pkg.go.dev/strings#FieldsSeq) instead, and another for S3 to use the [`path`](https://pkg.go.dev/path) package instead of [`strings.Split`](https://pkg.go.dev/strings#Split). ## Why? [`strings.SplitN`](https://pkg.go.dev/strings#SplitN) and [`strings.SplitSeq`](https://pkg.go.dev/strings#SplitSeq) are often better options in many cases, and can be _partially_ detected using [`modernize`](https://pkg.go.dev/golang.org/x/tools/gopls/internal/analysis/modernize): > `stringsseq`: replace Split in "for range strings.Split(...)" by go1.24's more efficient `SplitSeq`, or `Fields` with `FieldSeq`. ## How did you test it? - [X] built - [X] run locally and tested manually - [x] covered by existing tests - [x] added new unit test(s) - [ ] added new functional test(s) ## Potential risks There are lots of potentially subtle behaviors from the `strings.Split` (and `strings.Fields`) usage that should be accounted for. If our existing tests don't cover those subtleties, there's risk for introducing an unintended bug. More intricate handling/parsing previously using the `strings` package should get extra attention from reviewers. I've attempted to break up my changes into logical commit chunks to aid in review / help spot potentially concerning changes.
34 lines
1.0 KiB
Go
34 lines
1.0 KiB
Go
package codegen
|
|
|
|
import "testing"
|
|
|
|
func TestSnakeCaseToPascalCase(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
in string
|
|
want string
|
|
}{
|
|
{name: "empty", in: "", want: ""},
|
|
{name: "single_lower", in: "a", want: "A"},
|
|
{name: "single_upper", in: "A", want: "A"},
|
|
{name: "simple", in: "hello", want: "Hello"},
|
|
{name: "two_words", in: "hello_world", want: "HelloWorld"},
|
|
{name: "all_caps", in: "HELLO_WORLD", want: "HelloWorld"},
|
|
{name: "leading_underscore", in: "_leading", want: "Leading"},
|
|
{name: "trailing_underscore", in: "trailing_", want: "Trailing"},
|
|
{name: "double_underscore", in: "a__b", want: "AB"},
|
|
{name: "only_underscores", in: "__", want: ""},
|
|
{name: "common_id", in: "user_id", want: "UserId"},
|
|
{name: "with_digits", in: "http_server_v2", want: "HttpServerV2"},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
got := SnakeCaseToPascalCase(tt.in)
|
|
if got != tt.want {
|
|
t.Fatalf("SnakeCaseToPascalCase(%q) = %q, want %q", tt.in, got, tt.want)
|
|
}
|
|
})
|
|
}
|
|
}
|