Files
tasks/common/authorization/default_jwt_claim_mapper.go
Kent GruberandGitHub eadf754dc8 Use better string splitting techniques where possible (#8226)
## What changed?

This PR aims to avoid usage of
[`strings.Split`](https://pkg.go.dev/strings#Split) where possible in
favor of better string splitting techniques, speficially:
[`strings.SplitN`](https://pkg.go.dev/strings#SplitN) and
[`strings.SplitSeq`](https://pkg.go.dev/strings#SplitSeq) where
appropriate.

There was also a [`strings.Fields`](https://pkg.go.dev/strings#Fields)
change I made to use
[`strings.FieldsSeq`](https://pkg.go.dev/strings#FieldsSeq) instead, and
another for S3 to use the [`path`](https://pkg.go.dev/path) package
instead of [`strings.Split`](https://pkg.go.dev/strings#Split).

## Why?

[`strings.SplitN`](https://pkg.go.dev/strings#SplitN) and
[`strings.SplitSeq`](https://pkg.go.dev/strings#SplitSeq) are often
better options in many cases, and can be _partially_ detected using
[`modernize`](https://pkg.go.dev/golang.org/x/tools/gopls/internal/analysis/modernize):
> `stringsseq`: replace Split in "for range strings.Split(...)" by
go1.24's more efficient `SplitSeq`, or `Fields` with `FieldSeq`.

## How did you test it?
- [X] built
- [X] run locally and tested manually
- [x] covered by existing tests
- [x] added new unit test(s)
- [ ] added new functional test(s)

## Potential risks

There are lots of potentially subtle behaviors from the `strings.Split`
(and `strings.Fields`) usage that should be accounted for. If our
existing tests don't cover those subtleties, there's risk for
introducing an unintended bug. More intricate handling/parsing
previously using the `strings` package should get extra attention from
reviewers. I've attempted to break up my changes into logical commit
chunks to aid in review / help spot potentially concerning changes.
2025-08-26 13:23:40 -04:00

216 lines
6.2 KiB
Go

package authorization
import (
"context"
"fmt"
"regexp"
"strings"
"github.com/golang-jwt/jwt/v4"
"go.temporal.io/api/serviceerror"
"go.temporal.io/server/common/config"
"go.temporal.io/server/common/log"
"go.temporal.io/server/common/primitives"
)
const (
defaultPermissionsClaimName = "permissions"
authorizationBearer = "bearer"
headerSubject = "sub"
permissionScopeSystem = primitives.SystemLocalNamespace
permissionRead = "read"
permissionWrite = "write"
permissionWorker = "worker"
permissionAdmin = "admin"
)
// Default claim mapper that gives system level admin permission to everybody
type defaultJWTClaimMapper struct {
keyProvider TokenKeyProvider
logger log.Logger
permissionsClaimName string
permissionsRegex *regexp.Regexp
matchNamespaceIndex int
matchRoleIndex int
}
func NewDefaultJWTClaimMapper(provider TokenKeyProvider, cfg *config.Authorization, logger log.Logger) ClaimMapper {
claimName := cfg.PermissionsClaimName
if claimName == "" {
claimName = defaultPermissionsClaimName
}
var permissionsRegex *regexp.Regexp
var namespaceIndex, roleIndex int
if cfg.PermissionsRegex != "" {
r, err := regexp.Compile(cfg.PermissionsRegex)
if err == nil {
for i, name := range r.SubexpNames() {
switch name {
case "namespace":
namespaceIndex = i
case "role":
roleIndex = i
}
}
if namespaceIndex != 0 && roleIndex != 0 {
permissionsRegex = r
} else {
logger.Warn("permissions regex does not have namespace or role named group")
}
} else {
logger.Warn(fmt.Sprintf("failed to compile permissions regex '%s': %v", cfg.PermissionsRegex, err))
}
}
return &defaultJWTClaimMapper{
keyProvider: provider,
logger: logger,
permissionsClaimName: claimName,
permissionsRegex: permissionsRegex,
matchNamespaceIndex: namespaceIndex,
matchRoleIndex: roleIndex,
}
}
var _ ClaimMapper = (*defaultJWTClaimMapper)(nil)
func (a *defaultJWTClaimMapper) GetClaims(authInfo *AuthInfo) (*Claims, error) {
claims := Claims{}
if authInfo.AuthToken == "" {
return &claims, nil
}
// We use strings.SplitN even though we check the length later, to avoid
// unnecessary allocations if the format is correct.
parts := strings.SplitN(authInfo.AuthToken, " ", 2)
if len(parts) != 2 {
return nil, serviceerror.NewPermissionDenied("unexpected authorization token format", "")
}
if !strings.EqualFold(parts[0], authorizationBearer) {
return nil, serviceerror.NewPermissionDenied("unexpected name in authorization token", "")
}
jwtClaims, err := parseJWTWithAudience(parts[1], a.keyProvider, authInfo.Audience)
if err != nil {
return nil, err
}
subject, ok := jwtClaims[headerSubject].(string)
if !ok {
return nil, serviceerror.NewPermissionDenied("unexpected value type of \"sub\" claim", "")
}
claims.Subject = subject
permissions, ok := jwtClaims[a.permissionsClaimName].([]interface{})
if ok {
err := a.extractPermissions(permissions, &claims)
if err != nil {
return nil, err
}
}
return &claims, nil
}
func (a *defaultJWTClaimMapper) extractPermissions(permissions []interface{}, claims *Claims) error {
for _, permission := range permissions {
p, ok := permission.(string)
if !ok {
a.logger.Warn(fmt.Sprintf("ignoring permission that is not a string: %v", permission))
continue
}
var parts []string
if a.permissionsRegex != nil {
match := a.permissionsRegex.FindStringSubmatch(p)
if len(match) == 0 {
a.logger.Warn(fmt.Sprintf("ignoring permission not matching pattern: %v", permission))
continue
}
parts = []string{match[a.matchNamespaceIndex], match[a.matchRoleIndex]}
} else {
parts = strings.SplitN(p, ":", 2)
if len(parts) != 2 {
a.logger.Warn(fmt.Sprintf("ignoring permission in unexpected format: %v", permission))
continue
}
}
namespace := parts[0]
if namespace == permissionScopeSystem {
claims.System |= permissionToRole(parts[1])
} else {
if claims.Namespaces == nil {
claims.Namespaces = make(map[string]Role)
}
role := claims.Namespaces[namespace]
role |= permissionToRole(parts[1])
claims.Namespaces[namespace] = role
}
}
return nil
}
func parseJWT(tokenString string, keyProvider TokenKeyProvider) (jwt.MapClaims, error) {
return parseJWTWithAudience(tokenString, keyProvider, "")
}
func parseJWTWithAudience(tokenString string, keyProvider TokenKeyProvider, audience string) (jwt.MapClaims, error) {
parser := jwt.NewParser(jwt.WithValidMethods(keyProvider.SupportedMethods()))
var keyFunc jwt.Keyfunc
if provider, _ := keyProvider.(RawTokenKeyProvider); provider != nil {
keyFunc = func(token *jwt.Token) (interface{}, error) {
// reserve context
// impl may introduce network request to get public key
return provider.GetKey(context.Background(), token)
}
} else {
keyFunc = func(token *jwt.Token) (interface{}, error) {
kid, ok := token.Header["kid"].(string)
if !ok {
return nil, fmt.Errorf("malformed token - no \"kid\" header")
}
alg := token.Header["alg"].(string)
switch token.Method.(type) {
case *jwt.SigningMethodHMAC:
return keyProvider.HmacKey(alg, kid)
case *jwt.SigningMethodRSA:
return keyProvider.RsaKey(alg, kid)
case *jwt.SigningMethodECDSA:
return keyProvider.EcdsaKey(alg, kid)
default:
return nil, serviceerror.NewPermissionDenied(
fmt.Sprintf("unexpected signing method: %v for algorithm: %v", token.Method, token.Header["alg"]), "")
}
}
}
token, err := parser.Parse(tokenString, keyFunc)
if err != nil {
return nil, err
}
claims, ok := token.Claims.(jwt.MapClaims)
if !ok {
return nil, serviceerror.NewPermissionDenied("invalid token with no claims", "")
}
if err := claims.Valid(); err != nil {
return nil, err
}
if strings.TrimSpace(audience) != "" && !claims.VerifyAudience(audience, true) {
return nil, serviceerror.NewPermissionDenied("audience mismatch", "")
}
return claims, nil
}
func permissionToRole(permission string) Role {
switch strings.ToLower(permission) {
case permissionRead:
return RoleReader
case permissionWrite:
return RoleWriter
case permissionAdmin:
return RoleAdmin
case permissionWorker:
return RoleWorker
}
return RoleUndefined
}