mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
David ReissandGitHub
2a38f9584b
## What changed? - Split implementation of "constrained default" settings from "plain default" settings. This is more code and the diff looks complex, but the individual paths are both simpler than the mixed version. - Add conversion cache using a weak map. - Remove GlobalCachedTypedValue. - Use "raw" values for subscription dispatch deduping to avoid unnecessary conversions. - Deep copy default values when using mapstructure, to avoid problems with merging over shared default values. ## Why? - Fixes #6756 - Performance improvement for "plain default" settings (almost all of them) - Performance improvement for settings with complex converters - Remove footgun in defaults that aren't scalar values ## How did you test it? existing+new unit tests
125 lines
3.7 KiB
Go
125 lines
3.7 KiB
Go
package dynamicconfig_test
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"go.temporal.io/server/common/dynamicconfig"
|
|
"go.temporal.io/server/common/log"
|
|
)
|
|
|
|
func BenchmarkCollection(b *testing.B) {
|
|
client1 := dynamicconfig.StaticClient{
|
|
dynamicconfig.MatchingMaxTaskBatchSize.Key(): []dynamicconfig.ConstrainedValue{{Value: 12}},
|
|
dynamicconfig.HistoryRPS.Key(): []dynamicconfig.ConstrainedValue{{Value: 100}},
|
|
dynamicconfig.BlobSizeLimitError.Key(): []dynamicconfig.ConstrainedValue{{Value: 100}},
|
|
dynamicconfig.BlobSizeLimitWarn.Key(): []dynamicconfig.ConstrainedValue{{Value: 100}},
|
|
dynamicconfig.MatchingShutdownDrainDuration.Key(): []dynamicconfig.ConstrainedValue{{Value: "100s"}},
|
|
}
|
|
cln1 := dynamicconfig.NewCollection(client1, log.NewNoopLogger())
|
|
b.Run("global int default", func(b *testing.B) {
|
|
b.ReportAllocs()
|
|
size := dynamicconfig.MatchingThrottledLogRPS.Get(cln1)
|
|
for i := 0; i < b.N/2; i++ {
|
|
_ = size()
|
|
_ = size()
|
|
}
|
|
})
|
|
b.Run("global int present", func(b *testing.B) {
|
|
b.ReportAllocs()
|
|
size := dynamicconfig.HistoryRPS.Get(cln1)
|
|
for i := 0; i < b.N/2; i++ {
|
|
_ = size()
|
|
_ = size()
|
|
}
|
|
})
|
|
b.Run("namespace int default", func(b *testing.B) {
|
|
b.ReportAllocs()
|
|
size1 := dynamicconfig.HistoryMaxPageSize.Get(cln1)
|
|
size2 := dynamicconfig.WorkflowExecutionMaxInFlightUpdates.Get(cln1)
|
|
for i := 0; i < b.N/2; i++ {
|
|
_ = size1("my-namespace")
|
|
_ = size2("my-namespace")
|
|
}
|
|
})
|
|
b.Run("namespace int present", func(b *testing.B) {
|
|
b.ReportAllocs()
|
|
size1 := dynamicconfig.BlobSizeLimitError.Get(cln1)
|
|
size2 := dynamicconfig.BlobSizeLimitWarn.Get(cln1)
|
|
for i := 0; i < b.N/2; i++ {
|
|
_ = size1("my-namespace")
|
|
_ = size2("my-namespace")
|
|
}
|
|
})
|
|
b.Run("taskqueue int default", func(b *testing.B) {
|
|
b.ReportAllocs()
|
|
size := dynamicconfig.MatchingMaxTaskDeleteBatchSize.Get(cln1)
|
|
for i := 0; i < b.N/2; i++ {
|
|
_ = size("my-namespace", "my-task-queue", 1)
|
|
_ = size("my-namespace", "my-task-queue", 1)
|
|
}
|
|
})
|
|
b.Run("taskqueue int present", func(b *testing.B) {
|
|
b.ReportAllocs()
|
|
size := dynamicconfig.MatchingMaxTaskBatchSize.Get(cln1)
|
|
for i := 0; i < b.N/2; i++ {
|
|
_ = size("my-namespace", "my-task-queue", 1)
|
|
_ = size("my-namespace", "my-task-queue", 1)
|
|
}
|
|
})
|
|
b.Run("global duration default", func(b *testing.B) {
|
|
b.ReportAllocs()
|
|
size := dynamicconfig.MatchingAlignMembershipChange.Get(cln1)
|
|
for i := 0; i < b.N/2; i++ {
|
|
_ = size()
|
|
_ = size()
|
|
}
|
|
})
|
|
b.Run("global duration present", func(b *testing.B) {
|
|
b.ReportAllocs()
|
|
size := dynamicconfig.MatchingShutdownDrainDuration.Get(cln1)
|
|
for i := 0; i < b.N/2; i++ {
|
|
_ = size()
|
|
_ = size()
|
|
}
|
|
})
|
|
|
|
// client with more constrained values
|
|
client2 := dynamicconfig.StaticClient{
|
|
dynamicconfig.MatchingMaxTaskBatchSize.Key(): []dynamicconfig.ConstrainedValue{
|
|
{
|
|
Constraints: dynamicconfig.Constraints{
|
|
TaskQueueName: "other-tq",
|
|
},
|
|
Value: 18,
|
|
},
|
|
{
|
|
Constraints: dynamicconfig.Constraints{
|
|
Namespace: "other-ns",
|
|
},
|
|
Value: 15,
|
|
},
|
|
},
|
|
}
|
|
cln2 := dynamicconfig.NewCollection(client2, log.NewNoopLogger())
|
|
b.Run("single default", func(b *testing.B) {
|
|
b.ReportAllocs()
|
|
size := dynamicconfig.MatchingMaxTaskBatchSize.Get(cln2)
|
|
for i := 0; i < b.N/4; i++ {
|
|
_ = size("my-namespace", "my-task-queue", 1)
|
|
_ = size("my-namespace", "other-tq", 1)
|
|
_ = size("other-ns", "my-task-queue", 1)
|
|
_ = size("other-ns", "other-tq", 1)
|
|
}
|
|
})
|
|
b.Run("structured default", func(b *testing.B) {
|
|
b.ReportAllocs()
|
|
size := dynamicconfig.MatchingNumTaskqueueWritePartitions.Get(cln2)
|
|
for i := 0; i < b.N/4; i++ {
|
|
_ = size("my-namespace", "my-task-queue", 1)
|
|
_ = size("my-namespace", "other-tq", 1)
|
|
_ = size("other-ns", "my-task-queue", 1)
|
|
_ = size("other-ns", "other-tq", 1)
|
|
}
|
|
})
|
|
}
|