Files
tasks/common/nexus/trace.go
David ReissandGitHub 2a38f9584b Dynamic config conversion improvements (#7052)
## What changed?
- Split implementation of "constrained default" settings from "plain
default" settings. This is more code and the diff looks complex, but the
individual paths are both simpler than the mixed version.
- Add conversion cache using a weak map.
- Remove GlobalCachedTypedValue.
- Use "raw" values for subscription dispatch deduping to avoid
unnecessary conversions.
- Deep copy default values when using mapstructure, to avoid problems
with merging over shared default values.

## Why?
- Fixes #6756
- Performance improvement for "plain default" settings (almost all of
them)
- Performance improvement for settings with complex converters
- Remove footgun in defaults that aren't scalar values

## How did you test it?
existing+new unit tests
2025-08-08 08:32:58 -07:00

181 lines
6.9 KiB
Go

package nexus
import (
"crypto/tls"
"net/http/httptrace"
"time"
"go.temporal.io/server/common/dynamicconfig"
"go.temporal.io/server/common/log"
"go.temporal.io/server/common/log/tag"
)
type HTTPClientTraceProvider interface {
// NewTrace returns a *httptrace.ClientTrace which provides hooks to invoke at each point in the HTTP request
// lifecycle. This trace must be added to the HTTP request context using httptrace.WithClientTrace for the hooks to
// be invoked. The provided logger should already be tagged with relevant request information
// e.g. using log.With(logger, tag.RequestID(id), tag.Operation(op), ...).
NewTrace(attempt int32, logger log.Logger) *httptrace.ClientTrace
// NewForwardingTrace functions the same as NewTrace but forwarded requests do not have an associated attempt count,
// so all forwarded requests will be traced if enabled.
NewForwardingTrace(logger log.Logger) *httptrace.ClientTrace
}
// HTTPTraceConfig is the dynamic config for controlling Nexus HTTP request tracing behavior.
var HTTPTraceConfig = dynamicconfig.NewGlobalTypedSettingWithConverter(
"system.nexusHTTPTraceConfig",
convertHTTPClientTraceConfig,
defaultHTTPClientTraceConfig,
`Configuration options for controlling additional tracing for Nexus HTTP requests. Fields: Enabled, ForwardingEnabled, MinAttempt, MaxAttempt, Hooks. See HTTPClientTraceConfig comments for more detail.`,
)
type HTTPClientTraceConfig struct {
// Enabled controls whether any additional tracing will be invoked. Default false.
Enabled bool
// ForwardingEnabled controls whether any additional tracing will be invoked for forwarded requests. Default false. Forwarded requests do not have an attempt count, so MinAttempt and MaxAttempt are ignored for these requests.
ForwardingEnabled bool
// MinAttempt is the first operation attempt to include additional tracing. Default 2. Setting to 0 or 1 will add tracing to all requests and may be expensive.
MinAttempt int32
// MaxAttempt is the maximum operation attempt to include additional tracing. Default 2. Setting to 0 means no maximum.
MaxAttempt int32
// Hooks is the list of method names to invoke with extra tracing. See httptrace.ClientTrace for more detail.
// Defaults to all implemented hooks: GetConn, GotConn, ConnectStart, ConnectDone, DNSStart, DNSDone, TLSHandshakeStart, TLSHandshakeDone, WroteRequest, GotFirstResponseByte.
Hooks []string
}
var defaultHTTPClientTraceConfig = HTTPClientTraceConfig{
Enabled: false,
ForwardingEnabled: false,
MinAttempt: 2,
MaxAttempt: 2,
// use separate default for Hooks so that users can override with a smaller set of hooks
Hooks: nil,
}
var convertDefaultHTTPClientTraceConfig = dynamicconfig.ConvertStructure(defaultHTTPClientTraceConfig)
var defaultHTTPClientTraceHooks = []string{"GetConn", "GotConn", "ConnectStart", "ConnectDone", "DNSStart", "DNSDone", "TLSHandshakeStart", "TLSHandshakeDone", "WroteRequest", "GotFirstResponseByte"}
func convertHTTPClientTraceConfig(in any) (HTTPClientTraceConfig, error) {
cfg, err := convertDefaultHTTPClientTraceConfig(in)
if err != nil {
cfg = defaultHTTPClientTraceConfig
}
if len(cfg.Hooks) == 0 {
cfg.Hooks = defaultHTTPClientTraceHooks
}
return cfg, nil
}
type LoggedHTTPClientTraceProvider struct {
Config dynamicconfig.TypedPropertyFn[HTTPClientTraceConfig]
}
func NewLoggedHTTPClientTraceProvider(dc *dynamicconfig.Collection) HTTPClientTraceProvider {
return &LoggedHTTPClientTraceProvider{
Config: HTTPTraceConfig.Get(dc),
}
}
func (p *LoggedHTTPClientTraceProvider) NewTrace(attempt int32, logger log.Logger) *httptrace.ClientTrace {
config := p.Config()
if !config.Enabled {
return nil
}
if attempt < config.MinAttempt {
return nil
}
if config.MaxAttempt > 0 && attempt > config.MaxAttempt {
return nil
}
return p.newClientTrace(logger, config.Hooks)
}
func (p *LoggedHTTPClientTraceProvider) NewForwardingTrace(logger log.Logger) *httptrace.ClientTrace {
config := p.Config()
if !config.Enabled || !config.ForwardingEnabled {
return nil
}
return p.newClientTrace(logger, config.Hooks)
}
//nolint:revive // cognitive complexity (> 25 max) but is just adding a logging function for each method in the list.
func (p *LoggedHTTPClientTraceProvider) newClientTrace(logger log.Logger, hooks []string) *httptrace.ClientTrace {
clientTrace := &httptrace.ClientTrace{}
for _, h := range hooks {
switch h {
case "GetConn":
clientTrace.GetConn = func(hostPort string) {
logger.Info("attempting to get HTTP connection for Nexus request",
tag.Timestamp(time.Now().UTC()),
tag.Address(hostPort))
}
case "GotConn":
clientTrace.GotConn = func(info httptrace.GotConnInfo) {
logger.Info("got HTTP connection for Nexus request",
tag.Timestamp(time.Now().UTC()),
tag.NewBoolTag("reused", info.Reused),
tag.NewBoolTag("was-idle", info.WasIdle),
tag.NewDurationTag("idle-time", info.IdleTime))
}
case "ConnectStart":
clientTrace.ConnectStart = func(network, addr string) {
logger.Info("starting dial for new connection for Nexus request",
tag.Timestamp(time.Now().UTC()),
tag.Address(addr),
tag.NewStringTag("network", network))
}
case "ConnectDone":
clientTrace.ConnectDone = func(network, addr string, err error) {
logger.Info("finished dial for new connection for Nexus request",
tag.Timestamp(time.Now().UTC()),
tag.Address(addr),
tag.NewStringTag("network", network),
tag.Error(err))
}
case "DNSStart":
clientTrace.DNSStart = func(info httptrace.DNSStartInfo) {
logger.Info("starting DNS lookup for Nexus request",
tag.Timestamp(time.Now().UTC()),
tag.Host(info.Host))
}
case "DNSDone":
clientTrace.DNSDone = func(info httptrace.DNSDoneInfo) {
addresses := make([]string, len(info.Addrs))
for i, a := range info.Addrs {
addresses[i] = a.String()
}
logger.Info("finished DNS lookup for Nexus request",
tag.Timestamp(time.Now().UTC()),
tag.Addresses(addresses),
tag.Error(info.Err),
tag.NewBoolTag("coalesced", info.Coalesced))
}
case "TLSHandshakeStart":
clientTrace.TLSHandshakeStart = func() {
logger.Info("starting TLS handshake for Nexus request", tag.Timestamp(time.Now().UTC()))
}
case "TLSHandshakeDone":
clientTrace.TLSHandshakeDone = func(state tls.ConnectionState, err error) {
logger.Info("finished TLS handshake for Nexus request",
tag.Timestamp(time.Now().UTC()),
tag.NewBoolTag("handshake-complete", state.HandshakeComplete),
tag.Error(err))
}
case "WroteRequest":
clientTrace.WroteRequest = func(info httptrace.WroteRequestInfo) {
logger.Info("finished writing Nexus HTTP request",
tag.Timestamp(time.Now().UTC()),
tag.Error(info.Err))
}
case "GotFirstResponseByte":
clientTrace.GotFirstResponseByte = func() {
logger.Info("got response to Nexus HTTP request", tag.AttemptEnd(time.Now().UTC()))
}
}
}
return clientTrace
}