Files
tasks/common/persistence/workflow_state_status_validator.go
Alex ShtinandGitHub 846d88c8cb Refactor: use new serviceerror.New...f constructors (#7785)
## What changed?
Refactor: use new `serviceerror.New...f` constructors.

## Why?
Most of service errors now supports `fmt.Sprintf` format and they should
be used instead of `fmt.Sprintf`.

## How did you test it?
- [ ] built
- [ ] run locally and tested manually
- [x] covered by existing tests
- [ ] added new unit test(s)
- [ ] added new functional test(s)
2025-05-17 00:21:32 +00:00

94 lines
2.9 KiB
Go

package persistence
import (
enumspb "go.temporal.io/api/enums/v1"
"go.temporal.io/api/serviceerror"
enumsspb "go.temporal.io/server/api/enums/v1"
)
var (
validWorkflowStates = map[enumsspb.WorkflowExecutionState]struct{}{
enumsspb.WORKFLOW_EXECUTION_STATE_CREATED: {},
enumsspb.WORKFLOW_EXECUTION_STATE_RUNNING: {},
enumsspb.WORKFLOW_EXECUTION_STATE_COMPLETED: {},
enumsspb.WORKFLOW_EXECUTION_STATE_ZOMBIE: {},
enumsspb.WORKFLOW_EXECUTION_STATE_CORRUPTED: {},
}
validWorkflowStatuses = map[enumspb.WorkflowExecutionStatus]struct{}{
enumspb.WORKFLOW_EXECUTION_STATUS_RUNNING: {},
enumspb.WORKFLOW_EXECUTION_STATUS_COMPLETED: {},
enumspb.WORKFLOW_EXECUTION_STATUS_FAILED: {},
enumspb.WORKFLOW_EXECUTION_STATUS_CANCELED: {},
enumspb.WORKFLOW_EXECUTION_STATUS_TERMINATED: {},
enumspb.WORKFLOW_EXECUTION_STATUS_CONTINUED_AS_NEW: {},
enumspb.WORKFLOW_EXECUTION_STATUS_TIMED_OUT: {},
}
)
// ValidateCreateWorkflowStateStatus validate workflow state and close status
func ValidateCreateWorkflowStateStatus(
state enumsspb.WorkflowExecutionState,
status enumspb.WorkflowExecutionStatus,
) error {
if err := validateWorkflowState(state); err != nil {
return err
}
if err := validateWorkflowStatus(status); err != nil {
return err
}
// validate workflow state & status
if (state == enumsspb.WORKFLOW_EXECUTION_STATE_COMPLETED && status == enumspb.WORKFLOW_EXECUTION_STATUS_RUNNING) ||
(state != enumsspb.WORKFLOW_EXECUTION_STATE_COMPLETED && status != enumspb.WORKFLOW_EXECUTION_STATUS_RUNNING) {
return serviceerror.NewInternalf("Create workflow with invalid state: %v or status: %v", state, status)
}
return nil
}
// ValidateUpdateWorkflowStateStatus validate workflow state and status
func ValidateUpdateWorkflowStateStatus(
state enumsspb.WorkflowExecutionState,
status enumspb.WorkflowExecutionStatus,
) error {
if err := validateWorkflowState(state); err != nil {
return err
}
if err := validateWorkflowStatus(status); err != nil {
return err
}
// validate workflow state & status
if (state == enumsspb.WORKFLOW_EXECUTION_STATE_COMPLETED && status == enumspb.WORKFLOW_EXECUTION_STATUS_RUNNING) ||
(state != enumsspb.WORKFLOW_EXECUTION_STATE_COMPLETED && status != enumspb.WORKFLOW_EXECUTION_STATUS_RUNNING) {
return serviceerror.NewInternalf("Update workflow with invalid state: %v or status: %v", state, status)
}
return nil
}
// validateWorkflowState validate workflow state
func validateWorkflowState(
state enumsspb.WorkflowExecutionState,
) error {
if _, ok := validWorkflowStates[state]; !ok {
return serviceerror.NewInternalf("Invalid workflow state: %v", state)
}
return nil
}
// validateWorkflowStatus validate workflow status
func validateWorkflowStatus(
status enumspb.WorkflowExecutionStatus,
) error {
if _, ok := validWorkflowStatuses[status]; !ok {
return serviceerror.NewInternalf("Invalid workflow status: %v", status)
}
return nil
}