mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
Tim Deeb-SwihartandGitHub
8f987baf17
## What changed? This changes all methods that fail tests on the test logger to **forcibly** fail it by calling `t.Fatalf`. It adds the stack trace to the failure message as we'd otherwise have no information on the _path_ to the failure, which is why we initially used `panic` ## Why? While testing a separate project I determined that panics from OSS' test logger (and the internal one it is based on!) were being caught by our application code, obscuring issues that should cause tests to fail. ## How did you test it? - [ ] built - [ ] run locally and tested manually - [x] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s) ## Potential risks This may fail more tests than we currently do. This is a Good Thing.