mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
Kent GruberandGitHub
eadf754dc8
## What changed? This PR aims to avoid usage of [`strings.Split`](https://pkg.go.dev/strings#Split) where possible in favor of better string splitting techniques, speficially: [`strings.SplitN`](https://pkg.go.dev/strings#SplitN) and [`strings.SplitSeq`](https://pkg.go.dev/strings#SplitSeq) where appropriate. There was also a [`strings.Fields`](https://pkg.go.dev/strings#Fields) change I made to use [`strings.FieldsSeq`](https://pkg.go.dev/strings#FieldsSeq) instead, and another for S3 to use the [`path`](https://pkg.go.dev/path) package instead of [`strings.Split`](https://pkg.go.dev/strings#Split). ## Why? [`strings.SplitN`](https://pkg.go.dev/strings#SplitN) and [`strings.SplitSeq`](https://pkg.go.dev/strings#SplitSeq) are often better options in many cases, and can be _partially_ detected using [`modernize`](https://pkg.go.dev/golang.org/x/tools/gopls/internal/analysis/modernize): > `stringsseq`: replace Split in "for range strings.Split(...)" by go1.24's more efficient `SplitSeq`, or `Fields` with `FieldSeq`. ## How did you test it? - [X] built - [X] run locally and tested manually - [x] covered by existing tests - [x] added new unit test(s) - [ ] added new functional test(s) ## Potential risks There are lots of potentially subtle behaviors from the `strings.Split` (and `strings.Fields`) usage that should be accounted for. If our existing tests don't cover those subtleties, there's risk for introducing an unintended bug. More intricate handling/parsing previously using the `strings` package should get extra attention from reviewers. I've attempted to break up my changes into logical commit chunks to aid in review / help spot potentially concerning changes.
42 lines
1.1 KiB
Go
42 lines
1.1 KiB
Go
package util
|
|
|
|
import (
|
|
"errors"
|
|
"regexp"
|
|
"strings"
|
|
)
|
|
|
|
// WildCardStringToRegexp converts a given string pattern to a regular expression matching wildcards (*) with any
|
|
// substring.
|
|
func WildCardStringToRegexp(pattern string) (*regexp.Regexp, error) {
|
|
if pattern == "" {
|
|
return nil, errors.New("pattern cannot be empty")
|
|
}
|
|
return WildCardStringsToRegexp([]string{pattern})
|
|
}
|
|
|
|
// WildCardStringToRegexps converts a given slices of string patterns to a slice of regular expressions matching
|
|
// wildcards (*) with any substring.
|
|
func WildCardStringsToRegexp(patterns []string) (*regexp.Regexp, error) {
|
|
var result strings.Builder
|
|
result.WriteRune('^')
|
|
for i, pattern := range patterns {
|
|
result.WriteRune('(')
|
|
first := true
|
|
for literal := range strings.SplitSeq(pattern, "*") {
|
|
if !first {
|
|
// Replace * with .*
|
|
result.WriteString(".*")
|
|
}
|
|
result.WriteString(regexp.QuoteMeta(literal))
|
|
first = false
|
|
}
|
|
result.WriteRune(')')
|
|
if i < len(patterns)-1 {
|
|
result.WriteRune('|')
|
|
}
|
|
}
|
|
result.WriteRune('$')
|
|
return regexp.Compile(result.String())
|
|
}
|