Files
tasks/service/history/ndc/conflict_resolver_test.go
Alex ShtinandGitHub 8e8f1b0f7c Remove license header from every file (#7689)
## What changed?
<!-- Describe what has changed in this PR -->
Remove license header from every file. Because it is really hard to
follow in this PR here is the summary:
1. License header is removed from all `.go` and `.proto` files
:fireworks::fireworks:🎆.
2. `LICENSE` file in the root directory has only Temporal and Uber
copyrights.
3. 5 other `LICENSE` files added to the packages which have copyrights
different from Temporal and Uber: Datadog, Xargin, "Mat Ryer, Tyler
Bunnell and contributors".
4. `license_file` flag is removed from all code generation tools.
5. `copyright_file` flag is removed from `go:generate mockgen`
directive.
6. All copyright related targets are removed from `Makefile`.
7. Updated Temporal copyright year to 2025 everywhere.

## Why?
<!-- Tell your future self why have you made these changes -->
I double checked with legal department that it is not needed to have
license header in every file. One file per repo is enough. I put all
copyrights to the root `LICENSE` file and removed header from all other
files. Also updated tools and `Makefile`.
2025-05-01 18:50:21 -07:00

380 lines
13 KiB
Go

package ndc
import (
"context"
"math/rand"
"testing"
"github.com/pborman/uuid"
"github.com/stretchr/testify/require"
"github.com/stretchr/testify/suite"
historyspb "go.temporal.io/server/api/history/v1"
persistencespb "go.temporal.io/server/api/persistence/v1"
"go.temporal.io/server/common/definition"
"go.temporal.io/server/common/log"
"go.temporal.io/server/common/persistence/versionhistory"
"go.temporal.io/server/common/util"
historyi "go.temporal.io/server/service/history/interfaces"
"go.temporal.io/server/service/history/shard"
"go.temporal.io/server/service/history/tests"
"go.uber.org/mock/gomock"
)
type (
conflictResolverSuite struct {
suite.Suite
*require.Assertions
controller *gomock.Controller
mockShard *shard.ContextTest
mockContext *historyi.MockWorkflowContext
mockMutableState *historyi.MockMutableState
mockStateBuilder *MockStateRebuilder
logger log.Logger
namespaceID string
namespace string
workflowID string
runID string
nDCConflictResolver *ConflictResolverImpl
}
)
func TestNDCConflictResolverSuite(t *testing.T) {
s := new(conflictResolverSuite)
suite.Run(t, s)
}
func (s *conflictResolverSuite) SetupTest() {
s.Assertions = require.New(s.T())
s.controller = gomock.NewController(s.T())
s.mockContext = historyi.NewMockWorkflowContext(s.controller)
s.mockMutableState = historyi.NewMockMutableState(s.controller)
s.mockStateBuilder = NewMockStateRebuilder(s.controller)
s.mockShard = shard.NewTestContext(
s.controller,
&persistencespb.ShardInfo{
ShardId: 10,
RangeId: 1,
},
tests.NewDynamicConfig(),
)
s.logger = s.mockShard.GetLogger()
s.namespaceID = uuid.New()
s.namespace = "some random namespace name"
s.workflowID = "some random workflow ID"
s.runID = uuid.New()
s.nDCConflictResolver = NewConflictResolver(
s.mockShard, s.mockContext, s.mockMutableState, s.logger,
)
s.nDCConflictResolver.stateRebuilder = s.mockStateBuilder
}
func (s *conflictResolverSuite) TearDownTest() {
s.controller.Finish()
s.mockShard.StopForTest()
}
func (s *conflictResolverSuite) TestRebuild() {
ctx := context.Background()
updateCondition := int64(59)
dbVersion := int64(1444)
requestID := uuid.New()
version := int64(12)
historySize := int64(12345)
branchToken0 := []byte("some random branch token")
lastEventID0 := int64(5)
versionHistory0 := versionhistory.NewVersionHistory(
branchToken0,
[]*historyspb.VersionHistoryItem{versionhistory.NewVersionHistoryItem(lastEventID0, version)},
)
branchToken1 := []byte("other random branch token")
lastEventID1 := int64(2)
versionHistory1 := versionhistory.NewVersionHistory(
branchToken1,
[]*historyspb.VersionHistoryItem{versionhistory.NewVersionHistoryItem(lastEventID1, version)},
)
versionHistories := versionhistory.NewVersionHistories(versionHistory0)
_, _, err := versionhistory.AddAndSwitchVersionHistory(versionHistories, versionHistory1)
s.NoError(err)
s.mockMutableState.EXPECT().GetUpdateCondition().Return(updateCondition, dbVersion).AnyTimes()
s.mockMutableState.EXPECT().GetExecutionInfo().Return(&persistencespb.WorkflowExecutionInfo{
NamespaceId: s.namespaceID,
WorkflowId: s.workflowID,
VersionHistories: versionHistories,
}).AnyTimes()
s.mockMutableState.EXPECT().GetExecutionState().Return(&persistencespb.WorkflowExecutionState{
RunId: s.runID,
}).AnyTimes()
s.mockMutableState.EXPECT().GetHistorySize().Return(historySize).AnyTimes()
workflowKey := definition.NewWorkflowKey(
s.namespaceID,
s.workflowID,
s.runID,
)
mockRebuildMutableState := historyi.NewMockMutableState(s.controller)
mockRebuildMutableState.EXPECT().GetExecutionInfo().Return(
&persistencespb.WorkflowExecutionInfo{
VersionHistories: versionhistory.NewVersionHistories(
versionhistory.NewVersionHistory(
branchToken1,
[]*historyspb.VersionHistoryItem{versionhistory.NewVersionHistoryItem(lastEventID1, version)},
),
),
},
).AnyTimes()
mockRebuildMutableState.EXPECT().AddHistorySize(historySize)
mockRebuildMutableState.EXPECT().SetUpdateCondition(updateCondition, dbVersion)
s.mockStateBuilder.EXPECT().Rebuild(
ctx,
gomock.Any(),
workflowKey,
branchToken1,
lastEventID1,
util.Ptr(version),
workflowKey,
branchToken1,
requestID,
).Return(mockRebuildMutableState, rand.Int63(), nil)
s.mockContext.EXPECT().Clear()
rebuiltMutableState, err := s.nDCConflictResolver.rebuild(ctx, 1, requestID)
s.NoError(err)
s.NotNil(rebuiltMutableState)
s.Equal(int32(1), versionHistories.GetCurrentVersionHistoryIndex())
}
func (s *conflictResolverSuite) TestGetOrRebuildCurrentMutableState_NoRebuild_NotCurrent() {
branchToken0 := []byte("some random branch token")
lastEventID0 := int64(2)
version0 := int64(12)
versionHistoryItem0 := versionhistory.NewVersionHistoryItem(lastEventID0, version0)
versionHistory0 := versionhistory.NewVersionHistory(
branchToken0,
[]*historyspb.VersionHistoryItem{versionHistoryItem0},
)
branchToken1 := []byte("another random branch token")
lastEventID1 := lastEventID0 + 1
version1 := version0 + 1
versionHistoryItem1 := versionhistory.NewVersionHistoryItem(lastEventID1, version1)
versionHistory1 := versionhistory.NewVersionHistory(
branchToken1,
[]*historyspb.VersionHistoryItem{versionHistoryItem0, versionHistoryItem1},
)
versionHistories := versionhistory.NewVersionHistories(versionHistory0)
_, _, err := versionhistory.AddAndSwitchVersionHistory(versionHistories, versionHistory1)
s.Nil(err)
s.mockMutableState.EXPECT().GetExecutionInfo().Return(&persistencespb.WorkflowExecutionInfo{VersionHistories: versionHistories}).AnyTimes()
rebuiltMutableState, isRebuilt, err := s.nDCConflictResolver.GetOrRebuildCurrentMutableState(context.Background(), 0, version0)
s.NoError(err)
s.False(isRebuilt)
s.Equal(s.mockMutableState, rebuiltMutableState)
}
func (s *conflictResolverSuite) TestGetOrRebuildCurrentMutableState_NoRebuild_SameIndex() {
branchToken := []byte("some random branch token")
lastEventID := int64(2)
version := int64(12)
versionHistoryItem := versionhistory.NewVersionHistoryItem(lastEventID, version)
versionHistory := versionhistory.NewVersionHistory(
branchToken,
[]*historyspb.VersionHistoryItem{versionHistoryItem},
)
versionHistories := versionhistory.NewVersionHistories(versionHistory)
s.mockMutableState.EXPECT().GetExecutionInfo().Return(&persistencespb.WorkflowExecutionInfo{VersionHistories: versionHistories}).AnyTimes()
rebuiltMutableState, isRebuilt, err := s.nDCConflictResolver.GetOrRebuildCurrentMutableState(context.Background(), 0, version)
s.NoError(err)
s.False(isRebuilt)
s.Equal(s.mockMutableState, rebuiltMutableState)
}
func (s *conflictResolverSuite) TestGetOrRebuildCurrentMutableState_Rebuild() {
ctx := context.Background()
updateCondition := int64(59)
dbVersion := int64(1444)
version := int64(12)
incomingVersion := version + 1
historySize := int64(12345)
// current branch
branchToken0 := []byte("some random branch token")
lastEventID0 := int64(2)
versionHistoryItem0 := versionhistory.NewVersionHistoryItem(lastEventID0, version)
versionHistory0 := versionhistory.NewVersionHistory(
branchToken0,
[]*historyspb.VersionHistoryItem{versionHistoryItem0},
)
// stale branch, used for Rebuild
branchToken1 := []byte("other random branch token")
lastEventID1 := lastEventID0 - 1
versionHistoryItem1 := versionhistory.NewVersionHistoryItem(lastEventID1, version)
versionHistory1 := versionhistory.NewVersionHistory(
branchToken1,
[]*historyspb.VersionHistoryItem{versionHistoryItem1},
)
versionHistories := versionhistory.NewVersionHistories(versionHistory0)
_, _, err := versionhistory.AddAndSwitchVersionHistory(versionHistories, versionHistory1)
s.Nil(err)
s.mockMutableState.EXPECT().GetUpdateCondition().Return(updateCondition, dbVersion).AnyTimes()
s.mockMutableState.EXPECT().GetExecutionInfo().Return(&persistencespb.WorkflowExecutionInfo{
NamespaceId: s.namespaceID,
WorkflowId: s.workflowID,
VersionHistories: versionHistories,
}).AnyTimes()
s.mockMutableState.EXPECT().GetExecutionState().Return(&persistencespb.WorkflowExecutionState{
RunId: s.runID,
}).AnyTimes()
s.mockMutableState.EXPECT().GetHistorySize().Return(historySize).AnyTimes()
workflowKey := definition.NewWorkflowKey(
s.namespaceID,
s.workflowID,
s.runID,
)
mockRebuildMutableState := historyi.NewMockMutableState(s.controller)
mockRebuildMutableState.EXPECT().GetExecutionInfo().Return(
&persistencespb.WorkflowExecutionInfo{
VersionHistories: versionhistory.NewVersionHistories(
versionhistory.NewVersionHistory(
branchToken1,
[]*historyspb.VersionHistoryItem{versionhistory.NewVersionHistoryItem(lastEventID1, version)},
),
),
},
).AnyTimes()
mockRebuildMutableState.EXPECT().AddHistorySize(historySize)
mockRebuildMutableState.EXPECT().SetUpdateCondition(updateCondition, dbVersion)
s.mockStateBuilder.EXPECT().Rebuild(
ctx,
gomock.Any(),
workflowKey,
branchToken1,
lastEventID1,
util.Ptr(version),
workflowKey,
branchToken1,
gomock.Any(),
).Return(mockRebuildMutableState, rand.Int63(), nil)
s.mockContext.EXPECT().Clear()
rebuiltMutableState, isRebuilt, err := s.nDCConflictResolver.GetOrRebuildCurrentMutableState(ctx, 1, incomingVersion)
s.NoError(err)
s.NotNil(rebuiltMutableState)
s.True(isRebuilt)
}
func (s *conflictResolverSuite) TestGetOrRebuildMutableState_NoRebuild_SameIndex() {
branchToken := []byte("some random branch token")
lastEventID := int64(2)
version := int64(12)
versionHistoryItem := versionhistory.NewVersionHistoryItem(lastEventID, version)
versionHistory := versionhistory.NewVersionHistory(
branchToken,
[]*historyspb.VersionHistoryItem{versionHistoryItem},
)
versionHistories := versionhistory.NewVersionHistories(versionHistory)
s.mockMutableState.EXPECT().GetExecutionInfo().Return(&persistencespb.WorkflowExecutionInfo{VersionHistories: versionHistories}).AnyTimes()
rebuiltMutableState, isRebuilt, err := s.nDCConflictResolver.GetOrRebuildMutableState(context.Background(), 0)
s.NoError(err)
s.False(isRebuilt)
s.Equal(s.mockMutableState, rebuiltMutableState)
}
func (s *conflictResolverSuite) TestGetOrRebuildMutableState_Rebuild() {
ctx := context.Background()
updateCondition := int64(59)
dbVersion := int64(1444)
version := int64(12)
historySize := int64(12345)
// current branch
branchToken0 := []byte("some random branch token")
lastEventID0 := int64(2)
versionHistoryItem0 := versionhistory.NewVersionHistoryItem(lastEventID0, version)
versionHistory0 := versionhistory.NewVersionHistory(
branchToken0,
[]*historyspb.VersionHistoryItem{versionHistoryItem0},
)
// stale branch, used for Rebuild
branchToken1 := []byte("other random branch token")
lastEventID1 := lastEventID0 - 1
versionHistoryItem1 := versionhistory.NewVersionHistoryItem(lastEventID1, version)
versionHistory1 := versionhistory.NewVersionHistory(
branchToken1,
[]*historyspb.VersionHistoryItem{versionHistoryItem1},
)
versionHistories := versionhistory.NewVersionHistories(versionHistory0)
_, _, err := versionhistory.AddAndSwitchVersionHistory(versionHistories, versionHistory1)
s.Nil(err)
s.mockMutableState.EXPECT().GetUpdateCondition().Return(updateCondition, dbVersion).AnyTimes()
s.mockMutableState.EXPECT().GetExecutionInfo().Return(&persistencespb.WorkflowExecutionInfo{
NamespaceId: s.namespaceID,
WorkflowId: s.workflowID,
VersionHistories: versionHistories,
}).AnyTimes()
s.mockMutableState.EXPECT().GetExecutionState().Return(&persistencespb.WorkflowExecutionState{
RunId: s.runID,
}).AnyTimes()
s.mockMutableState.EXPECT().GetHistorySize().Return(historySize).AnyTimes()
workflowKey := definition.NewWorkflowKey(
s.namespaceID,
s.workflowID,
s.runID,
)
mockRebuildMutableState := historyi.NewMockMutableState(s.controller)
mockRebuildMutableState.EXPECT().GetExecutionInfo().Return(
&persistencespb.WorkflowExecutionInfo{
VersionHistories: versionhistory.NewVersionHistories(
versionhistory.NewVersionHistory(
branchToken1,
[]*historyspb.VersionHistoryItem{versionhistory.NewVersionHistoryItem(lastEventID1, version)},
),
),
},
).AnyTimes()
mockRebuildMutableState.EXPECT().AddHistorySize(historySize)
mockRebuildMutableState.EXPECT().SetUpdateCondition(updateCondition, dbVersion)
s.mockStateBuilder.EXPECT().Rebuild(
ctx,
gomock.Any(),
workflowKey,
branchToken1,
lastEventID1,
util.Ptr(version),
workflowKey,
branchToken1,
gomock.Any(),
).Return(mockRebuildMutableState, rand.Int63(), nil)
s.mockContext.EXPECT().Clear()
rebuiltMutableState, isRebuilt, err := s.nDCConflictResolver.GetOrRebuildMutableState(ctx, 1)
s.NoError(err)
s.NotNil(rebuiltMutableState)
s.True(isRebuilt)
}