mirror of
https://github.com/hanzoai/tasks.git
synced 2026-11-02 12:22:18 +00:00
## What changed? Changes activity metrics ### Deprecated Metrics - **activity_e2e_latency** → Deprecated, as it measures individual attempts rather than true end-to-end latency, and replaced with clearer **activity_start_to_close_latency** ### New & Replacement Metrics - **activity_start_to_close_latency**: Measures the latency from activity start to close (per attempt). - **activity_schedule_to_close_latency**: Measures true end-to-end duration, including retries and backoff. - **activity_success**: Counts the number of succeeded activities. Aligned with the existing **workflow_success** counter. - **activity_fail**: Counts final failures for activities. Similar to **workflow_failed,** although it doesn’t include retries. - **activity_timeout**: Incremented on the final activity timeout (including ScheduleToStartTimeout), tagged by `timeout_type`. Aligned with the existing **workflow_timeout** counter. - **activity_task_fail**: Counts failures for activities including retries. Note that we don’t need to capture the number of retries, as this metric represents this number well. - **activity_task_timeout**: Incremented on the activity attempt timeout (including ScheduleToStartTimeout), tagged by `timeout_type`. - **activity_cancel:** Incremented when an activity is cancelled **** ## Why? ActivityE2ELatency is inaccurate, since it measures only individual attempts. The other metrics are not recorded yet. ## How did you test it? - [X] built - [X] run locally and tested manually - [X] covered by existing tests - [X] added new unit test(s) - [ ] added new functional test(s) Ran the server locally and checked the metrics in Prometheus: Test 1: Activity with 5 attempts (1s each, 1s gap, all time out) - activity_task_timeout = 5 - activity_timeout = 1 - activity_success = 0 - activity_fail = 0 (counted as timeout instead) - activity_task_fail = 0 (counted as timeout instead) - activity_schedule_to_close_latency_sum = 9s - activity_end_to_end_latency_sum = 1s (deprecated) - activity_start_to_close_latency_sum = 1s Test 2: Basic helloworld activity - activity_success = 1 Test 3: Activity with 5 attempts (1s each, 1s gap, all fail except for the last one) - activity_task_fail = 4 - activity_success = 1
208 lines
8.3 KiB
Go
208 lines
8.3 KiB
Go
package workflow
|
|
|
|
import (
|
|
"time"
|
|
|
|
enumspb "go.temporal.io/api/enums/v1"
|
|
enumsspb "go.temporal.io/server/api/enums/v1"
|
|
"go.temporal.io/server/common/metrics"
|
|
"go.temporal.io/server/common/namespace"
|
|
"go.temporal.io/server/common/persistence"
|
|
"go.temporal.io/server/common/tqid"
|
|
"go.temporal.io/server/service/history/configs"
|
|
historyi "go.temporal.io/server/service/history/interfaces"
|
|
)
|
|
|
|
func emitWorkflowHistoryStats(
|
|
metricsHandler metrics.Handler,
|
|
namespace namespace.Name,
|
|
state enumsspb.WorkflowExecutionState,
|
|
historySize int,
|
|
historyCount int,
|
|
) {
|
|
handler := metricsHandler.WithTags(metrics.NamespaceTag(namespace.String()))
|
|
executionScope := handler.WithTags(metrics.OperationTag(metrics.ExecutionStatsScope))
|
|
metrics.HistorySize.With(executionScope).Record(int64(historySize))
|
|
metrics.HistoryCount.With(executionScope).Record(int64(historyCount))
|
|
|
|
if state == enumsspb.WORKFLOW_EXECUTION_STATE_COMPLETED {
|
|
completionScope := handler.WithTags(metrics.OperationTag(metrics.WorkflowCompletionStatsScope))
|
|
metrics.HistorySize.With(completionScope).Record(int64(historySize))
|
|
metrics.HistoryCount.With(completionScope).Record(int64(historyCount))
|
|
}
|
|
}
|
|
|
|
func emitMutableStateStatus(
|
|
metricsHandler metrics.Handler,
|
|
stats *persistence.MutableStateStatistics,
|
|
) {
|
|
if stats == nil {
|
|
return
|
|
}
|
|
|
|
batchHandler := metricsHandler.StartBatch("mutable_state_status")
|
|
defer batchHandler.Close()
|
|
metrics.MutableStateSize.With(batchHandler).Record(int64(stats.TotalSize))
|
|
metrics.ExecutionInfoSize.With(batchHandler).Record(int64(stats.ExecutionInfoSize))
|
|
metrics.ExecutionStateSize.With(batchHandler).Record(int64(stats.ExecutionStateSize))
|
|
metrics.ActivityInfoSize.With(batchHandler).Record(int64(stats.ActivityInfoSize))
|
|
metrics.ActivityInfoCount.With(batchHandler).Record(int64(stats.ActivityInfoCount))
|
|
metrics.TotalActivityCount.With(batchHandler).Record(stats.TotalActivityCount)
|
|
metrics.TimerInfoSize.With(batchHandler).Record(int64(stats.TimerInfoSize))
|
|
metrics.TimerInfoCount.With(batchHandler).Record(int64(stats.TimerInfoCount))
|
|
metrics.TotalUserTimerCount.With(batchHandler).Record(stats.TotalUserTimerCount)
|
|
metrics.ChildInfoSize.With(batchHandler).Record(int64(stats.ChildInfoSize))
|
|
metrics.ChildInfoCount.With(batchHandler).Record(int64(stats.ChildInfoCount))
|
|
metrics.TotalChildExecutionCount.With(batchHandler).Record(stats.TotalChildExecutionCount)
|
|
metrics.RequestCancelInfoSize.With(batchHandler).Record(int64(stats.RequestCancelInfoSize))
|
|
metrics.RequestCancelInfoCount.With(batchHandler).Record(int64(stats.RequestCancelInfoCount))
|
|
metrics.TotalRequestCancelExternalCount.With(batchHandler).Record(stats.TotalRequestCancelExternalCount)
|
|
metrics.SignalInfoSize.With(batchHandler).Record(int64(stats.SignalInfoSize))
|
|
metrics.SignalInfoCount.With(batchHandler).Record(int64(stats.SignalInfoCount))
|
|
metrics.TotalSignalExternalCount.With(batchHandler).Record(stats.TotalSignalExternalCount)
|
|
metrics.SignalRequestIDSize.With(batchHandler).Record(int64(stats.SignalRequestIDSize))
|
|
metrics.SignalRequestIDCount.With(batchHandler).Record(int64(stats.SignalRequestIDCount))
|
|
metrics.TotalSignalCount.With(batchHandler).Record(stats.TotalSignalCount)
|
|
metrics.BufferedEventsSize.With(batchHandler).Record(int64(stats.BufferedEventsSize))
|
|
metrics.BufferedEventsCount.With(batchHandler).Record(int64(stats.BufferedEventsCount))
|
|
metrics.ChasmTotalSize.With(batchHandler).Record(int64(stats.ChasmTotalSize))
|
|
|
|
if stats.HistoryStatistics != nil {
|
|
metrics.HistorySize.With(batchHandler).Record(int64(stats.HistoryStatistics.SizeDiff))
|
|
metrics.HistoryCount.With(batchHandler).Record(int64(stats.HistoryStatistics.CountDiff))
|
|
}
|
|
|
|
for category, taskCount := range stats.TaskCountByCategory {
|
|
metrics.TaskCount.With(batchHandler).Record(int64(taskCount), metrics.TaskCategoryTag(category))
|
|
}
|
|
}
|
|
|
|
func emitWorkflowCompletionStats(
|
|
metricsHandler metrics.Handler,
|
|
namespace namespace.Name,
|
|
completion completionMetric,
|
|
config *configs.Config,
|
|
) {
|
|
// Only emit metrics for Workflows, not other Chasm archetypes
|
|
if !completion.isWorkflow {
|
|
return
|
|
}
|
|
|
|
handler := GetPerTaskQueueFamilyScope(metricsHandler, namespace, completion.taskQueue, config,
|
|
metrics.OperationTag(metrics.WorkflowCompletionStatsScope),
|
|
metrics.NamespaceStateTag(completion.namespaceState),
|
|
metrics.WorkflowTypeTag(completion.workflowTypeName),
|
|
)
|
|
|
|
closed := true
|
|
switch completion.status {
|
|
case enumspb.WORKFLOW_EXECUTION_STATUS_COMPLETED:
|
|
metrics.WorkflowSuccessCount.With(handler).Record(1)
|
|
case enumspb.WORKFLOW_EXECUTION_STATUS_CANCELED:
|
|
metrics.WorkflowCancelCount.With(handler).Record(1)
|
|
case enumspb.WORKFLOW_EXECUTION_STATUS_FAILED:
|
|
metrics.WorkflowFailedCount.With(handler).Record(1)
|
|
case enumspb.WORKFLOW_EXECUTION_STATUS_TIMED_OUT:
|
|
metrics.WorkflowTimeoutCount.With(handler).Record(1)
|
|
case enumspb.WORKFLOW_EXECUTION_STATUS_TERMINATED:
|
|
metrics.WorkflowTerminateCount.With(handler).Record(1)
|
|
case enumspb.WORKFLOW_EXECUTION_STATUS_CONTINUED_AS_NEW:
|
|
metrics.WorkflowContinuedAsNewCount.With(handler).Record(1)
|
|
case enumspb.WORKFLOW_EXECUTION_STATUS_UNSPECIFIED, enumspb.WORKFLOW_EXECUTION_STATUS_RUNNING:
|
|
closed = false
|
|
}
|
|
if closed && completion.startTime != nil && completion.closeTime != nil {
|
|
startTime := completion.startTime.AsTime()
|
|
closeTime := completion.closeTime.AsTime()
|
|
if closeTime.After(startTime) {
|
|
metrics.WorkflowDuration.With(handler).Record(closeTime.Sub(startTime))
|
|
}
|
|
}
|
|
}
|
|
|
|
func GetPerTaskQueueFamilyScope(
|
|
handler metrics.Handler,
|
|
namespaceName namespace.Name,
|
|
taskQueueFamily string,
|
|
config *configs.Config,
|
|
tags ...metrics.Tag,
|
|
) metrics.Handler {
|
|
return metrics.GetPerTaskQueueFamilyScope(handler,
|
|
namespaceName.String(),
|
|
tqid.UnsafeTaskQueueFamily(namespaceName.String(), taskQueueFamily),
|
|
config.BreakdownMetricsByTaskQueue(namespaceName.String(), taskQueueFamily, enumspb.TASK_QUEUE_TYPE_WORKFLOW),
|
|
tags...,
|
|
)
|
|
}
|
|
|
|
type ActivityExecutionStatus int
|
|
|
|
const (
|
|
ActivityStatusUnknown ActivityExecutionStatus = iota
|
|
ActivityStatusSucceeded
|
|
ActivityStatusFailed
|
|
ActivityStatusCanceled
|
|
ActivityStatusTimeout
|
|
)
|
|
|
|
type ActivityCompletionMetrics struct {
|
|
// Status determines whether the activity succeeded, and whether it is/will be retried
|
|
Status ActivityExecutionStatus
|
|
// AttemptStartedTime is the start time of the current attempt
|
|
AttemptStartedTime time.Time
|
|
// FirstScheduledTime is the scheduled time of the first attempt
|
|
FirstScheduledTime time.Time
|
|
// Closed is true if no more attempts will be made to execute the activity.
|
|
Closed bool
|
|
// TimerType is the type of timer that caused the activity execution to timeout.
|
|
TimerType enumspb.TimeoutType
|
|
}
|
|
|
|
func RecordActivityCompletionMetrics(
|
|
shard historyi.ShardContext,
|
|
namespaceName namespace.Name,
|
|
taskQueue string,
|
|
completion ActivityCompletionMetrics,
|
|
tags ...metrics.Tag,
|
|
) {
|
|
metricsHandler := GetPerTaskQueueFamilyScope(
|
|
shard.GetMetricsHandler(),
|
|
namespaceName,
|
|
taskQueue,
|
|
shard.GetConfig(),
|
|
tags...,
|
|
)
|
|
|
|
if !completion.AttemptStartedTime.IsZero() && completion.Status != ActivityStatusTimeout {
|
|
latency := time.Since(completion.AttemptStartedTime)
|
|
// ActivityE2ELatency is deprecated due to its inaccurate naming. It captures the attempt duration instead of an end-to-end duration as its name suggests. For now record both metrics
|
|
metrics.ActivityE2ELatency.With(metricsHandler).Record(latency)
|
|
metrics.ActivityStartToCloseLatency.With(metricsHandler).Record(latency)
|
|
}
|
|
|
|
// Record true end-to-end duration only for terminal states (includes retries and backoffs)
|
|
if completion.Closed && !completion.FirstScheduledTime.IsZero() {
|
|
scheduleToCloseLatency := time.Since(completion.FirstScheduledTime)
|
|
metrics.ActivityScheduleToCloseLatency.With(metricsHandler).Record(scheduleToCloseLatency)
|
|
}
|
|
|
|
switch completion.Status {
|
|
case ActivityStatusFailed:
|
|
metrics.ActivityTaskFail.With(metricsHandler).Record(1)
|
|
if completion.Closed {
|
|
metrics.ActivityFail.With(metricsHandler).Record(1)
|
|
}
|
|
case ActivityStatusCanceled:
|
|
metrics.ActivityCancel.With(metricsHandler).Record(1)
|
|
case ActivityStatusSucceeded:
|
|
metrics.ActivitySuccess.With(metricsHandler).Record(1)
|
|
case ActivityStatusTimeout:
|
|
metrics.ActivityTaskTimeout.With(metricsHandler).Record(1, metrics.StringTag("timeout_type", completion.TimerType.String()))
|
|
if completion.Closed {
|
|
metrics.ActivityTimeout.With(metricsHandler).Record(1, metrics.StringTag("timeout_type", completion.TimerType.String()))
|
|
}
|
|
default:
|
|
// Do nothing
|
|
}
|
|
}
|