Files
tasks/temporal/server_impl.go
9b3b45da84 Split Background task priority to PriorityHigh and PriorityLow (#7901)
## What changed?
Split background task priority to two levels BackgroundLow and
BackgroundHigh.
Tasks like ActivityTimeout, WorkflowTaskTimeout, WorkflowRunTimeout,
WorkflowExecutionTimeout will have BackgroundLow priority.
Other tasks like UserTime, TransferWorkflowTask, TransferActivity task
etc will have BackgroundHigh priority.
System tasks like retention timers will still have the lowest priority
level as before.

## Why?
This will help the task processor prioritize important tasks like
UserTimer and TransferWorkflowTasks when there is rate limiting.
Tasks like timeout timers have comparatively lower priority.

## How did you test it?
- [ ] built
- [ ] run locally and tested manually
- [ ] covered by existing tests
- [ ] added new unit test(s)
- [ ] added new functional test(s)

---------

Co-authored-by: Yichao Yang <[email protected]>
2025-06-12 08:57:53 -07:00

190 lines
5.8 KiB
Go

package temporal
import (
"cmp"
"context"
"fmt"
"slices"
"time"
"go.opentelemetry.io/otel/trace"
"go.temporal.io/server/common/cluster"
"go.temporal.io/server/common/config"
"go.temporal.io/server/common/headers"
"go.temporal.io/server/common/log"
"go.temporal.io/server/common/log/tag"
"go.temporal.io/server/common/metrics"
persistenceClient "go.temporal.io/server/common/persistence/client"
"go.temporal.io/server/common/primitives"
"go.temporal.io/server/common/resolver"
"go.temporal.io/server/common/resource"
"go.temporal.io/server/common/telemetry"
"go.uber.org/multierr"
)
type (
// ServerImpl is temporal server.
ServerImpl struct {
so *serverOptions
servicesMetadata []*ServicesMetadata
stoppedCh chan interface{}
logger log.Logger
namespaceLogger resource.NamespaceLogger
persistenceConfig config.Persistence
clusterMetadata *cluster.Config
persistenceFactoryProvider persistenceClient.FactoryProviderFn
metricsHandler metrics.Handler
tracerProvider trace.TracerProvider
}
)
// When starting multiple services in one process (typically a development server), start them
// in this order and stop them in the reverse order. This most important part here is that the
// worker depends on the frontend, which depends on matching and history.
var initOrder = map[primitives.ServiceName]int{
primitives.MatchingService: 1,
primitives.HistoryService: 2,
primitives.InternalFrontendService: 3,
primitives.FrontendService: 3,
primitives.WorkerService: 4,
}
// NewServerFxImpl returns a new instance of server that serves one or many services.
func NewServerFxImpl(
opts *serverOptions,
logger log.Logger,
namespaceLogger resource.NamespaceLogger,
stoppedCh chan interface{},
servicesGroup ServicesGroupIn,
persistenceConfig config.Persistence,
clusterMetadata *cluster.Config,
persistenceFactoryProvider persistenceClient.FactoryProviderFn,
metricsHandler metrics.Handler,
) *ServerImpl {
s := &ServerImpl{
so: opts,
stoppedCh: stoppedCh,
logger: logger,
namespaceLogger: namespaceLogger,
persistenceConfig: persistenceConfig,
clusterMetadata: clusterMetadata,
persistenceFactoryProvider: persistenceFactoryProvider,
metricsHandler: metricsHandler,
}
for _, svcMeta := range servicesGroup.Services {
if svcMeta != nil {
s.servicesMetadata = append(s.servicesMetadata, svcMeta)
}
}
return s
}
func (s *ServerImpl) Start(ctx context.Context) error {
s.logger.Info("Starting server for services", tag.Value(s.so.serviceNames))
s.logger.Debug(s.so.config.String())
if err := initSystemNamespaces(
ctx,
&s.persistenceConfig,
s.clusterMetadata.CurrentClusterName,
s.so.persistenceServiceResolver,
s.persistenceFactoryProvider,
s.logger,
s.so.customDataStoreFactory,
s.metricsHandler,
); err != nil {
return fmt.Errorf("unable to initialize system namespace: %w", err)
}
return s.startServices()
}
func (s *ServerImpl) Stop(ctx context.Context) error {
close(s.stoppedCh)
svcs := slices.Clone(s.servicesMetadata)
slices.SortFunc(svcs, func(a, b *ServicesMetadata) int {
return -cmp.Compare(initOrder[a.serviceName], initOrder[b.serviceName]) // note negative
})
for _, svc := range svcs {
svc.Stop(ctx)
}
if s.so.metricHandler != nil {
s.so.metricHandler.Stop(s.logger)
}
return nil
}
func (s *ServerImpl) startServices() error {
// The membership join time may exceed the configured max join duration.
// Double the service start timeout to make sure there is enough time for start logic.
timeout := max(serviceStartTimeout, 2*s.so.config.Global.Membership.MaxJoinDuration)
ctx, cancel := context.WithTimeout(context.Background(), timeout)
defer cancel()
svcs := slices.Clone(s.servicesMetadata)
slices.SortFunc(svcs, func(a, b *ServicesMetadata) int {
return cmp.Compare(initOrder[a.serviceName], initOrder[b.serviceName])
})
var allErrs error
for _, svc := range svcs {
err := svc.app.Start(ctx)
if err != nil {
allErrs = multierr.Append(allErrs, fmt.Errorf("failed to start service %v: %w", svc.serviceName, err))
}
}
return allErrs
}
func initSystemNamespaces(
ctx context.Context,
cfg *config.Persistence,
currentClusterName string,
persistenceServiceResolver resolver.ServiceResolver,
persistenceFactoryProvider persistenceClient.FactoryProviderFn,
logger log.Logger,
customDataStoreFactory persistenceClient.AbstractDataStoreFactory,
metricsHandler metrics.Handler,
) error {
clusterName := persistenceClient.ClusterName(currentClusterName)
metricsHandler = metricsHandler.WithTags(metrics.ServiceNameTag(primitives.ServerService))
dataStoreFactory := persistenceClient.DataStoreFactoryProvider(
clusterName,
persistenceServiceResolver,
cfg,
customDataStoreFactory,
logger,
metricsHandler,
telemetry.NoopTracerProvider,
)
factory := persistenceFactoryProvider(persistenceClient.NewFactoryParams{
DataStoreFactory: dataStoreFactory,
Cfg: cfg,
PersistenceMaxQPS: nil,
PersistenceNamespaceMaxQPS: nil,
ClusterName: persistenceClient.ClusterName(currentClusterName),
MetricsHandler: metricsHandler,
Logger: logger,
})
defer factory.Close()
metadataManager, err := factory.NewMetadataManager()
if err != nil {
return fmt.Errorf("unable to initialize metadata manager: %w", err)
}
defer metadataManager.Close()
ctx, cancel := context.WithTimeout(
headers.SetCallerInfo(ctx, headers.SystemBackgroundHighCallerInfo),
30*time.Second,
)
defer cancel()
if err = metadataManager.InitializeSystemNamespaces(ctx, currentClusterName); err != nil {
return fmt.Errorf("unable to register system namespace: %w", err)
}
return nil
}