mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
## What changed? Adding a breakdown of stats per-priority levels to the two APIs that return task queue stats already. ## Why? New API is defined here: https://github.com/temporalio/api/pull/611. ## How did you test it? - [ ] built - [ ] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [x] added new functional test(s)
656 lines
24 KiB
Go
656 lines
24 KiB
Go
package tests
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"sync"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/pborman/uuid"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
"github.com/stretchr/testify/suite"
|
|
commandpb "go.temporal.io/api/command/v1"
|
|
commonpb "go.temporal.io/api/common/v1"
|
|
deploymentpb "go.temporal.io/api/deployment/v1"
|
|
enumspb "go.temporal.io/api/enums/v1"
|
|
taskqueuepb "go.temporal.io/api/taskqueue/v1"
|
|
workflowpb "go.temporal.io/api/workflow/v1"
|
|
"go.temporal.io/api/workflowservice/v1"
|
|
deploymentspb "go.temporal.io/server/api/deployment/v1"
|
|
"go.temporal.io/server/common/dynamicconfig"
|
|
"go.temporal.io/server/common/worker_versioning"
|
|
"go.temporal.io/server/tests/testcore"
|
|
"google.golang.org/protobuf/types/known/durationpb"
|
|
)
|
|
|
|
const (
|
|
minPriority = 1
|
|
maxPriority = 5
|
|
defaultPriority = 3
|
|
)
|
|
|
|
type (
|
|
// TaskQueueStatsSuite tests are querying task queue stats.
|
|
//
|
|
// There are currently three ways to do that:
|
|
// 1. DescribeTaskQueue with ReportStats=true
|
|
// 2. DescribeTaskQueue with ApiMode=ENHANCED and ReportStats=true [deprecated]
|
|
// 3. DescribeWorkerDeploymentVersion with ReportTaskQueueStats=true
|
|
//
|
|
// Unless a test calls out a specific methods, all three methods are tested in each test case.
|
|
TaskQueueStatsSuite struct {
|
|
testcore.FunctionalTestBase
|
|
usePriMatcher bool
|
|
}
|
|
|
|
TaskQueueExpectations struct {
|
|
BacklogCount int
|
|
MaxExtraTasks int
|
|
ExpectedAddRate bool
|
|
ExpectedDispatch bool
|
|
CachedEnabled bool
|
|
}
|
|
|
|
// TaskQueueExpectationsByType maps task queue types to their expectations
|
|
TaskQueueExpectationsByType map[enumspb.TaskQueueType]TaskQueueExpectations
|
|
)
|
|
|
|
// TODO(pri): remove once the classic matcher is removed
|
|
func TestTaskQueueStats_Classic_Suite(t *testing.T) {
|
|
t.Parallel()
|
|
suite.Run(t, &TaskQueueStatsSuite{usePriMatcher: false})
|
|
}
|
|
|
|
func TestTaskQueueStats_Pri_Suite(t *testing.T) {
|
|
t.Parallel()
|
|
suite.Run(t, &TaskQueueStatsSuite{usePriMatcher: true})
|
|
}
|
|
|
|
func (s *TaskQueueStatsSuite) SetupTest() {
|
|
s.FunctionalTestBase.SetupTest()
|
|
s.OverrideDynamicConfig(dynamicconfig.EnableDeploymentVersions, true)
|
|
s.OverrideDynamicConfig(dynamicconfig.FrontendEnableWorkerVersioningWorkflowAPIs, true)
|
|
s.OverrideDynamicConfig(dynamicconfig.MatchingUseNewMatcher, s.usePriMatcher)
|
|
s.OverrideDynamicConfig(dynamicconfig.MatchingPriorityLevels, maxPriority)
|
|
}
|
|
|
|
func (s *TaskQueueStatsSuite) TestDescribeTaskQueue_NonRoot() {
|
|
resp, err := s.FrontendClient().DescribeTaskQueue(context.Background(), &workflowservice.DescribeTaskQueueRequest{
|
|
Namespace: s.Namespace().String(),
|
|
TaskQueue: &taskqueuepb.TaskQueue{Name: "/_sys/foo/1", Kind: enumspb.TASK_QUEUE_KIND_NORMAL},
|
|
})
|
|
s.NoError(err)
|
|
s.NotNil(resp)
|
|
|
|
_, err = s.FrontendClient().DescribeTaskQueue(context.Background(),
|
|
&workflowservice.DescribeTaskQueueRequest{
|
|
Namespace: s.Namespace().String(),
|
|
TaskQueue: &taskqueuepb.TaskQueue{Name: "/_sys/foo/1", Kind: enumspb.TASK_QUEUE_KIND_NORMAL},
|
|
ReportStats: true,
|
|
})
|
|
s.ErrorContains(err, "DescribeTaskQueue stats are only supported for the root partition")
|
|
}
|
|
|
|
func (s *TaskQueueStatsSuite) TestNoTasks_ValidateStats() {
|
|
s.OverrideDynamicConfig(dynamicconfig.MatchingNumTaskqueueReadPartitions, 4)
|
|
s.OverrideDynamicConfig(dynamicconfig.MatchingNumTaskqueueWritePartitions, 4)
|
|
s.OverrideDynamicConfig(dynamicconfig.MatchingLongPollExpirationInterval, 10*time.Second)
|
|
s.OverrideDynamicConfig(dynamicconfig.TaskQueueInfoByBuildIdTTL, 1*time.Millisecond) // zero means no TTL
|
|
|
|
s.publishConsumeWorkflowTasksValidateStats(0, false)
|
|
}
|
|
|
|
func (s *TaskQueueStatsSuite) TestSingleTask_SinglePartition_ValidateStats() {
|
|
s.OverrideDynamicConfig(dynamicconfig.MatchingNumTaskqueueReadPartitions, 1)
|
|
s.OverrideDynamicConfig(dynamicconfig.MatchingNumTaskqueueWritePartitions, 1)
|
|
s.OverrideDynamicConfig(dynamicconfig.MatchingUpdateAckInterval, 5*time.Second)
|
|
s.OverrideDynamicConfig(dynamicconfig.TaskQueueInfoByBuildIdTTL, 1*time.Millisecond) // zero means no TTL
|
|
|
|
s.publishConsumeWorkflowTasksValidateStats(1, true)
|
|
}
|
|
|
|
func (s *TaskQueueStatsSuite) TestMultipleTasks_MultiplePartitions_WithMatchingBehavior_ValidateStats() {
|
|
s.OverrideDynamicConfig(dynamicconfig.MatchingNumTaskqueueReadPartitions, 4)
|
|
s.OverrideDynamicConfig(dynamicconfig.MatchingNumTaskqueueWritePartitions, 4)
|
|
s.OverrideDynamicConfig(dynamicconfig.MatchingLongPollExpirationInterval, 10*time.Second)
|
|
s.OverrideDynamicConfig(dynamicconfig.TaskQueueInfoByBuildIdTTL, 1*time.Millisecond) // zero means no TTL
|
|
|
|
s.RunTestWithMatchingBehavior(func() {
|
|
s.publishConsumeWorkflowTasksValidateStats(4, false)
|
|
})
|
|
}
|
|
|
|
// NOTE: Cache _eviction_ is already covered by the other tests.
|
|
func (s *TaskQueueStatsSuite) TestAddMultipleTasks_MultiplePartitions_ValidateStats_Cached() {
|
|
s.OverrideDynamicConfig(dynamicconfig.MatchingLongPollExpirationInterval, 10*time.Second)
|
|
s.OverrideDynamicConfig(dynamicconfig.TaskQueueInfoByBuildIdTTL, 1*time.Hour) // using a long TTL to verify caching
|
|
|
|
tqName := testcore.RandomizeStr("backlog-counter-task-queue")
|
|
s.createDeploymentInTaskQueue(tqName)
|
|
|
|
// Enqueue all workflows.
|
|
total := s.enqueueWorkflows(2, tqName)
|
|
|
|
// Expect at least *one* of the workflow/activity tasks to be in the stats.
|
|
expectations := TaskQueueExpectations{
|
|
BacklogCount: 1, // ie at least one task in the backlog
|
|
MaxExtraTasks: total, // ie at most all tasks can be in the backlog
|
|
ExpectedAddRate: true,
|
|
ExpectedDispatch: true,
|
|
CachedEnabled: true,
|
|
}
|
|
|
|
// Enqueue 1 activity set, to make sure the workflow backlog has some tasks.
|
|
s.enqueueActivitiesForEachWorkflow(1, tqName)
|
|
|
|
// Expect the workflow backlog to be non-empty now.
|
|
// This query will cache the stats for the remainder of the test.
|
|
s.validateTaskQueueStatsByType(tqName, enumspb.TASK_QUEUE_TYPE_WORKFLOW, expectations, false)
|
|
|
|
// Enqueue remaining activities.
|
|
s.enqueueActivitiesForEachWorkflow(1, tqName)
|
|
|
|
// Poll 2 activities, ie 1 per version, to make sure the activity backlog has some tasks.
|
|
s.pollActivities(2, tqName)
|
|
|
|
// Expect the activity backlog to be non-empty now.
|
|
// This query will cache the stats for the remainder of the test.
|
|
s.validateTaskQueueStatsByType(tqName, enumspb.TASK_QUEUE_TYPE_ACTIVITY, expectations, false)
|
|
|
|
// Poll remaining activities.
|
|
s.pollActivities(total-2, tqName)
|
|
|
|
// Despite having polled all the workflows/activies; the stats won't have changed at all since they were cached.
|
|
s.validateTaskQueueStatsByType(tqName, enumspb.TASK_QUEUE_TYPE_WORKFLOW, expectations, false)
|
|
s.validateTaskQueueStatsByType(tqName, enumspb.TASK_QUEUE_TYPE_ACTIVITY, expectations, false)
|
|
}
|
|
|
|
// Publishes versioned and unversioned entities; with one entity per priority (plus default priority). Multiplied by `sets`.
|
|
func (s *TaskQueueStatsSuite) publishConsumeWorkflowTasksValidateStats(sets int, singlePartition bool) {
|
|
tqName := testcore.RandomizeStr("backlog-counter-task-queue")
|
|
s.createDeploymentInTaskQueue(tqName)
|
|
|
|
// verify both workflow and activity backlogs are empty
|
|
expectations := TaskQueueExpectationsByType{
|
|
enumspb.TASK_QUEUE_TYPE_WORKFLOW: {
|
|
BacklogCount: 0,
|
|
MaxExtraTasks: 0,
|
|
ExpectedAddRate: false,
|
|
ExpectedDispatch: false,
|
|
},
|
|
enumspb.TASK_QUEUE_TYPE_ACTIVITY: {
|
|
BacklogCount: 0,
|
|
MaxExtraTasks: 0,
|
|
ExpectedAddRate: false,
|
|
ExpectedDispatch: false,
|
|
},
|
|
}
|
|
|
|
s.validateAllTaskQueueStats(tqName, expectations, singlePartition)
|
|
|
|
// Actual counter can be greater than the expected due to History->Matching retries.
|
|
// We make sure the counter is in range [expected, expected+maxExtraTasksAllowed].
|
|
maxExtraTasksAllowed := 3
|
|
if sets == 0 {
|
|
maxExtraTasksAllowed = 0
|
|
}
|
|
|
|
// enqueue workflows
|
|
total := s.enqueueWorkflows(sets, tqName)
|
|
|
|
// verify workflow backlog is not empty, activity backlog is empty
|
|
expectations[enumspb.TASK_QUEUE_TYPE_WORKFLOW] = TaskQueueExpectations{
|
|
BacklogCount: total,
|
|
MaxExtraTasks: maxExtraTasksAllowed,
|
|
ExpectedAddRate: sets > 0,
|
|
ExpectedDispatch: false,
|
|
}
|
|
|
|
s.validateAllTaskQueueStats(tqName, expectations, singlePartition)
|
|
|
|
// poll all workflow tasks and enqueue one activity task for each workflow
|
|
totalAct := s.enqueueActivitiesForEachWorkflow(sets, tqName)
|
|
s.EqualValues(total, totalAct, "should have enqueued the same number of activities as workflows")
|
|
|
|
// verify workflow backlog is empty, activity backlog is not
|
|
expectations[enumspb.TASK_QUEUE_TYPE_WORKFLOW] = TaskQueueExpectations{
|
|
BacklogCount: 0,
|
|
MaxExtraTasks: maxExtraTasksAllowed,
|
|
ExpectedAddRate: sets > 0,
|
|
ExpectedDispatch: sets > 0,
|
|
}
|
|
expectations[enumspb.TASK_QUEUE_TYPE_ACTIVITY] = TaskQueueExpectations{
|
|
BacklogCount: total,
|
|
MaxExtraTasks: maxExtraTasksAllowed,
|
|
ExpectedAddRate: sets > 0,
|
|
ExpectedDispatch: false,
|
|
}
|
|
|
|
s.validateAllTaskQueueStats(tqName, expectations, singlePartition)
|
|
|
|
// poll all activity tasks
|
|
s.pollActivities(total, tqName)
|
|
|
|
// verify both workflow and activity backlogs are empty
|
|
expectations[enumspb.TASK_QUEUE_TYPE_ACTIVITY] = TaskQueueExpectations{
|
|
BacklogCount: 0,
|
|
MaxExtraTasks: maxExtraTasksAllowed,
|
|
ExpectedAddRate: sets > 0,
|
|
ExpectedDispatch: sets > 0,
|
|
}
|
|
|
|
s.validateAllTaskQueueStats(tqName, expectations, singlePartition)
|
|
}
|
|
|
|
func (s *TaskQueueStatsSuite) enqueueWorkflows(sets int, tqName string) int {
|
|
deploymentOpts := s.deploymentOptions(tqName)
|
|
|
|
var total int
|
|
for version := 0; version < 2; version++ { // 0=unversioned, 1=versioned
|
|
for priority := 0; priority <= maxPriority; priority++ {
|
|
for i := 0; i < sets; i++ {
|
|
wt := "functional-workflow-multiple-tasks"
|
|
workflowType := &commonpb.WorkflowType{Name: wt}
|
|
|
|
request := &workflowservice.StartWorkflowExecutionRequest{
|
|
Namespace: s.Namespace().String(),
|
|
WorkflowId: uuid.New(),
|
|
WorkflowType: workflowType,
|
|
TaskQueue: &taskqueuepb.TaskQueue{Name: tqName, Kind: enumspb.TASK_QUEUE_KIND_NORMAL},
|
|
Input: nil,
|
|
WorkflowRunTimeout: durationpb.New(10 * time.Minute),
|
|
WorkflowTaskTimeout: durationpb.New(10 * time.Minute),
|
|
RequestId: uuid.New(),
|
|
WorkflowIdReusePolicy: enumspb.WORKFLOW_ID_REUSE_POLICY_ALLOW_DUPLICATE,
|
|
Priority: &commonpb.Priority{PriorityKey: int32(priority)},
|
|
}
|
|
|
|
if version == 1 {
|
|
request.VersioningOverride = &workflowpb.VersioningOverride{
|
|
Override: &workflowpb.VersioningOverride_Pinned{
|
|
Pinned: &workflowpb.VersioningOverride_PinnedOverride{
|
|
Behavior: workflowpb.VersioningOverride_PINNED_OVERRIDE_BEHAVIOR_PINNED,
|
|
Version: &deploymentpb.WorkerDeploymentVersion{
|
|
BuildId: deploymentOpts.BuildId,
|
|
DeploymentName: deploymentOpts.DeploymentName,
|
|
},
|
|
},
|
|
},
|
|
}
|
|
}
|
|
|
|
_, err := s.FrontendClient().StartWorkflowExecution(testcore.NewContext(), request)
|
|
s.NoError(err)
|
|
|
|
total++
|
|
}
|
|
}
|
|
}
|
|
|
|
s.T().Logf("Enqueued %d workflows", total)
|
|
return total
|
|
}
|
|
|
|
func (s *TaskQueueStatsSuite) createDeploymentInTaskQueue(tqName string) {
|
|
var wg sync.WaitGroup
|
|
wg.Add(2)
|
|
|
|
go func() {
|
|
defer wg.Done()
|
|
_, _ = s.FrontendClient().PollWorkflowTaskQueue(testcore.NewContext(), &workflowservice.PollWorkflowTaskQueueRequest{
|
|
Namespace: s.Namespace().String(),
|
|
TaskQueue: &taskqueuepb.TaskQueue{Name: tqName, Kind: enumspb.TASK_QUEUE_KIND_NORMAL},
|
|
Identity: "random",
|
|
DeploymentOptions: s.deploymentOptions(tqName),
|
|
})
|
|
}()
|
|
|
|
go func() {
|
|
defer wg.Done()
|
|
_, _ = s.FrontendClient().PollActivityTaskQueue(testcore.NewContext(), &workflowservice.PollActivityTaskQueueRequest{
|
|
Namespace: s.Namespace().String(),
|
|
TaskQueue: &taskqueuepb.TaskQueue{Name: tqName, Kind: enumspb.TASK_QUEUE_KIND_NORMAL},
|
|
Identity: "random",
|
|
DeploymentOptions: s.deploymentOptions(tqName),
|
|
})
|
|
}()
|
|
|
|
wg.Wait()
|
|
}
|
|
|
|
func (s *TaskQueueStatsSuite) enqueueActivitiesForEachWorkflow(sets int, tqName string) int {
|
|
deploymentOpts := s.deploymentOptions(tqName)
|
|
|
|
var total int
|
|
for version := 0; version < 2; version++ { // 0=unversioned, 1=versioned
|
|
for priority := 0; priority <= maxPriority; priority++ {
|
|
for i := 0; i < sets; { // not counting up here to allow for retries
|
|
pollReq := &workflowservice.PollWorkflowTaskQueueRequest{
|
|
Namespace: s.Namespace().String(),
|
|
TaskQueue: &taskqueuepb.TaskQueue{Name: tqName, Kind: enumspb.TASK_QUEUE_KIND_NORMAL},
|
|
}
|
|
if version == 1 {
|
|
pollReq.DeploymentOptions = deploymentOpts
|
|
}
|
|
|
|
resp, err := s.FrontendClient().PollWorkflowTaskQueue(testcore.NewContext(), pollReq)
|
|
s.NoError(err)
|
|
if resp == nil || resp.GetAttempt() < 1 {
|
|
continue
|
|
}
|
|
|
|
respondReq := &workflowservice.RespondWorkflowTaskCompletedRequest{
|
|
Namespace: s.Namespace().String(),
|
|
TaskToken: resp.TaskToken,
|
|
Commands: []*commandpb.Command{
|
|
{
|
|
CommandType: enumspb.COMMAND_TYPE_SCHEDULE_ACTIVITY_TASK,
|
|
Attributes: &commandpb.Command_ScheduleActivityTaskCommandAttributes{
|
|
ScheduleActivityTaskCommandAttributes: &commandpb.ScheduleActivityTaskCommandAttributes{
|
|
ActivityId: "activity1",
|
|
ActivityType: &commonpb.ActivityType{Name: "activity_type1"},
|
|
TaskQueue: &taskqueuepb.TaskQueue{Name: tqName, Kind: enumspb.TASK_QUEUE_KIND_NORMAL},
|
|
StartToCloseTimeout: durationpb.New(time.Minute),
|
|
RequestEagerExecution: false,
|
|
// Priority is inherted from the workflow
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
|
|
if version == 1 {
|
|
respondReq.DeploymentOptions = deploymentOpts
|
|
respondReq.VersioningBehavior = enumspb.VERSIONING_BEHAVIOR_PINNED
|
|
}
|
|
|
|
_, err = s.FrontendClient().RespondWorkflowTaskCompleted(testcore.NewContext(), respondReq)
|
|
s.NoError(err)
|
|
|
|
i++
|
|
total++
|
|
}
|
|
}
|
|
}
|
|
s.T().Logf("Enqueued %d activities", total)
|
|
return total
|
|
}
|
|
|
|
func (s *TaskQueueStatsSuite) pollActivities(count int, tqName string) {
|
|
for i := 0; i < count; {
|
|
pollReq := &workflowservice.PollActivityTaskQueueRequest{
|
|
Namespace: s.Namespace().String(),
|
|
TaskQueue: &taskqueuepb.TaskQueue{
|
|
Name: tqName,
|
|
Kind: enumspb.TASK_QUEUE_KIND_NORMAL,
|
|
},
|
|
}
|
|
if i%2 == 0 {
|
|
pollReq.DeploymentOptions = s.deploymentOptions(tqName)
|
|
}
|
|
|
|
resp, err := s.FrontendClient().PollActivityTaskQueue(
|
|
testcore.NewContext(), pollReq,
|
|
)
|
|
s.NoError(err)
|
|
if resp == nil || resp.GetAttempt() < 1 {
|
|
continue // poll again on empty responses
|
|
}
|
|
i++
|
|
}
|
|
s.T().Logf("Polled %d activities", count)
|
|
}
|
|
|
|
func (s *TaskQueueStatsSuite) validateAllTaskQueueStats(
|
|
tqName string,
|
|
expectations TaskQueueExpectationsByType,
|
|
singlePartition bool,
|
|
) {
|
|
for tqType, expectation := range expectations {
|
|
s.validateTaskQueueStatsByType(tqName, tqType, expectation, singlePartition)
|
|
}
|
|
}
|
|
|
|
func (s *TaskQueueStatsSuite) validateTaskQueueStatsByType(
|
|
tqName string,
|
|
tqType enumspb.TaskQueueType,
|
|
expectation TaskQueueExpectations,
|
|
singlePartition bool,
|
|
) {
|
|
ctx, cancel := context.WithTimeout(context.Background(), 30*time.Second)
|
|
defer cancel()
|
|
|
|
s.validateDescribeTaskQueueWithDefaultMode(ctx, tqName, tqType, expectation, singlePartition)
|
|
|
|
// The other two methods report *either* versioned or unversioned stats, so we need to
|
|
// half the expectations to account for that.
|
|
halfExpectation := expectation
|
|
halfExpectation.BacklogCount /= 2
|
|
halfExpectation.MaxExtraTasks /= 2
|
|
|
|
s.validateDescribeTaskQueueWithEnhancedMode(ctx, tqName, tqType, halfExpectation)
|
|
s.validateDescribeWorkerDeploymentVersion(ctx, tqName, tqType, halfExpectation)
|
|
}
|
|
|
|
func (s *TaskQueueStatsSuite) validateDescribeTaskQueueWithDefaultMode(
|
|
ctx context.Context,
|
|
tqName string,
|
|
tqType enumspb.TaskQueueType,
|
|
expectation TaskQueueExpectations,
|
|
singlePartition bool,
|
|
) {
|
|
req := &workflowservice.DescribeTaskQueueRequest{
|
|
Namespace: s.Namespace().String(),
|
|
TaskQueue: &taskqueuepb.TaskQueue{Name: tqName, Kind: enumspb.TASK_QUEUE_KIND_NORMAL},
|
|
TaskQueueType: tqType,
|
|
}
|
|
|
|
// test stats are not reported by default (and therefore also not cached)
|
|
resp, err := s.FrontendClient().DescribeTaskQueue(ctx, req)
|
|
s.NoError(err)
|
|
s.NotNil(resp)
|
|
s.Nil(resp.Stats, "stats should not be reported by default")
|
|
//nolint:staticcheck // SA1019 deprecated
|
|
s.Nil(resp.TaskQueueStatus, "status should not be reported by default")
|
|
|
|
s.EventuallyWithT(func(c *assert.CollectT) {
|
|
a := require.New(c)
|
|
label := "DescribeTaskQueue_DefaultMode[" + tqType.String() + "]"
|
|
|
|
req.ReportStats = true
|
|
//nolint:staticcheck // SA1019 deprecated
|
|
req.IncludeTaskQueueStatus = true
|
|
resp, err := s.FrontendClient().DescribeTaskQueue(ctx, req)
|
|
a.NoError(err)
|
|
a.NotNil(resp)
|
|
|
|
if singlePartition {
|
|
expected := expectation.BacklogCount / 2 // only reports unversioned
|
|
//nolint:staticcheck // SA1019 deprecated field
|
|
actual := resp.TaskQueueStatus.GetBacklogCountHint()
|
|
a.EqualValuesf(expected, actual, "%s: backlog hint should be %d, got %d", label, expected, actual)
|
|
}
|
|
|
|
validateTaskQueueStats(label, a, resp.Stats, expectation)
|
|
if s.usePriMatcher && expectation.BacklogCount > 0 {
|
|
// Per priority stats are only available with the priority matcher and when they've been actively used.
|
|
validateTaskQueueStatsByPriority(label, a, resp.StatsByPriorityKey, expectation)
|
|
}
|
|
}, 5*time.Second, 100*time.Millisecond)
|
|
}
|
|
|
|
func (s *TaskQueueStatsSuite) validateDescribeTaskQueueWithEnhancedMode(
|
|
ctx context.Context,
|
|
tqName string,
|
|
tqType enumspb.TaskQueueType,
|
|
expectation TaskQueueExpectations,
|
|
) {
|
|
deploymentOpts := s.deploymentOptions(tqName)
|
|
req := &workflowservice.DescribeTaskQueueRequest{
|
|
Namespace: s.Namespace().String(),
|
|
TaskQueue: &taskqueuepb.TaskQueue{Name: tqName, Kind: enumspb.TASK_QUEUE_KIND_NORMAL},
|
|
ApiMode: enumspb.DESCRIBE_TASK_QUEUE_MODE_ENHANCED,
|
|
Versions: &taskqueuepb.TaskQueueVersionSelection{
|
|
BuildIds: []string{worker_versioning.WorkerDeploymentVersionToStringV32(
|
|
&deploymentspb.WorkerDeploymentVersion{
|
|
BuildId: deploymentOpts.BuildId,
|
|
DeploymentName: deploymentOpts.DeploymentName,
|
|
})},
|
|
Unversioned: true,
|
|
},
|
|
TaskQueueTypes: []enumspb.TaskQueueType{tqType},
|
|
ReportPollers: true,
|
|
}
|
|
|
|
if !expectation.CachedEnabled { // skip if testing caching; as this would pin the result to the cache
|
|
resp, err := s.FrontendClient().DescribeTaskQueue(ctx, req)
|
|
s.NoError(err)
|
|
s.NotNil(resp)
|
|
s.Nil(resp.Stats, "stats should not be reported by default")
|
|
//nolint:staticcheck // SA1019 deprecated
|
|
s.Nil(resp.TaskQueueStatus, "status should not be reported")
|
|
}
|
|
|
|
s.EventuallyWithT(func(c *assert.CollectT) {
|
|
a := require.New(c)
|
|
|
|
req.ReportStats = true
|
|
resp, err := s.FrontendClient().DescribeTaskQueue(ctx, req)
|
|
a.NoError(err)
|
|
a.NotNil(resp)
|
|
|
|
//nolint:staticcheck // SA1019 deprecated
|
|
a.Equal(2, len(resp.GetVersionsInfo()), "should be 2: 1 default/unversioned + 1 versioned")
|
|
//nolint:staticcheck // SA1019 deprecated
|
|
for _, v := range resp.GetVersionsInfo() {
|
|
a.Equal(enumspb.BUILD_ID_TASK_REACHABILITY_UNSPECIFIED, v.GetTaskReachability())
|
|
|
|
info := v.GetTypesInfo()[int32(tqType)]
|
|
a.NotNil(info, "should have info for task queue type %s", tqType)
|
|
|
|
validateTaskQueueStats("DescribeTaskQueue_EnhancedMode["+tqType.String()+"]", a, info.Stats, expectation)
|
|
}
|
|
}, 5*time.Second, 100*time.Millisecond)
|
|
}
|
|
|
|
func (s *TaskQueueStatsSuite) validateDescribeWorkerDeploymentVersion(
|
|
ctx context.Context,
|
|
tqName string,
|
|
tqType enumspb.TaskQueueType,
|
|
expectation TaskQueueExpectations,
|
|
) {
|
|
deploymentOpts := s.deploymentOptions(tqName)
|
|
req := &workflowservice.DescribeWorkerDeploymentVersionRequest{
|
|
Namespace: s.Namespace().String(),
|
|
DeploymentVersion: &deploymentpb.WorkerDeploymentVersion{
|
|
BuildId: deploymentOpts.BuildId,
|
|
DeploymentName: deploymentOpts.DeploymentName,
|
|
},
|
|
}
|
|
|
|
// test stats are not reported by default (and therefore also not cached)
|
|
resp, err := s.FrontendClient().DescribeWorkerDeploymentVersion(ctx, req)
|
|
s.NoError(err)
|
|
s.NotNil(resp)
|
|
for _, info := range resp.VersionTaskQueues {
|
|
s.Nil(info.Stats, "stats should not be reported by default")
|
|
}
|
|
|
|
s.EventuallyWithT(func(c *assert.CollectT) {
|
|
a := require.New(c)
|
|
|
|
req.ReportTaskQueueStats = true
|
|
resp, err := s.FrontendClient().DescribeWorkerDeploymentVersion(ctx, req)
|
|
s.NoError(err)
|
|
a.Len(resp.VersionTaskQueues, 2, "should be 1 task queue for Workflows and 1 for Activities")
|
|
|
|
for _, info := range resp.VersionTaskQueues {
|
|
if info.Name == tqName || info.Type == tqType {
|
|
label := "DescribeWorkerDeploymentVersion[" + tqType.String() + "]"
|
|
validateTaskQueueStats(label, a, info.Stats, expectation)
|
|
if s.usePriMatcher && expectation.BacklogCount > 0 {
|
|
// Per priority stats are only available with the priority matcher and when they've been actively used.
|
|
validateTaskQueueStatsByPriority(label, a, info.StatsByPriorityKey, expectation)
|
|
}
|
|
return
|
|
}
|
|
}
|
|
a.Failf("Task queue %s of type %s not found in response", tqName, tqType)
|
|
}, 5*time.Second, 100*time.Millisecond)
|
|
}
|
|
|
|
func validateTaskQueueStatsByPriority(
|
|
label string,
|
|
a *require.Assertions,
|
|
stats map[int32]*taskqueuepb.TaskQueueStats,
|
|
taskQueueExpectation TaskQueueExpectations,
|
|
) {
|
|
a.Len(stats, maxPriority, "%s: stats should contain %d priorities", label, maxPriority)
|
|
|
|
// use an abgridged version when caching since the exact stats are difficult to predict
|
|
if taskQueueExpectation.CachedEnabled {
|
|
for i := int32(minPriority); i <= maxPriority; i++ {
|
|
if stats[i].ApproximateBacklogCount != 0 && stats[i].TasksDispatchRate > 0 || stats[i].TasksAddRate > 0 {
|
|
return
|
|
}
|
|
}
|
|
a.Failf("%s: should have found at least one non-zero backlog count with any non-zero rate across priorities", label)
|
|
}
|
|
|
|
var accBacklogCount int
|
|
for i := int32(minPriority); i <= maxPriority; i++ {
|
|
priExpectation := taskQueueExpectation
|
|
priExpectation.BacklogCount = taskQueueExpectation.BacklogCount / (maxPriority + 1)
|
|
if i == defaultPriority {
|
|
priExpectation.BacklogCount *= 2 // zero priority translates to default priority 3
|
|
}
|
|
|
|
a.Containsf(stats, i, "%s: stats should contain priority %d", label, i)
|
|
validateTaskQueueStats(fmt.Sprintf("%s_Pri[%d]", label, i), a, stats[i], priExpectation)
|
|
accBacklogCount += int(stats[i].ApproximateBacklogCount)
|
|
}
|
|
a.GreaterOrEqualf(taskQueueExpectation.BacklogCount, accBacklogCount,
|
|
"%s: accumulated backlog count from all priorities should be at least %d, got %d",
|
|
label, taskQueueExpectation.BacklogCount, accBacklogCount)
|
|
}
|
|
|
|
func validateTaskQueueStats(
|
|
label string,
|
|
a *require.Assertions,
|
|
stats *taskqueuepb.TaskQueueStats,
|
|
expectation TaskQueueExpectations,
|
|
) {
|
|
// Actual counter can be greater than the expected due to history retries. We make sure the counter is in
|
|
// range [expected, expected+maxBacklogExtraTasks]
|
|
a.GreaterOrEqual(stats.ApproximateBacklogCount, int64(expectation.BacklogCount),
|
|
"%s: ApproximateBacklogCount should be at least %d, got %d",
|
|
label, expectation.BacklogCount, stats.ApproximateBacklogCount)
|
|
|
|
maxApproximateBacklogCount := int64(expectation.BacklogCount + expectation.MaxExtraTasks)
|
|
a.LessOrEqual(stats.ApproximateBacklogCount, maxApproximateBacklogCount,
|
|
"%s: ApproximateBacklogCount should be at most %d, got %d",
|
|
label, maxApproximateBacklogCount, stats.ApproximateBacklogCount)
|
|
|
|
a.Equal(stats.ApproximateBacklogCount == 0, stats.ApproximateBacklogAge.AsDuration() == time.Duration(0),
|
|
"%s: ApproximateBacklogAge should be 0 when ApproximateBacklogCount is 0, got %s",
|
|
label, stats.ApproximateBacklogAge.AsDuration())
|
|
|
|
a.Equal(expectation.ExpectedAddRate, stats.TasksAddRate > 0,
|
|
"%s: TasksAddRate should be greater than 0 when ExpectedAddRate is true, got %f",
|
|
label, stats.TasksAddRate)
|
|
|
|
a.Equal(expectation.ExpectedDispatch, stats.TasksDispatchRate > 0,
|
|
"%s: TasksDispatchRate should be greater than 0 when ExpectedDispatch is true, got %f",
|
|
label, stats.TasksDispatchRate)
|
|
}
|
|
|
|
func (s *TaskQueueStatsSuite) deploymentOptions(tqName string) *deploymentpb.WorkerDeploymentOptions {
|
|
return &deploymentpb.WorkerDeploymentOptions{
|
|
DeploymentName: tqName + "-deployment",
|
|
BuildId: "build-id",
|
|
WorkerVersioningMode: enumspb.WORKER_VERSIONING_MODE_VERSIONED,
|
|
}
|
|
}
|