Files
tasks/chasm/lib/scheduler/generator_tasks.go
Lina JodoinandGitHub 3ae9d6bf43 CHASM Visibility support minor fixes (#8690)
## What changed?
- Addresses a few follow-ups from the initial PR after merge:
  - Makes `Memo` provider use deterministic proto marshalling
  - Fixes a few style nitpicks
  - Removes some unneeded TODOs
2025-11-25 18:17:31 +00:00

193 lines
5.5 KiB
Go

package scheduler
import (
"fmt"
"time"
"go.temporal.io/server/chasm"
"go.temporal.io/server/chasm/lib/scheduler/gen/schedulerpb/v1"
"go.temporal.io/server/common/log"
"go.temporal.io/server/common/log/tag"
"go.temporal.io/server/common/metrics"
"go.temporal.io/server/common/primitives/timestamp"
queueerrors "go.temporal.io/server/service/history/queues/errors"
"go.uber.org/fx"
"google.golang.org/protobuf/types/known/durationpb"
"google.golang.org/protobuf/types/known/timestamppb"
)
type (
GeneratorTaskExecutorOptions struct {
fx.In
Config *Config
MetricsHandler metrics.Handler
BaseLogger log.Logger
SpecProcessor SpecProcessor
}
GeneratorTaskExecutor struct {
config *Config
metricsHandler metrics.Handler
baseLogger log.Logger
SpecProcessor SpecProcessor
}
)
func NewGeneratorTaskExecutor(opts GeneratorTaskExecutorOptions) *GeneratorTaskExecutor {
return &GeneratorTaskExecutor{
config: opts.Config,
metricsHandler: opts.MetricsHandler,
baseLogger: opts.BaseLogger,
SpecProcessor: opts.SpecProcessor,
}
}
func (g *GeneratorTaskExecutor) Execute(
ctx chasm.MutableContext,
generator *Generator,
_ chasm.TaskAttributes,
_ *schedulerpb.GeneratorTask,
) error {
scheduler := generator.Scheduler.Get(ctx)
logger := newTaggedLogger(g.baseLogger, scheduler)
invoker := scheduler.Invoker.Get(ctx)
// If we have no last processed time, this is a new schedule.
if generator.LastProcessedTime == nil {
createdAt := timestamppb.New(ctx.Now(generator))
generator.LastProcessedTime = createdAt
scheduler.Info.CreateTime = createdAt
g.logSchedule(logger, "starting schedule", scheduler)
}
// If the high water mark is earlier than when a schedule was updated, we must skip any actions that hadn't
// yet been processed.
if scheduler.Info.GetUpdateTime().AsTime().After(generator.LastProcessedTime.AsTime()) {
generator.LastProcessedTime = scheduler.Info.GetUpdateTime()
}
// Process time range between last high water mark and system time.
t1 := generator.LastProcessedTime.AsTime()
t2 := ctx.Now(generator).UTC()
if t2.Before(t1) {
logger.Warn("time went backwards",
tag.NewStringerTag("time", t1),
tag.NewStringerTag("time", t2))
t2 = t1
}
result, err := g.SpecProcessor.ProcessTimeRange(
scheduler,
t1, t2,
scheduler.overlapPolicy(),
scheduler.WorkflowID(),
"",
false,
nil,
)
if err != nil {
// An error here should be impossible, send to the DLQ.
return queueerrors.NewUnprocessableTaskError(
fmt.Sprintf("failed to process a time range: %s", err.Error()))
}
// Enqueue newly-generated buffered starts.
if len(result.BufferedStarts) > 0 {
invoker.EnqueueBufferedStarts(ctx, result.BufferedStarts)
}
// Write the new high water mark and future action times.
generator.LastProcessedTime = timestamppb.New(result.LastActionTime)
if err := g.updateFutureActionTimes(generator, scheduler); err != nil {
return queueerrors.NewUnprocessableTaskError(
fmt.Sprintf("failed to update future action times: %s", err.Error()))
}
// Check if the schedule has gone idle.
idleTimeTotal := g.config.Tweakables(scheduler.Namespace).IdleTime
idleExpiration, isIdle := scheduler.getIdleExpiration(ctx, idleTimeTotal, result.NextWakeupTime)
if isIdle {
// Schedule is complete, no need for another buffer task. We keep the schedule's
// backing mutable state explicitly open for a the idle period, during which the
// customer can describe/modify/restart the schedule.
//
// Once the idle timer expires, we close the component.
ctx.AddTask(scheduler, chasm.TaskAttributes{
ScheduledTime: idleExpiration,
}, &schedulerpb.SchedulerIdleTask{
IdleTimeTotal: durationpb.New(idleTimeTotal),
})
return nil
}
// No more tasks if we're paused.
if scheduler.Schedule.State.Paused {
return nil
}
// Another buffering task is added if we aren't completely out of actions or paused.
ctx.AddTask(generator, chasm.TaskAttributes{
ScheduledTime: result.NextWakeupTime,
}, &schedulerpb.GeneratorTask{})
return nil
}
func (g *GeneratorTaskExecutor) logSchedule(logger log.Logger, msg string, scheduler *Scheduler) {
logger.Debug(msg,
tag.NewStringerTag("spec", jsonStringer{scheduler.Schedule.Spec}),
tag.NewStringerTag("policies", jsonStringer{scheduler.Schedule.Policies}))
}
func (g *GeneratorTaskExecutor) updateFutureActionTimes(
generator *Generator,
scheduler *Scheduler,
) error {
nextTime := func(t time.Time) (time.Time, error) {
res, err := g.SpecProcessor.NextTime(scheduler, t)
return res.Next, err
}
// Make sure we don't emit more future times than are remaining.
count := recentActionCount
if scheduler.Schedule.State.LimitedActions {
count = min(int(scheduler.Schedule.State.RemainingActions), recentActionCount)
}
futureTimes := make([]*timestamppb.Timestamp, 0, count)
t := timestamp.TimeValue(generator.LastProcessedTime)
var err error
for len(futureTimes) < count {
t, err = nextTime(t)
if err != nil {
return err
}
if t.IsZero() {
break
}
if scheduler.Info.UpdateTime.AsTime().After(t) {
// Skip action times that occur before the schedule's update time.
continue
}
futureTimes = append(futureTimes, timestamppb.New(t))
}
generator.FutureActionTimes = futureTimes
return nil
}
func (g *GeneratorTaskExecutor) Validate(
ctx chasm.Context,
generator *Generator,
attrs chasm.TaskAttributes,
_ *schedulerpb.GeneratorTask,
) (bool, error) {
return validateTaskHighWaterMark(generator.GetLastProcessedTime(), attrs.ScheduledTime)
}