mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
## What changed? - We should be checking if a query is blackholed only by checking the appropriate conditions on the root partition. - Moreover, added the testhook bug about read partitions over here which @dnr spotted! ## Why? - Correctness. - Moreover, the test TestVersioning3FunctionalSuiteV0/TestPinnedQuery_RollbackDrainedVersion was failing after the testhook bug fix. The root partition check also fixed it! ## How did you test it? - [ ] built - [ ] run locally and tested manually - [x] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s) ## Potential risks - None. --- > [!NOTE] > Ensures correctness in worker-versioning query handling and fixes a testhook misrouting. > > - Only run `checkQueryBlackholed` on the root partition to avoid false "no pollers" errors across partitions (`task_queue_partition_manager.go`) > - Fix testhook to use `MatchingLBForceReadPartition` when forcing read partitions in `PickReadPartition` (`client/matching/loadbalancer.go`) > > <sup>Written by [Cursor Bugbot]() for commit 140da43453cd129c7ecd4b3b58dc9557b4d9b4e3. This will update automatically on new commits. Configure [here]().</sup>