Files
tasks/common/archiver/gcloud/visibility_archiver.go
1be2922647 Cherry-pick remaining fixes for OSS v1.30.2 (#9578)
## What changed?
Cherry-pick remaining PRs labeled `release/1.30.2` that were not
included in the versioning cherry-pick (#9543).

Cherry-picked commits (in merge-date order):
- #9329 — Fixing bug in retrieving archived workflows from Google Cloud
Store
- #9467 — Fix race in fairTaskReader
- #9456 — chore: remove create-tag workflow and trivy scanning
- #9433 — chore: bump Temporal CLI version to 1.6.1 in Docker image
build

Note: #9282 (VersionMembershipCache) was skipped because its changes
were already present on the release branch (included within #9543).

## Why?
For OSS v1.30.2 patch release.

## How did you test it?
- [x] covered by existing tests
- [ ] added new unit test(s)
- [ ] added new functional test(s)

## Potential risks
Low — these are cherry-picks of already-merged and tested PRs from
`main`. One conflict was resolved for #9456 (delete of `create-tag.yml`
which was modified on the release branch).

Made with [Cursor]()

---------

Co-authored-by: Ulrich Romahn <[email protected]>
Co-authored-by: David Reiss <[email protected]>
Co-authored-by: Alex Stanfield <[email protected]>
2026-03-18 21:39:24 -07:00

312 lines
11 KiB
Go

package gcloud
import (
"context"
"errors"
"fmt"
"path/filepath"
"strings"
"time"
"go.temporal.io/api/serviceerror"
archiverspb "go.temporal.io/server/api/archiver/v1"
"go.temporal.io/server/common/archiver"
"go.temporal.io/server/common/archiver/gcloud/connector"
"go.temporal.io/server/common/config"
"go.temporal.io/server/common/log"
"go.temporal.io/server/common/log/tag"
"go.temporal.io/server/common/metrics"
"go.temporal.io/server/common/searchattribute"
)
const (
errEncodeVisibilityRecord = "failed to encode visibility record"
indexKeyStartTimeout = "startTimeout"
indexKeyCloseTimeout = "closeTimeout"
timeoutInSeconds = 5
)
var (
errRetryable = errors.New("retryable error")
)
type (
visibilityArchiver struct {
logger log.Logger
metricsHandler metrics.Handler
gcloudStorage connector.Client
queryParser QueryParser
}
queryVisibilityToken struct {
Offset int
}
queryVisibilityRequest struct {
namespaceID string
pageSize int
nextPageToken []byte
parsedQuery *parsedQuery
}
)
func newVisibilityArchiver(logger log.Logger, metricsHandler metrics.Handler, storage connector.Client) *visibilityArchiver {
return &visibilityArchiver{
logger: logger,
metricsHandler: metricsHandler,
gcloudStorage: storage,
queryParser: NewQueryParser(),
}
}
// NewVisibilityArchiver creates a new archiver.VisibilityArchiver based on filestore
func NewVisibilityArchiver(logger log.Logger, metricsHandler metrics.Handler, cfg *config.GstorageArchiver) (archiver.VisibilityArchiver, error) {
storage, err := connector.NewClient(context.Background(), cfg)
return newVisibilityArchiver(logger, metricsHandler, storage), err
}
// Archive is used to archive one workflow visibility record.
// Check the Archive() method of the HistoryArchiver interface in Step 2 for parameters' meaning and requirements.
// The only difference is that the ArchiveOption parameter won't include an option for recording process.
// Please make sure your implementation is lossless. If any in-memory batching mechanism is used, then those batched records will be lost during server restarts.
// This method will be invoked when workflow closes. Note that because of conflict resolution, it is possible for a workflow to through the closing process multiple times, which means that this method can be invoked more than once after a workflow closes.
func (v *visibilityArchiver) Archive(ctx context.Context, URI archiver.URI, request *archiverspb.VisibilityRecord, opts ...archiver.ArchiveOption) (err error) {
handler := v.metricsHandler.WithTags(metrics.OperationTag(metrics.HistoryArchiverScope), metrics.NamespaceTag(request.Namespace))
featureCatalog := archiver.GetFeatureCatalog(opts...)
startTime := time.Now().UTC()
defer func() {
metrics.ServiceLatency.With(handler).Record(time.Since(startTime))
if err != nil {
if isRetryableError(err) {
metrics.VisibilityArchiverArchiveTransientErrorCount.With(handler).Record(1)
} else {
metrics.VisibilityArchiverArchiveNonRetryableErrorCount.With(handler).Record(1)
if featureCatalog.NonRetryableError != nil {
err = featureCatalog.NonRetryableError()
}
}
}
}()
logger := archiver.TagLoggerWithArchiveVisibilityRequestAndURI(v.logger, request, URI.String())
if err := v.ValidateURI(URI); err != nil {
if isRetryableError(err) {
logger.Error(archiver.ArchiveTransientErrorMsg, tag.ArchivalArchiveFailReason(archiver.ErrReasonInvalidURI), tag.Error(err))
return err
}
logger.Error(archiver.ArchiveNonRetryableErrorMsg, tag.ArchivalArchiveFailReason(archiver.ErrReasonInvalidURI), tag.Error(err))
return err
}
if err := archiver.ValidateVisibilityArchivalRequest(request); err != nil {
logger.Error(archiver.ArchiveNonRetryableErrorMsg, tag.ArchivalArchiveFailReason(archiver.ErrReasonInvalidArchiveRequest), tag.Error(err))
return err
}
encodedVisibilityRecord, err := encode(request)
if err != nil {
logger.Error(archiver.ArchiveNonRetryableErrorMsg, tag.ArchivalArchiveFailReason(errEncodeVisibilityRecord), tag.Error(err))
return err
}
// The filename has the format: closeTimestamp_hash(runID).visibility
// This format allows the archiver to sort all records without reading the file contents
filename := constructVisibilityFilename(request.GetNamespaceId(), request.WorkflowTypeName, request.GetWorkflowId(), request.GetRunId(), indexKeyCloseTimeout, request.CloseTime.AsTime())
if err := v.gcloudStorage.Upload(ctx, URI, filename, encodedVisibilityRecord); err != nil {
logger.Error(archiver.ArchiveTransientErrorMsg, tag.ArchivalArchiveFailReason(errWriteFile), tag.Error(err))
return errRetryable
}
filename = constructVisibilityFilename(request.GetNamespaceId(), request.WorkflowTypeName, request.GetWorkflowId(), request.GetRunId(), indexKeyStartTimeout, request.StartTime.AsTime())
if err := v.gcloudStorage.Upload(ctx, URI, filename, encodedVisibilityRecord); err != nil {
logger.Error(archiver.ArchiveTransientErrorMsg, tag.ArchivalArchiveFailReason(errWriteFile), tag.Error(err))
return errRetryable
}
metrics.VisibilityArchiveSuccessCount.With(handler).Record(1)
return nil
}
// Query is used to retrieve archived visibility records.
// Check the Get() method of the HistoryArchiver interface in Step 2 for parameters' meaning and requirements.
// The request includes a string field called query, which describes what kind of visibility records should be returned. For example, it can be some SQL-like syntax query string.
// Your implementation is responsible for parsing and validating the query, and also returning all visibility records that match the query.
// Currently the maximum context timeout passed into the method is 3 minutes, so it's ok if this method takes a long time to run.
func (v *visibilityArchiver) Query(
ctx context.Context,
URI archiver.URI,
request *archiver.QueryVisibilityRequest,
saTypeMap searchattribute.NameTypeMap,
) (*archiver.QueryVisibilityResponse, error) {
if err := v.ValidateURI(URI); err != nil {
return nil, &serviceerror.InvalidArgument{Message: archiver.ErrInvalidURI.Error()}
}
if err := archiver.ValidateQueryRequest(request); err != nil {
return nil, &serviceerror.InvalidArgument{Message: archiver.ErrInvalidQueryVisibilityRequest.Error()}
}
if strings.TrimSpace(request.Query) == "" {
return v.queryAll(ctx, URI, request, saTypeMap)
}
parsedQuery, err := v.queryParser.Parse(request.Query)
if err != nil {
return nil, &serviceerror.InvalidArgument{Message: err.Error()}
}
if parsedQuery.emptyResult {
return &archiver.QueryVisibilityResponse{}, nil
}
return v.query(
ctx,
URI,
&queryVisibilityRequest{
namespaceID: request.NamespaceID,
pageSize: request.PageSize,
nextPageToken: request.NextPageToken,
parsedQuery: parsedQuery,
},
saTypeMap,
)
}
func (v *visibilityArchiver) query(
ctx context.Context,
uri archiver.URI,
request *queryVisibilityRequest,
saTypeMap searchattribute.NameTypeMap,
) (*archiver.QueryVisibilityResponse, error) {
prefix := constructVisibilityFilenamePrefix(request.namespaceID, indexKeyCloseTimeout)
if !request.parsedQuery.closeTime.IsZero() {
prefix = constructTimeBasedSearchKey(
request.namespaceID,
indexKeyCloseTimeout,
request.parsedQuery.closeTime,
*request.parsedQuery.searchPrecision,
)
}
if !request.parsedQuery.startTime.IsZero() {
prefix = constructTimeBasedSearchKey(
request.namespaceID,
indexKeyStartTimeout,
request.parsedQuery.startTime,
*request.parsedQuery.searchPrecision,
)
}
return v.queryPrefix(ctx, uri, request, saTypeMap, prefix)
}
func (v *visibilityArchiver) queryAll(
ctx context.Context,
URI archiver.URI,
request *archiver.QueryVisibilityRequest,
saTypeMap searchattribute.NameTypeMap,
) (*archiver.QueryVisibilityResponse, error) {
return v.queryPrefix(ctx, URI, &queryVisibilityRequest{
namespaceID: request.NamespaceID,
pageSize: request.PageSize,
nextPageToken: request.NextPageToken,
parsedQuery: &parsedQuery{},
}, saTypeMap, constructVisibilityFilenamePrefix(request.NamespaceID, indexKeyCloseTimeout))
}
func (v *visibilityArchiver) queryPrefix(ctx context.Context, uri archiver.URI, request *queryVisibilityRequest, saTypeMap searchattribute.NameTypeMap, prefix string) (*archiver.QueryVisibilityResponse, error) {
token, err := v.parseToken(request.nextPageToken)
if err != nil {
return nil, err
}
filters := make([]connector.Precondition, 0)
if request.parsedQuery.workflowID != nil {
filters = append(filters, newWorkflowIDPrecondition(hash(*request.parsedQuery.workflowID)))
}
if request.parsedQuery.runID != nil {
filters = append(filters, newWorkflowIDPrecondition(hash(*request.parsedQuery.runID)))
}
if request.parsedQuery.workflowType != nil {
filters = append(filters, newWorkflowIDPrecondition(hash(*request.parsedQuery.workflowType)))
}
filenames, completed, currentCursorPos, err := v.gcloudStorage.QueryWithFilters(ctx, uri, prefix, request.pageSize, token.Offset, filters)
if err != nil {
return nil, &serviceerror.InvalidArgument{Message: err.Error()}
}
response := &archiver.QueryVisibilityResponse{}
for _, file := range filenames {
encodedRecord, err := v.gcloudStorage.Get(ctx, uri, fmt.Sprintf("%s/%s", request.namespaceID, filepath.Base(file)))
if err != nil {
return nil, &serviceerror.InvalidArgument{Message: err.Error()}
}
record, err := decodeVisibilityRecord(encodedRecord)
if err != nil {
return nil, &serviceerror.InvalidArgument{Message: err.Error()}
}
executionInfo, err := convertToExecutionInfo(record, saTypeMap)
if err != nil {
return nil, serviceerror.NewInternal(err.Error())
}
response.Executions = append(response.Executions, executionInfo)
}
if !completed {
newToken := &queryVisibilityToken{
Offset: currentCursorPos,
}
encodedToken, err := serializeToken(newToken)
if err != nil {
return nil, &serviceerror.InvalidArgument{Message: err.Error()}
}
response.NextPageToken = encodedToken
}
return response, nil
}
func (v *visibilityArchiver) parseToken(nextPageToken []byte) (*queryVisibilityToken, error) {
token := new(queryVisibilityToken)
if nextPageToken != nil {
var err error
token, err = deserializeQueryVisibilityToken(nextPageToken)
if err != nil {
return nil, &serviceerror.InvalidArgument{Message: archiver.ErrNextPageTokenCorrupted.Error()}
}
}
return token, nil
}
// ValidateURI is used to define what a valid URI for an implementation is.
func (v *visibilityArchiver) ValidateURI(URI archiver.URI) (err error) {
ctx, cancel := context.WithTimeout(context.Background(), timeoutInSeconds*time.Second)
defer cancel()
if err = v.validateURI(URI); err == nil {
_, err = v.gcloudStorage.Exist(ctx, URI, "")
}
return
}
func (v *visibilityArchiver) validateURI(URI archiver.URI) (err error) {
if URI.Scheme() != URIScheme {
return archiver.ErrURISchemeMismatch
}
if URI.Path() == "" || URI.Hostname() == "" {
return archiver.ErrInvalidURI
}
return
}