Files
David ReissandGitHub 807b319251 Refactor archival fx initialization (#7766)
## What changed?
Refactor how archival subsystem gets its dependencies to work better
with fx:
- Remove service type maps (archivalProvider is already
service-specific)
- Remove "bootstrap" structs and just pass around dependencies

## Why?
The service type maps were causing issues like #7631, and are
unnecessary.

## How did you test it?
- [x] built
- [ ] run locally and tested manually
- [x] covered by existing tests
- [ ] added new unit test(s)
- [ ] added new functional test(s)
2025-05-15 20:17:57 +00:00

157 lines
4.9 KiB
Go

//go:generate mockgen -package $GOPACKAGE -source $GOFILE -destination provider_mock.go
package provider
import (
"errors"
"sync"
"go.temporal.io/server/common/archiver"
"go.temporal.io/server/common/archiver/filestore"
"go.temporal.io/server/common/archiver/gcloud"
"go.temporal.io/server/common/archiver/s3store"
"go.temporal.io/server/common/config"
"go.temporal.io/server/common/log"
"go.temporal.io/server/common/metrics"
"go.temporal.io/server/common/persistence"
)
var (
// ErrUnknownScheme is the error for unknown archiver scheme
ErrUnknownScheme = errors.New("unknown archiver scheme")
// ErrArchiverConfigNotFound is the error for unable to find the config for an archiver given scheme
ErrArchiverConfigNotFound = errors.New("unable to find archiver config for the given scheme")
)
type (
// ArchiverProvider returns history or visibility archiver based on the scheme.
// The archiver for each scheme will be created only once and cached.
ArchiverProvider interface {
GetHistoryArchiver(scheme string) (archiver.HistoryArchiver, error)
GetVisibilityArchiver(scheme string) (archiver.VisibilityArchiver, error)
}
archiverProvider struct {
sync.RWMutex
historyArchiverConfigs *config.HistoryArchiverProvider
visibilityArchiverConfigs *config.VisibilityArchiverProvider
executionManager persistence.ExecutionManager
logger log.Logger
metricsHandler metrics.Handler
// Key for the archiver is scheme
historyArchivers map[string]archiver.HistoryArchiver
visibilityArchivers map[string]archiver.VisibilityArchiver
}
)
// NewArchiverProvider returns a new Archiver provider
func NewArchiverProvider(
historyArchiverConfigs *config.HistoryArchiverProvider,
visibilityArchiverConfigs *config.VisibilityArchiverProvider,
executionManager persistence.ExecutionManager,
logger log.Logger,
metricsHandler metrics.Handler,
) ArchiverProvider {
return &archiverProvider{
historyArchiverConfigs: historyArchiverConfigs,
visibilityArchiverConfigs: visibilityArchiverConfigs,
executionManager: executionManager,
logger: logger,
metricsHandler: metricsHandler,
historyArchivers: make(map[string]archiver.HistoryArchiver),
visibilityArchivers: make(map[string]archiver.VisibilityArchiver),
}
}
func (p *archiverProvider) GetHistoryArchiver(scheme string) (historyArchiver archiver.HistoryArchiver, err error) {
p.RLock()
if historyArchiver, ok := p.historyArchivers[scheme]; ok {
p.RUnlock()
return historyArchiver, nil
}
p.RUnlock()
switch scheme {
case filestore.URIScheme:
if p.historyArchiverConfigs.Filestore == nil {
return nil, ErrArchiverConfigNotFound
}
historyArchiver, err = filestore.NewHistoryArchiver(p.executionManager, p.logger, p.metricsHandler, p.historyArchiverConfigs.Filestore)
case gcloud.URIScheme:
if p.historyArchiverConfigs.Gstorage == nil {
return nil, ErrArchiverConfigNotFound
}
historyArchiver, err = gcloud.NewHistoryArchiver(p.executionManager, p.logger, p.metricsHandler, p.historyArchiverConfigs.Gstorage)
case s3store.URIScheme:
if p.historyArchiverConfigs.S3store == nil {
return nil, ErrArchiverConfigNotFound
}
historyArchiver, err = s3store.NewHistoryArchiver(p.executionManager, p.logger, p.metricsHandler, p.historyArchiverConfigs.S3store)
default:
return nil, ErrUnknownScheme
}
if err != nil {
return nil, err
}
p.Lock()
defer p.Unlock()
if existingHistoryArchiver, ok := p.historyArchivers[scheme]; ok {
return existingHistoryArchiver, nil
}
p.historyArchivers[scheme] = historyArchiver
return historyArchiver, nil
}
func (p *archiverProvider) GetVisibilityArchiver(scheme string) (archiver.VisibilityArchiver, error) {
p.RLock()
if visibilityArchiver, ok := p.visibilityArchivers[scheme]; ok {
p.RUnlock()
return visibilityArchiver, nil
}
p.RUnlock()
var visibilityArchiver archiver.VisibilityArchiver
var err error
switch scheme {
case filestore.URIScheme:
if p.visibilityArchiverConfigs.Filestore == nil {
return nil, ErrArchiverConfigNotFound
}
visibilityArchiver, err = filestore.NewVisibilityArchiver(p.logger, p.metricsHandler, p.visibilityArchiverConfigs.Filestore)
case s3store.URIScheme:
if p.visibilityArchiverConfigs.S3store == nil {
return nil, ErrArchiverConfigNotFound
}
visibilityArchiver, err = s3store.NewVisibilityArchiver(p.logger, p.metricsHandler, p.visibilityArchiverConfigs.S3store)
case gcloud.URIScheme:
if p.visibilityArchiverConfigs.Gstorage == nil {
return nil, ErrArchiverConfigNotFound
}
visibilityArchiver, err = gcloud.NewVisibilityArchiver(p.logger, p.metricsHandler, p.visibilityArchiverConfigs.Gstorage)
default:
return nil, ErrUnknownScheme
}
if err != nil {
return nil, err
}
p.Lock()
defer p.Unlock()
if existingVisibilityArchiver, ok := p.visibilityArchivers[scheme]; ok {
return existingVisibilityArchiver, nil
}
p.visibilityArchivers[scheme] = visibilityArchiver
return visibilityArchiver, nil
}