Files
tasks/common/backoff/retry.go
04e868e94c Add timeout tasks for Standalone Activities (#8573)
## What changed?
Added timeout tasks for standalone activities. Refactored existing
backoff algorithm to common. Added outcome field. Fixed a few errors as
the result of main rebase. Regen go.sum. Fixed broken redirection tests.
Uncommented `LifecycleStateTimedout` and added supporting logic in
`closeTransactionHandleRootLifecycleChange`

## Why?
We need schedule-to-start, schedule-to-close, and start-to-close timeout
support for standalone activities. Also reusing existing activity retry
backoff code, so refactored it to a common package. We need to bring
back LifecycleStateTimedout
because when a timeout lifecycle occurs the workflow status needs to
update to `WORKFLOW_EXECUTION_STATUS_TIMED_OUT`, else we encounter an
invalidate state change: `unable to change workflow state from Created
to Completed, status Failed`

## How did you test it?
- [X] built
- [X] run locally and tested manually
- [X] covered by existing tests
- [X] added new unit test(s)
- [ ] added new functional test(s)

## Potential risks
E2E timeout tests not added yet as we need complete workflow API plumbed
before we can test this.

---------

Co-authored-by: Roey Berman <[email protected]>
Co-authored-by: Dan Davison <[email protected]>
Co-authored-by: Roey Berman <[email protected]>
2025-12-19 11:01:46 -05:00

212 lines
6.5 KiB
Go

package backoff
import (
"context"
"math"
"time"
commonpb "go.temporal.io/api/common/v1"
"go.temporal.io/api/serviceerror"
"go.temporal.io/server/common/clock"
"google.golang.org/protobuf/types/known/durationpb"
)
const (
throttleRetryInitialInterval = time.Second
throttleRetryMaxInterval = 10 * time.Second
throttleRetryExpirationInterval = NoInterval
)
var (
throttleRetryPolicy = NewExponentialRetryPolicy(throttleRetryInitialInterval).
WithMaximumInterval(throttleRetryMaxInterval).
WithExpirationInterval(throttleRetryExpirationInterval)
)
type (
// Operation to retry
Operation func() error
// OperationCtx plays the same role as Operation but for context-aware
// retryable functions.
OperationCtx func(context.Context) error
// IsRetryable handler can be used to exclude certain errors during retry
IsRetryable func(error) bool
)
// ThrottleRetry is a resource aware version of Retry.
// Resource exhausted error will be retried using a different throttle retry policy, instead of the specified one.
func ThrottleRetry(operation Operation, policy RetryPolicy, isRetryable IsRetryable) error {
ctxOp := func(context.Context) error { return operation() }
return ThrottleRetryContext(context.Background(), ctxOp, policy, isRetryable)
}
// ThrottleRetryContext is a context and resource aware version of Retry.
// Context timeout/cancellation errors are never retried, regardless of IsRetryable.
// Resource exhausted error will be retried using a different throttle retry policy, instead of the specified one.
// TODO: allow customizing throttle retry policy and what kind of error are categorized as throttle error.
func ThrottleRetryContext(
ctx context.Context,
operation OperationCtx,
policy RetryPolicy,
isRetryable IsRetryable,
) error {
var err error
var next time.Duration
if isRetryable == nil {
isRetryable = func(error) bool { return true }
}
deadline, hasDeadline := ctx.Deadline()
timeSrc := clock.NewRealTimeSource()
r := NewRetrier(policy, timeSrc)
t := NewRetrier(throttleRetryPolicy, timeSrc)
for ctx.Err() == nil {
if err = operation(ctx); err == nil {
return nil
}
if next = r.NextBackOff(err); next == done {
return err
}
if err == ctx.Err() || !isRetryable(err) {
return err
}
if _, ok := err.(*serviceerror.ResourceExhausted); ok {
next = max(next, t.NextBackOff(err))
}
if hasDeadline && timeSrc.Now().Add(next).After(deadline) {
break
}
timer := time.NewTimer(next)
select {
case <-timer.C:
case <-ctx.Done():
timer.Stop()
}
}
// always return the last error we got from operation, even if it is not useful
// this retry utility does not have enough information to do any filtering/mapping
if err != nil {
return err
}
return ctx.Err()
}
// ThrottleRetryContextWithReturn is a context and resource aware version of Retry.
// Context timeout/cancellation errors are never retried, regardless of IsRetryable.
// Resource exhausted error will be retried using a different throttle retry policy, instead of the specified one.
// TODO: allow customizing throttle retry policy and what kind of error are categorized as throttle error.
func ThrottleRetryContextWithReturn[T any](
ctx context.Context,
fn func(context.Context) (T, error),
policy RetryPolicy,
isRetryable IsRetryable,
) (T, error) {
var zero T
var err error
var next time.Duration
if isRetryable == nil {
isRetryable = func(error) bool { return true }
}
deadline, hasDeadline := ctx.Deadline()
timeSrc := clock.NewRealTimeSource()
r := NewRetrier(policy, timeSrc)
t := NewRetrier(throttleRetryPolicy, timeSrc)
for ctx.Err() == nil {
result, err := fn(ctx)
if err == nil {
return result, nil
}
if next = r.NextBackOff(err); next == done {
return zero, err
}
if err == ctx.Err() || !isRetryable(err) {
return zero, err
}
if _, ok := err.(*serviceerror.ResourceExhausted); ok {
next = max(next, t.NextBackOff(err))
}
if hasDeadline && timeSrc.Now().Add(next).After(deadline) {
break
}
timer := time.NewTimer(next)
select {
case <-timer.C:
case <-ctx.Done():
timer.Stop()
}
}
// always return the last error we got from operation, even if it is not useful
// this retry utility does not have enough information to do any filtering/mapping
if err != nil {
return zero, err
}
return zero, ctx.Err()
}
// IgnoreErrors can be used as IsRetryable handler for Retry function to exclude certain errors from the retry list
func IgnoreErrors(errorsToExclude []error) func(error) bool {
return func(err error) bool {
for _, errorToExclude := range errorsToExclude {
if err == errorToExclude {
return false
}
}
return true
}
}
// BackoffCalculatorAlgorithmFunc is a function type that calculates backoff duration based on
// initial duration, coefficient, and current attempt number.
type BackoffCalculatorAlgorithmFunc func(duration *durationpb.Duration, coefficient float64, currentAttempt int32) time.Duration
// ExponentialBackoffAlgorithm calculates the backoff duration using exponential algorithm.
// The result is initInterval * (backoffCoefficient ^ (currentAttempt - 1)).
// If the calculation overflows int64, it returns the maximum possible duration. A negative result will also never be returned.
func ExponentialBackoffAlgorithm(initInterval *durationpb.Duration, backoffCoefficient float64, currentAttempt int32) time.Duration {
result := float64(initInterval.AsDuration().Nanoseconds()) * math.Pow(backoffCoefficient, float64(currentAttempt-1))
return time.Duration(max(0, min(int64(result), math.MaxInt64)))
}
// MakeBackoffAlgorithm creates a BackoffCalculatorAlgorithmFunc that returns a fixed delay if requestedDelay is non-nil,
// otherwise falls back to exponential backoff algorithm.
func MakeBackoffAlgorithm(requestedDelay *time.Duration) BackoffCalculatorAlgorithmFunc {
return func(duration *durationpb.Duration, coefficient float64, currentAttempt int32) time.Duration {
if requestedDelay != nil {
return *requestedDelay
}
return ExponentialBackoffAlgorithm(duration, coefficient, currentAttempt)
}
}
// CalculateExponentialRetryInterval calculates the retry interval using exponential backoff algorithm
func CalculateExponentialRetryInterval(retryPolicy *commonpb.RetryPolicy, attempt int32) time.Duration {
interval := ExponentialBackoffAlgorithm(retryPolicy.GetInitialInterval(), retryPolicy.GetBackoffCoefficient(), attempt)
maxInterval := retryPolicy.GetMaximumInterval()
// Cap interval to maximum if it's set
if maxInterval.AsDuration() != 0 && interval > maxInterval.AsDuration() {
interval = maxInterval.AsDuration()
}
return interval
}