mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
David ReissandGitHub
c7c27e5ab1
## What changed? Use unique.Handle for dynamicconfig.Keys instead of strings. ## Why? Force keys to always be lowercase so we don't have to convert at lookup time, and also speed up lookups by interning. ## How did you test it? - [x] covered by existing tests
124 lines
3.6 KiB
Go
124 lines
3.6 KiB
Go
package dynamicconfig
|
|
|
|
import (
|
|
"fmt"
|
|
"reflect"
|
|
"strings"
|
|
|
|
enumspb "go.temporal.io/api/enums/v1"
|
|
enumsspb "go.temporal.io/server/api/enums/v1"
|
|
"go.temporal.io/server/common/log"
|
|
)
|
|
|
|
// DiffAndLogConfigs computes the difference between two ConfigValueMaps. The result is
|
|
// returned as a ConfigValueMap that can be merged with old to produce new, except with deleted
|
|
// keys mapped to nil. It also logs the differences to a logger.
|
|
func DiffAndLogConfigs(logger log.Logger, oldValues ConfigValueMap, newValues ConfigValueMap) ConfigValueMap {
|
|
changedMap := make(map[Key][]ConstrainedValue)
|
|
|
|
for key, newValues := range newValues {
|
|
oldValues, ok := oldValues[key]
|
|
if !ok {
|
|
for _, newValue := range newValues {
|
|
// new key added
|
|
diffAndLogValue(logger, key, nil, &newValue)
|
|
}
|
|
changedMap[Key(key)] = newValues
|
|
} else {
|
|
// compare existing keys
|
|
changed := diffAndLogConstraints(logger, key, oldValues, newValues)
|
|
if changed {
|
|
changedMap[Key(key)] = newValues
|
|
}
|
|
}
|
|
}
|
|
|
|
// check for removed values
|
|
for key, oldValues := range oldValues {
|
|
if _, ok := newValues[key]; !ok {
|
|
for _, oldValue := range oldValues {
|
|
diffAndLogValue(logger, key, &oldValue, nil)
|
|
}
|
|
changedMap[Key(key)] = nil
|
|
}
|
|
}
|
|
|
|
return changedMap
|
|
}
|
|
|
|
func diffAndLogConstraints(logger log.Logger, key Key, oldValues []ConstrainedValue, newValues []ConstrainedValue) bool {
|
|
changed := false
|
|
for _, oldValue := range oldValues {
|
|
matchFound := false
|
|
for _, newValue := range newValues {
|
|
if oldValue.Constraints == newValue.Constraints {
|
|
matchFound = true
|
|
if !reflect.DeepEqual(oldValue.Value, newValue.Value) {
|
|
diffAndLogValue(logger, key, &oldValue, &newValue)
|
|
changed = true
|
|
}
|
|
}
|
|
}
|
|
if !matchFound {
|
|
diffAndLogValue(logger, key, &oldValue, nil)
|
|
changed = true
|
|
}
|
|
}
|
|
|
|
for _, newValue := range newValues {
|
|
matchFound := false
|
|
for _, oldValue := range oldValues {
|
|
if oldValue.Constraints == newValue.Constraints {
|
|
matchFound = true
|
|
}
|
|
}
|
|
if !matchFound {
|
|
diffAndLogValue(logger, key, nil, &newValue)
|
|
changed = true
|
|
}
|
|
}
|
|
return changed
|
|
}
|
|
|
|
func diffAndLogValue(logger log.Logger, key Key, oldValue *ConstrainedValue, newValue *ConstrainedValue) {
|
|
logLine := &strings.Builder{}
|
|
logLine.Grow(128)
|
|
logLine.WriteString("dynamic config changed for the key: ")
|
|
logLine.WriteString(key.String())
|
|
logLine.WriteString(" oldValue: ")
|
|
appendConstrainedValue(logLine, oldValue)
|
|
logLine.WriteString(" newValue: ")
|
|
appendConstrainedValue(logLine, newValue)
|
|
logger.Info(logLine.String())
|
|
}
|
|
|
|
func appendConstrainedValue(logLine *strings.Builder, value *ConstrainedValue) {
|
|
if value == nil {
|
|
logLine.WriteString("nil")
|
|
} else {
|
|
logLine.WriteString("{ constraints: {")
|
|
if value.Constraints.Namespace != "" {
|
|
fmt.Fprintf(logLine, "{Namespace:%s}", value.Constraints.Namespace)
|
|
}
|
|
if value.Constraints.NamespaceID != "" {
|
|
fmt.Fprintf(logLine, "{NamespaceID:%s}", value.Constraints.NamespaceID)
|
|
}
|
|
if value.Constraints.TaskQueueName != "" {
|
|
fmt.Fprintf(logLine, "{TaskQueueName:%s}", value.Constraints.TaskQueueName)
|
|
}
|
|
if value.Constraints.TaskQueueType != enumspb.TASK_QUEUE_TYPE_UNSPECIFIED {
|
|
fmt.Fprintf(logLine, "{TaskQueueType:%s}", value.Constraints.TaskQueueType)
|
|
}
|
|
if value.Constraints.ShardID != 0 {
|
|
fmt.Fprintf(logLine, "{ShardID:%d}", value.Constraints.ShardID)
|
|
}
|
|
if value.Constraints.TaskType != enumsspb.TASK_TYPE_UNSPECIFIED {
|
|
fmt.Fprintf(logLine, "{HistoryTaskType:%s}", value.Constraints.TaskType)
|
|
}
|
|
if value.Constraints.Destination != "" {
|
|
fmt.Fprintf(logLine, "{Destination:%s}", value.Constraints.Destination)
|
|
}
|
|
fmt.Fprint(logLine, "} value: ", value.Value, " }")
|
|
}
|
|
}
|