Files
Stephan BehnkeandGitHub 7b27b31645 Unify DataBlob encoding/decoding (#8111)
## What changed?

Cleanup of `common/serialization` package:

- unify several DataBlob encode/decode functions into 3 functions (see
new codec.go)
- unify function signatures to use `DataBlob` everywhere (instead of
split []byte + EncodingType)

## Why?

- less code
- simpler
- consistent
- preparation step to allow changing proto to json encoding via env
variable for debugging purposes
  
## How did you test it?
- [ ] built
- [ ] run locally and tested manually
- [x] covered by existing tests
- [ ] added new unit test(s)
- [ ] added new functional test(s)

## Potential Risks

See the two callouts for behavior difference.
2025-08-07 17:25:29 +00:00

286 lines
7.9 KiB
Go

package cassandra
import (
"encoding/json"
"fmt"
"math"
"reflect"
"sort"
persistencespb "go.temporal.io/server/api/persistence/v1"
p "go.temporal.io/server/common/persistence"
"go.temporal.io/server/common/persistence/nosql/nosqlplugin/cassandra/gocql"
"go.temporal.io/server/common/persistence/serialization"
"go.temporal.io/server/common/primitives/timestamp"
)
var (
errorPriority = map[reflect.Type]int{
reflect.TypeOf(&p.ShardOwnershipLostError{}): 0,
reflect.TypeOf(&p.CurrentWorkflowConditionFailedError{}): 1,
reflect.TypeOf(&p.WorkflowConditionFailedError{}): 2,
reflect.TypeOf(&p.ConditionFailedError{}): 3,
}
errorDefaultPriority = math.MaxInt64
)
type (
executionCASCondition struct {
runID string
dbVersion int64
nextEventID int64 // TODO deprecate this variable once DB version comparison is the default
}
)
// ScyllaDB will return rows with null values to match # of queries in a batch query (see #2683).
// To support null values, fields type should be a pointer to pointer of underlying type (i.e. **int).
// Resulting value will be converted to a pointer of underlying type (i.e. *int) and stored in the map.
// We do it only for "type" field which is checked for `nil` value.
// All other fields are created automatically by gocql with non-pointer types (i.e. int).
func newConflictRecord() map[string]interface{} {
t := new(int)
return map[string]interface{}{
"type": &t,
}
}
func convertErrors(
conflictRecord map[string]interface{},
conflictIter gocql.Iter,
requestShardID int32,
requestRangeID int64,
requestCurrentRunID string,
requestExecutionCASConditions []executionCASCondition,
) error {
conflictRecords := []map[string]interface{}{conflictRecord}
errors := extractErrors(
conflictRecord,
requestShardID,
requestRangeID,
requestCurrentRunID,
requestExecutionCASConditions,
)
conflictRecord = newConflictRecord()
for conflictIter.MapScan(conflictRecord) {
if conflictRecord["[applied]"].(bool) {
// Should never happen. All records in batch should have [applied]=false.
continue
}
conflictRecords = append(conflictRecords, conflictRecord)
errors = append(errors, extractErrors(
conflictRecord,
requestShardID,
requestRangeID,
requestCurrentRunID,
requestExecutionCASConditions,
)...)
conflictRecord = newConflictRecord()
}
if len(errors) == 0 {
// This means that extractErrors wasn't able to extract error from the conflicting records.
// Most likely record to update is not found in the DB by WHERE clause and is NOT in conflictRecords slice.
// Unfortunately, there is no way to get the missing record w/o extra call to DB.
// Most likely it is current workflow execution record.
return &p.ConditionFailedError{
Msg: fmt.Sprintf("Encounter unknown condition update error: shard ID: %v, range ID: %v, possibly conflicting records:%v",
requestShardID,
requestRangeID,
printRecords(conflictRecords),
),
}
}
errors = sortErrors(errors)
return errors[0]
}
func extractErrors(
conflictRecord map[string]interface{},
requestShardID int32,
requestRangeID int64,
requestCurrentRunID string,
requestExecutionCASConditions []executionCASCondition,
) []error {
var errors []error
if err := extractShardOwnershipLostError(
conflictRecord,
requestShardID,
requestRangeID,
); err != nil {
errors = append(errors, err)
}
if err := extractCurrentWorkflowConflictError(
conflictRecord,
requestCurrentRunID,
); err != nil {
errors = append(errors, err)
}
for _, condition := range requestExecutionCASConditions {
if err := extractWorkflowConflictError(
conflictRecord,
condition.runID,
condition.dbVersion,
condition.nextEventID,
); err != nil {
errors = append(errors, err)
}
}
return errors
}
func sortErrors(
errors []error,
) []error {
sort.Slice(errors, func(i int, j int) bool {
leftPriority, ok := errorPriority[reflect.TypeOf(errors[i])]
if !ok {
leftPriority = errorDefaultPriority
}
rightPriority, ok := errorPriority[reflect.TypeOf(errors[j])]
if !ok {
rightPriority = errorDefaultPriority
}
return leftPriority < rightPriority
})
return errors
}
func extractShardOwnershipLostError(
conflictRecord map[string]interface{},
requestShardID int32,
requestRangeID int64,
) error {
rowType, ok := conflictRecord["type"].(*int)
if !ok || rowType == nil {
// This can happen on ScyllaDB.
return nil
}
if *rowType != rowTypeShard {
return nil
}
actualRangeID := conflictRecord["range_id"].(int64)
if actualRangeID != requestRangeID {
return &p.ShardOwnershipLostError{
ShardID: requestShardID,
Msg: fmt.Sprintf("Encounter shard ownership lost, request range ID: %v, actual range ID: %v",
requestRangeID,
actualRangeID,
),
}
}
return nil
}
func extractCurrentWorkflowConflictError(
conflictRecord map[string]interface{},
requestCurrentRunID string,
) error {
rowType, ok := conflictRecord["type"].(*int)
if !ok || rowType == nil {
// This can happen on ScyllaDB.
return nil
}
if *rowType != rowTypeExecution {
return nil
}
if runID := gocql.UUIDToString(conflictRecord["run_id"]); runID != permanentRunID {
return nil
}
actualCurrentRunID := gocql.UUIDToString(conflictRecord["current_run_id"])
if actualCurrentRunID != requestCurrentRunID {
binary, _ := conflictRecord["execution_state"].([]byte)
encoding, _ := conflictRecord["execution_state_encoding"].(string)
executionState := &persistencespb.WorkflowExecutionState{}
if state, err := serialization.WorkflowExecutionStateFromBlob(p.NewDataBlob(binary, encoding)); err == nil {
executionState = state
}
// if err != nil, this means execution state cannot be parsed, just use default values
lastWriteVersion, _ := conflictRecord["workflow_last_write_version"].(int64)
// TODO maybe assert actualCurrentRunID == executionState.RunId ?
return &p.CurrentWorkflowConditionFailedError{
Msg: fmt.Sprintf("Encounter current workflow error, request run ID: %v, actual run ID: %v",
requestCurrentRunID,
actualCurrentRunID,
),
RequestIDs: executionState.RequestIds,
RunID: executionState.RunId,
State: executionState.State,
Status: executionState.Status,
LastWriteVersion: lastWriteVersion,
StartTime: timestamp.TimeValuePtr(executionState.StartTime),
}
}
return nil
}
func extractWorkflowConflictError(
conflictRecord map[string]interface{},
requestRunID string,
requestDBVersion int64,
requestNextEventID int64, // TODO deprecate this variable once DB version comparison is the default
) error {
rowType, ok := conflictRecord["type"].(*int)
if !ok || rowType == nil {
// This can happen on ScyllaDB.
return nil
}
if *rowType != rowTypeExecution {
return nil
}
if runID := gocql.UUIDToString(conflictRecord["run_id"]); runID != requestRunID {
return nil
}
actualNextEventID, _ := conflictRecord["next_event_id"].(int64)
actualDBVersion, _ := conflictRecord["db_record_version"].(int64)
// TODO remove this block once DB version comparison is the default
if requestDBVersion == 0 {
if actualNextEventID != requestNextEventID {
return &p.WorkflowConditionFailedError{
Msg: fmt.Sprintf("Encounter workflow next event ID mismatch, request next event ID: %v, actual next event ID: %v",
requestNextEventID,
actualNextEventID,
),
NextEventID: actualNextEventID,
DBRecordVersion: actualDBVersion,
}
}
return nil
}
if actualDBVersion != requestDBVersion {
return &p.WorkflowConditionFailedError{
Msg: fmt.Sprintf("Encounter workflow db version mismatch, request db version: %v, actual db version: %v",
requestDBVersion,
actualDBVersion,
),
NextEventID: actualNextEventID,
DBRecordVersion: actualDBVersion,
}
}
return nil
}
func printRecords(
records []map[string]interface{},
) string {
binary, _ := json.MarshalIndent(records, "", " ")
return string(binary)
}