Files
tasks/common/persistence/history_node_util_test.go
Roey BermanandGitHub 243effc6e1 Forbid the use of pborman/uuid and remove uses (#8541)
## What

Used the `depguard` linter to prevent importing the package and modified
all uses of it.

Also fixed a bug in the membership code where we were not updating the
next page token:

https://github.com/temporalio/temporal/pull/8541/files#diff-985dd64ffa4c6bfe0248b982dc47439b725862baa3e1f2c559b7ff522bf21969R350


## Why?

From the package README in GitHub:

> This package now leverages the github.com/google/uuid package (which
is based off an earlier version of this package).

Also, there's no point in having two uuid implementations in the
codebase.

## Test

Added the invalid import and confirmed it works:

```
../service/frontend/admin_handler_test.go:13:2: import 'github.com/pborman/uuid' is not allowed from list 'main': Importing github.com/pborman/uuid is disallowed; use github.com/google/uuid instead (depguard)
        _ "github.com/pborman/uuid"

```
2025-11-26 01:33:02 +00:00

160 lines
5.2 KiB
Go

package persistence
import (
"math/rand"
"testing"
"github.com/google/uuid"
"github.com/stretchr/testify/require"
"github.com/stretchr/testify/suite"
persistencespb "go.temporal.io/server/api/persistence/v1"
"go.temporal.io/server/common"
)
type (
historyNodeMetadataSuite struct {
suite.Suite
*require.Assertions
}
)
func TestHistoryNodeMetadataSuite(t *testing.T) {
s := new(historyNodeMetadataSuite)
suite.Run(t, s)
}
func (s *historyNodeMetadataSuite) SetupSuite() {
}
func (s *historyNodeMetadataSuite) TearDownSuite() {
}
func (s *historyNodeMetadataSuite) SetupTest() {
s.Assertions = require.New(s.T())
}
func (s *historyNodeMetadataSuite) TearDownTest() {
}
func (s *historyNodeMetadataSuite) TestIndexNodeIDToNode() {
branch := &persistencespb.HistoryBranch{
TreeId: uuid.NewString(),
BranchId: uuid.NewString(),
}
numNodeIDs := 10
nodePerNodeID := 10
prevTransactionID := int64(0)
transactionIDToNode := map[int64]historyNodeMetadata{}
for nodeID := common.FirstEventID; nodeID < int64(numNodeIDs+1); nodeID++ {
var nextTransactionID *int64
for i := 0; i < nodePerNodeID; i++ {
transactionID := rand.Int63()
if nextTransactionID == nil || *nextTransactionID < transactionID {
nextTransactionID = &transactionID
}
node := s.newRandomHistoryNodeMetadata(branch, nodeID, transactionID, prevTransactionID)
transactionIDToNode[node.transactionID] = node
}
prevTransactionID = *nextTransactionID
}
nodeIDToNode := indexNodeIDToNode(transactionIDToNode)
for nodeID := common.FirstEventID; nodeID < int64(numNodeIDs+1); nodeID++ {
nodes := nodeIDToNode[int64(nodeID)]
for i := 1; i < nodePerNodeID; i++ {
s.True(nodes[i-1].transactionID >= nodes[i].transactionID)
}
}
}
func (s *historyNodeMetadataSuite) TestReverselyLinkNode() {
branch := &persistencespb.HistoryBranch{
TreeId: uuid.NewString(),
BranchId: uuid.NewString(),
}
numNodeIDs := 10
nodePerNodeID := 10
var expectedNodes []historyNodeMetadata
prevTransactionID := int64(0)
transactionIDToNode := map[int64]historyNodeMetadata{}
for nodeID := common.FirstEventID; nodeID < int64(numNodeIDs+1); nodeID++ {
var nextTransactionID *int64
for i := 0; i < nodePerNodeID; i++ {
transactionID := rand.Int63()
if nextTransactionID == nil || *nextTransactionID < transactionID {
nextTransactionID = &transactionID
}
node := s.newRandomHistoryNodeMetadata(branch, nodeID, transactionID, prevTransactionID)
transactionIDToNode[node.transactionID] = node
}
prevTransactionID = *nextTransactionID
expectedNodes = append([]historyNodeMetadata{transactionIDToNode[prevTransactionID]}, expectedNodes...)
}
lastValidNode := s.newRandomHistoryNodeMetadata(branch, int64(numNodeIDs+1), rand.Int63(), prevTransactionID)
transactionIDToNode[lastValidNode.transactionID] = lastValidNode
expectedNodes = append([]historyNodeMetadata{lastValidNode}, expectedNodes...)
nodes, err := reverselyLinkNode(lastValidNode.nodeID, lastValidNode.transactionID, transactionIDToNode)
s.NoError(err)
s.Equal(expectedNodes, nodes)
}
func (s *historyNodeMetadataSuite) TestTrimNodes() {
branch := &persistencespb.HistoryBranch{
TreeId: uuid.NewString(),
BranchId: uuid.NewString(),
}
node1Valid := s.newRandomHistoryNodeMetadata(branch, 1, rand.Int63(), 0)
node1Stale0 := s.newRandomHistoryNodeMetadata(branch, 1, node1Valid.transactionID-11, 0)
node1Stale1 := s.newRandomHistoryNodeMetadata(branch, 1, node1Valid.transactionID-22, 0)
node1Trim0 := s.newRandomHistoryNodeMetadata(branch, 1, node1Valid.transactionID+33, 0)
node1Trim1 := s.newRandomHistoryNodeMetadata(branch, 1, node1Valid.transactionID+44, 0)
// reverse sort by transaction ID
node1s := []historyNodeMetadata{node1Trim1, node1Trim0, node1Valid, node1Stale0, node1Stale1}
node2Valid := s.newRandomHistoryNodeMetadata(branch, 2, rand.Int63(), 0)
// reverse sort by transaction ID
node2s := []historyNodeMetadata{node2Valid}
node3Valid := s.newRandomHistoryNodeMetadata(branch, 3, rand.Int63(), 0)
node3Stale0 := s.newRandomHistoryNodeMetadata(branch, 3, node3Valid.transactionID-100, 0)
node3Stale1 := s.newRandomHistoryNodeMetadata(branch, 3, node3Valid.transactionID-200, 0)
// reverse sort by transaction ID
node3s := []historyNodeMetadata{node3Valid, node3Stale0, node3Stale1}
node4Valid := s.newRandomHistoryNodeMetadata(branch, 4, rand.Int63(), 0)
node4Trim0 := s.newRandomHistoryNodeMetadata(branch, 4, node4Valid.transactionID+1024, 0)
node4Trim1 := s.newRandomHistoryNodeMetadata(branch, 4, node4Valid.transactionID+2048, 0)
// reverse sort by transaction ID
node4s := []historyNodeMetadata{node4Trim1, node4Trim0, node4Valid}
nodeIDToNodes := map[int64][]historyNodeMetadata{
1: node1s,
2: node2s,
3: node3s,
4: node4s,
}
nodesToTrim := trimNodes(nodeIDToNodes, []historyNodeMetadata{node4Valid, node3Valid, node2Valid, node1Valid})
s.Equal([]historyNodeMetadata{node4Trim1, node4Trim0, node1Trim1, node1Trim0}, nodesToTrim)
}
func (s *historyNodeMetadataSuite) newRandomHistoryNodeMetadata(
branch *persistencespb.HistoryBranch,
nodeID int64,
transactionID int64,
prevTransactionID int64,
) historyNodeMetadata {
return historyNodeMetadata{
branchInfo: branch,
nodeID: nodeID,
transactionID: transactionID,
prevTransactionID: prevTransactionID,
}
}