mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
## What changed? This PR aims to avoid usage of [`strings.Split`](https://pkg.go.dev/strings#Split) where possible in favor of better string splitting techniques, speficially: [`strings.SplitN`](https://pkg.go.dev/strings#SplitN) and [`strings.SplitSeq`](https://pkg.go.dev/strings#SplitSeq) where appropriate. There was also a [`strings.Fields`](https://pkg.go.dev/strings#Fields) change I made to use [`strings.FieldsSeq`](https://pkg.go.dev/strings#FieldsSeq) instead, and another for S3 to use the [`path`](https://pkg.go.dev/path) package instead of [`strings.Split`](https://pkg.go.dev/strings#Split). ## Why? [`strings.SplitN`](https://pkg.go.dev/strings#SplitN) and [`strings.SplitSeq`](https://pkg.go.dev/strings#SplitSeq) are often better options in many cases, and can be _partially_ detected using [`modernize`](https://pkg.go.dev/golang.org/x/tools/gopls/internal/analysis/modernize): > `stringsseq`: replace Split in "for range strings.Split(...)" by go1.24's more efficient `SplitSeq`, or `Fields` with `FieldSeq`. ## How did you test it? - [X] built - [X] run locally and tested manually - [x] covered by existing tests - [x] added new unit test(s) - [ ] added new functional test(s) ## Potential risks There are lots of potentially subtle behaviors from the `strings.Split` (and `strings.Fields`) usage that should be accounted for. If our existing tests don't cover those subtleties, there's risk for introducing an unintended bug. More intricate handling/parsing previously using the `strings` package should get extra attention from reviewers. I've attempted to break up my changes into logical commit chunks to aid in review / help spot potentially concerning changes.
261 lines
8.5 KiB
Go
261 lines
8.5 KiB
Go
package persistence
|
|
|
|
import (
|
|
"context"
|
|
"crypto/sha256"
|
|
"encoding/base64"
|
|
"errors"
|
|
"fmt"
|
|
"strconv"
|
|
"strings"
|
|
|
|
commonpb "go.temporal.io/api/common/v1"
|
|
enumspb "go.temporal.io/api/enums/v1"
|
|
persistencespb "go.temporal.io/server/api/persistence/v1"
|
|
"go.temporal.io/server/common/persistence/serialization"
|
|
)
|
|
|
|
const (
|
|
// clusterNamesHashSuffixLength is the number of characters to use from the hash of the cluster names when forming
|
|
// the queue name. This is used to avoid name collisions when a cluster name contains the separator character.
|
|
clusterNamesHashSuffixLength = 8
|
|
|
|
ErrMsgSerializeTaskToEnqueue = "failed to serialize history task for task queue"
|
|
// ErrMsgDeserializeRawHistoryTask is returned when the raw task cannot be deserialized from the task queue. This error
|
|
// is returned when this whole top-level proto cannot be deserialized.
|
|
// Raw Task (a proto): <-- when this cannot be deserialized
|
|
// - ShardID
|
|
// - Blob (a serialized task)
|
|
ErrMsgDeserializeRawHistoryTask = "failed to deserialize raw history task from task queue"
|
|
// ErrMsgDeserializeHistoryTask is returned when the history task cannot be deserialized from the task queue. This
|
|
// error is returned when the blob inside the raw task cannot be deserialized.
|
|
// Raw Task (a proto):
|
|
// - ShardID
|
|
// - Blob (a serialized task) <-- when this cannot be deserialized
|
|
ErrMsgDeserializeHistoryTask = "failed to deserialize history task blob"
|
|
// ErrMsgFailedToParseCategoryID is returned when category id cannot be parsed as an integer value.
|
|
ErrMsgFailedToParseCategoryID = "failed to parse category id from queue name"
|
|
)
|
|
|
|
var (
|
|
ErrReadTasksNonPositivePageSize = errors.New("page size to read history tasks must be positive")
|
|
ErrHistoryTaskBlobIsNil = errors.New("history task from queue has nil blob")
|
|
ErrEnqueueTaskRequestTaskIsNil = errors.New("enqueue task request task is nil")
|
|
ErrQueueAlreadyExists = errors.New("queue already exists")
|
|
ErrShardIDInvalid = errors.New("shard ID must be greater than 0")
|
|
ErrInvalidQueueName = errors.New("invalid queue name, expected 4 fields")
|
|
)
|
|
|
|
func NewHistoryTaskQueueManager(queue QueueV2, serializer serialization.Serializer) *HistoryTaskQueueManagerImpl {
|
|
return &HistoryTaskQueueManagerImpl{
|
|
queue: queue,
|
|
serializer: serializer,
|
|
}
|
|
}
|
|
|
|
func (m *HistoryTaskQueueManagerImpl) EnqueueTask(
|
|
ctx context.Context,
|
|
request *EnqueueTaskRequest,
|
|
) (*EnqueueTaskResponse, error) {
|
|
if request.Task == nil {
|
|
return nil, ErrEnqueueTaskRequestTaskIsNil
|
|
}
|
|
blob, err := m.serializer.SerializeTask(request.Task)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("%v: %w", ErrMsgSerializeTaskToEnqueue, err)
|
|
}
|
|
if request.SourceShardID <= 0 {
|
|
return nil, fmt.Errorf("%w: shardID = %d", ErrShardIDInvalid, request.SourceShardID)
|
|
}
|
|
|
|
taskCategory := request.Task.GetCategory()
|
|
task := persistencespb.HistoryTask{
|
|
ShardId: int32(request.SourceShardID),
|
|
Blob: blob,
|
|
}
|
|
taskBytes, _ := task.Marshal()
|
|
blob = &commonpb.DataBlob{
|
|
EncodingType: enumspb.ENCODING_TYPE_PROTO3,
|
|
Data: taskBytes,
|
|
}
|
|
queueKey := QueueKey{
|
|
QueueType: request.QueueType,
|
|
Category: taskCategory,
|
|
SourceCluster: request.SourceCluster,
|
|
TargetCluster: request.TargetCluster,
|
|
}
|
|
|
|
message, err := m.queue.EnqueueMessage(ctx, &InternalEnqueueMessageRequest{
|
|
QueueType: request.QueueType,
|
|
QueueName: queueKey.GetQueueName(),
|
|
Blob: blob,
|
|
})
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return &EnqueueTaskResponse{
|
|
Metadata: message.Metadata,
|
|
}, nil
|
|
}
|
|
|
|
// ReadRawTasks returns a page of "raw" tasks from the queue. Here's a quick disambiguation of the different types of
|
|
// tasks:
|
|
//
|
|
// - [go.temporal.io/server/api/history/v1.Task]: the proto that is serialized and stored in the database which
|
|
// contains a shard ID and a blob of the serialized history task. This is also called a "raw" task.
|
|
// - [go.temporal.io/server/service/history/tasks.Task]: the interface that is implemented by all history tasks.
|
|
// This is the primary type used in code to represent a history task since it is the most structured.
|
|
func (m *HistoryTaskQueueManagerImpl) ReadRawTasks(
|
|
ctx context.Context,
|
|
request *ReadRawTasksRequest,
|
|
) (*ReadRawTasksResponse, error) {
|
|
if request.PageSize <= 0 {
|
|
return nil, fmt.Errorf("%w: %v", ErrReadTasksNonPositivePageSize, request.PageSize)
|
|
}
|
|
|
|
response, err := m.queue.ReadMessages(ctx, &InternalReadMessagesRequest{
|
|
QueueType: request.QueueKey.QueueType,
|
|
QueueName: request.QueueKey.GetQueueName(),
|
|
PageSize: request.PageSize,
|
|
NextPageToken: request.NextPageToken,
|
|
})
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
responseTasks := make([]RawHistoryTask, len(response.Messages))
|
|
for i, message := range response.Messages {
|
|
var task persistencespb.HistoryTask
|
|
err := serialization.Decode(message.Data, &task)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("%v: %w", ErrMsgDeserializeRawHistoryTask, err)
|
|
}
|
|
responseTasks[i].MessageMetadata = message.MetaData
|
|
responseTasks[i].Payload = &task
|
|
}
|
|
|
|
return &ReadRawTasksResponse{
|
|
Tasks: responseTasks,
|
|
NextPageToken: response.NextPageToken,
|
|
}, nil
|
|
}
|
|
|
|
// ReadTasks is a convenience method on top of ReadRawTasks that deserializes the tasks into the [tasks.Task] type.
|
|
func (m *HistoryTaskQueueManagerImpl) ReadTasks(ctx context.Context, request *ReadTasksRequest) (*ReadTasksResponse, error) {
|
|
response, err := m.ReadRawTasks(ctx, request)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
resTasks := make([]HistoryTask, len(response.Tasks))
|
|
|
|
for i, rawTask := range response.Tasks {
|
|
blob := rawTask.Payload.Blob
|
|
if blob == nil {
|
|
return nil, serialization.NewDeserializationError(enumspb.ENCODING_TYPE_PROTO3, ErrHistoryTaskBlobIsNil)
|
|
}
|
|
|
|
task, err := m.serializer.DeserializeTask(request.QueueKey.Category, blob)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("%v: %w", ErrMsgDeserializeHistoryTask, err)
|
|
}
|
|
|
|
resTasks[i] = HistoryTask{
|
|
MessageMetadata: rawTask.MessageMetadata,
|
|
Task: task,
|
|
}
|
|
}
|
|
|
|
return &ReadTasksResponse{
|
|
Tasks: resTasks,
|
|
NextPageToken: response.NextPageToken,
|
|
}, nil
|
|
}
|
|
|
|
func (m *HistoryTaskQueueManagerImpl) CreateQueue(
|
|
ctx context.Context,
|
|
request *CreateQueueRequest,
|
|
) (*CreateQueueResponse, error) {
|
|
_, err := m.queue.CreateQueue(ctx, &InternalCreateQueueRequest{
|
|
QueueType: request.QueueKey.QueueType,
|
|
QueueName: request.QueueKey.GetQueueName(),
|
|
})
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return &CreateQueueResponse{}, nil
|
|
}
|
|
|
|
func (m *HistoryTaskQueueManagerImpl) DeleteTasks(
|
|
ctx context.Context,
|
|
request *DeleteTasksRequest,
|
|
) (*DeleteTasksResponse, error) {
|
|
resp, err := m.queue.RangeDeleteMessages(ctx, &InternalRangeDeleteMessagesRequest{
|
|
QueueType: request.QueueKey.QueueType,
|
|
QueueName: request.QueueKey.GetQueueName(),
|
|
InclusiveMaxMessageMetadata: request.InclusiveMaxMessageMetadata,
|
|
})
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return &DeleteTasksResponse{MessagesDeleted: resp.MessagesDeleted}, nil
|
|
}
|
|
|
|
func (m HistoryTaskQueueManagerImpl) ListQueues(
|
|
ctx context.Context,
|
|
request *ListQueuesRequest,
|
|
) (*ListQueuesResponse, error) {
|
|
resp, err := m.queue.ListQueues(ctx, &InternalListQueuesRequest{
|
|
QueueType: request.QueueType,
|
|
PageSize: request.PageSize,
|
|
NextPageToken: request.NextPageToken,
|
|
})
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return &ListQueuesResponse{
|
|
Queues: resp.Queues,
|
|
NextPageToken: resp.NextPageToken,
|
|
}, nil
|
|
}
|
|
|
|
func (m HistoryTaskQueueManagerImpl) Close() {
|
|
}
|
|
|
|
// combineUnique combines the given strings into a single string by hashing the length of each string and the string
|
|
// itself. This is used to generate a unique suffix for the queue name.
|
|
func combineUnique(strs ...string) string {
|
|
h := sha256.New()
|
|
for _, str := range strs {
|
|
b := sha256.Sum256([]byte(str))
|
|
_, _ = h.Write(b[:])
|
|
}
|
|
return base64.StdEncoding.EncodeToString(h.Sum(nil))
|
|
}
|
|
|
|
func (k QueueKey) GetQueueName() string {
|
|
return GetHistoryTaskQueueName(k.Category.ID(), k.SourceCluster, k.TargetCluster)
|
|
}
|
|
|
|
func GetHistoryTaskQueueName(
|
|
categoryID int,
|
|
sourceCluster string,
|
|
targetCluster string,
|
|
) string {
|
|
hash := combineUnique(sourceCluster, targetCluster)[:clusterNamesHashSuffixLength]
|
|
return fmt.Sprintf("%d_%s_%s_%s", categoryID, sourceCluster, targetCluster, hash)
|
|
}
|
|
|
|
func GetHistoryTaskQueueCategoryID(queueName string) (int, error) {
|
|
fields := strings.SplitN(queueName, "_", 4)
|
|
if len(fields) != 4 {
|
|
return 0, fmt.Errorf("%w: %s", ErrInvalidQueueName, queueName)
|
|
}
|
|
category, err := strconv.Atoi(fields[0])
|
|
if err != nil {
|
|
return 0, fmt.Errorf("%v: %w", ErrMsgFailedToParseCategoryID, err)
|
|
}
|
|
return category, nil
|
|
}
|