mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
David ReissandGitHub
6bfd7fec0c
## What changed? Remove various utf-8 validation calls that are no longer needed. ## Why? For a long time now, all proto marshaling and unmarshaling has validated strings are valid utf-8, so all data coming in through grpc must be valid utf-8. We don't need to validate specific fields anymore. ## How did you test it? - [ ] built - [ ] run locally and tested manually - [x] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s) ## Potential risks Any data that does _not_ come through grpc, e.g. persistence, may still need to be validated. Most data in persistence is in protos so that's fine. We may want to add explicit validation for string fields around calls to gocql, for example, which doesn't appear to validate strings for utf-8.
147 lines
4.5 KiB
Go
147 lines
4.5 KiB
Go
package tqid
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
enumspb "go.temporal.io/api/enums/v1"
|
|
taskqueuepb "go.temporal.io/api/taskqueue/v1"
|
|
)
|
|
|
|
func TestNormalizeAndValidate(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
taskQueue *taskqueuepb.TaskQueue
|
|
defaultVal string
|
|
maxIDLengthLimit int
|
|
expectedError string
|
|
expectedKind enumspb.TaskQueueKind
|
|
validAsPartition bool
|
|
}{
|
|
{
|
|
name: "Nil task queue",
|
|
taskQueue: nil,
|
|
defaultVal: "default",
|
|
maxIDLengthLimit: 100,
|
|
expectedError: "taskQueue is not set",
|
|
expectedKind: enumspb.TASK_QUEUE_KIND_UNSPECIFIED,
|
|
},
|
|
{
|
|
name: "Empty name, no default",
|
|
taskQueue: &taskqueuepb.TaskQueue{},
|
|
defaultVal: "",
|
|
maxIDLengthLimit: 100,
|
|
expectedError: "missing task queue name",
|
|
expectedKind: enumspb.TASK_QUEUE_KIND_NORMAL,
|
|
},
|
|
{
|
|
name: "Empty name, with default",
|
|
taskQueue: &taskqueuepb.TaskQueue{},
|
|
defaultVal: "default",
|
|
maxIDLengthLimit: 100,
|
|
expectedError: "",
|
|
expectedKind: enumspb.TASK_QUEUE_KIND_NORMAL,
|
|
},
|
|
{
|
|
name: "Valid name",
|
|
taskQueue: &taskqueuepb.TaskQueue{Name: "valid-name"},
|
|
defaultVal: "",
|
|
maxIDLengthLimit: 100,
|
|
expectedError: "",
|
|
expectedKind: enumspb.TASK_QUEUE_KIND_NORMAL,
|
|
},
|
|
{
|
|
name: "Name exactly at max length",
|
|
taskQueue: &taskqueuepb.TaskQueue{Name: strings.Repeat("a", 100)},
|
|
defaultVal: "",
|
|
maxIDLengthLimit: 100,
|
|
expectedError: "",
|
|
expectedKind: enumspb.TASK_QUEUE_KIND_NORMAL,
|
|
},
|
|
{
|
|
name: "Name one character over max length",
|
|
taskQueue: &taskqueuepb.TaskQueue{Name: strings.Repeat("a", 101)},
|
|
defaultVal: "",
|
|
maxIDLengthLimit: 100,
|
|
expectedError: "taskQueue length exceeds limit",
|
|
expectedKind: enumspb.TASK_QUEUE_KIND_NORMAL,
|
|
},
|
|
{
|
|
name: "Reserved prefix",
|
|
taskQueue: &taskqueuepb.TaskQueue{Name: reservedTaskQueuePrefix + "name"},
|
|
defaultVal: "",
|
|
maxIDLengthLimit: 100,
|
|
expectedError: "task queue name cannot start with reserved prefix /_sys/",
|
|
expectedKind: enumspb.TASK_QUEUE_KIND_NORMAL,
|
|
validAsPartition: true,
|
|
},
|
|
{
|
|
name: "Sticky queue with valid normal name",
|
|
taskQueue: &taskqueuepb.TaskQueue{Name: "sticky", Kind: enumspb.TASK_QUEUE_KIND_STICKY, NormalName: "normal"},
|
|
defaultVal: "",
|
|
maxIDLengthLimit: 100,
|
|
expectedError: "",
|
|
expectedKind: enumspb.TASK_QUEUE_KIND_STICKY,
|
|
},
|
|
{
|
|
name: "Non-sticky queue with normal name set",
|
|
taskQueue: &taskqueuepb.TaskQueue{Name: "normal", Kind: enumspb.TASK_QUEUE_KIND_NORMAL, NormalName: "should-be-ignored"},
|
|
defaultVal: "",
|
|
maxIDLengthLimit: 100,
|
|
expectedError: "",
|
|
expectedKind: enumspb.TASK_QUEUE_KIND_NORMAL,
|
|
},
|
|
{
|
|
name: "Task queue with unspecified kind",
|
|
taskQueue: &taskqueuepb.TaskQueue{Name: "unspecified", Kind: enumspb.TASK_QUEUE_KIND_UNSPECIFIED},
|
|
defaultVal: "",
|
|
maxIDLengthLimit: 100,
|
|
expectedError: "",
|
|
expectedKind: enumspb.TASK_QUEUE_KIND_NORMAL,
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
originalTaskQueue := tt.taskQueue
|
|
var originalKind enumspb.TaskQueueKind
|
|
if tt.taskQueue != nil {
|
|
originalKind = tt.taskQueue.GetKind()
|
|
}
|
|
|
|
err := NormalizeAndValidate(tt.taskQueue, tt.defaultVal, tt.maxIDLengthLimit)
|
|
|
|
if tt.expectedError == "" {
|
|
assert.NoError(t, err)
|
|
} else {
|
|
assert.Error(t, err)
|
|
assert.Contains(t, err.Error(), tt.expectedError)
|
|
}
|
|
|
|
err = NormalizeAndValidatePartition(tt.taskQueue, tt.defaultVal, tt.maxIDLengthLimit)
|
|
|
|
if tt.expectedError == "" || tt.validAsPartition {
|
|
assert.NoError(t, err)
|
|
} else {
|
|
assert.Error(t, err)
|
|
assert.Contains(t, err.Error(), tt.expectedError)
|
|
}
|
|
|
|
if originalTaskQueue == nil {
|
|
assert.Nil(t, tt.taskQueue)
|
|
} else {
|
|
if originalKind == enumspb.TASK_QUEUE_KIND_UNSPECIFIED {
|
|
assert.Equal(t, tt.expectedKind, tt.taskQueue.GetKind(), "Kind should be set to NORMAL if it was UNSPECIFIED")
|
|
} else {
|
|
assert.Equal(t, originalKind, tt.taskQueue.GetKind(), "Kind should not change if it wasn't UNSPECIFIED")
|
|
}
|
|
}
|
|
|
|
if tt.taskQueue != nil && tt.taskQueue.GetName() == "" && tt.defaultVal != "" {
|
|
assert.Equal(t, tt.defaultVal, tt.taskQueue.GetName())
|
|
}
|
|
})
|
|
}
|
|
}
|