mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
## What changed? - Added metrics, such as cache hits and cache misses, so that we can understand if the currently set TTL for this cache (of 1 second) is too low or too high. - Also did some re-factorings: While working on this, I realized that it was much simpler to add a new wrapper with a metrics handler, that specifically served the use case of understanding cache hits and missed, rather than use any of the existing implementations of caches that have a metrics handler attached to them. (See *NewWithMetrics*) - Thus, I took some inspiration from the way *newEventsCache* was implemented and came up with this. ## Why? - Explained above. ## How did you test it? - [ ] built - [ ] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s) ## Potential risks - None. --- > [!NOTE] > Introduces a typed `VersionMembershipCache` wrapper with metrics and refactors callers to use it. > > - New `common/worker_versioning/version_membership_cache.go`: typed cache API with `Get`/`Put`, emits `cache_requests` and `cache_miss` with `cache_type=version_membership` and op scopes `VersionMembershipCacheGet`/`Put` > - Metrics: add `VersionMembershipCacheTypeTagValue` and new operation scopes in `metrics/metric_defs.go` > - Refactor: replace `cache.Cache` with `VersionMembershipCache` in worker versioning validation and history APIs (`startworkflow`, `signalwithstartworkflow`, `resetworkflow`, `multioperation`, `updateworkflowoptions`), update DI to provide wrapped cache in `service/history/fx.go` > - History engine constructors and factory updated to accept the new interface > - Tests: add lightweight in-memory and noop implementations; update unit tests to use the new interface > > <sup>Written by [Cursor Bugbot]() for commit 1ce3a10baa75497b69f4486a06d7a5240988fe71. This will update automatically on new commits. Configure [here]().</sup>
109 lines
2.9 KiB
Go
109 lines
2.9 KiB
Go
//nolint:staticcheck
|
|
package worker_versioning
|
|
|
|
import (
|
|
enumspb "go.temporal.io/api/enums/v1"
|
|
"go.temporal.io/server/common/cache"
|
|
"go.temporal.io/server/common/metrics"
|
|
)
|
|
|
|
// VersionMembershipCache is used to cache results of Matching's CheckTaskQueueVersionMembership
|
|
// calls (used internally by the worker versioning pinned override validation).
|
|
//
|
|
// Implementations are expected to be safe for concurrent use.
|
|
type (
|
|
VersionMembershipCache interface {
|
|
// Get returns (isMember, ok). ok=false means there was no cached value.
|
|
Get(
|
|
namespaceID string,
|
|
taskQueue string,
|
|
taskQueueType enumspb.TaskQueueType,
|
|
deploymentName string,
|
|
buildID string,
|
|
) (isMember bool, ok bool)
|
|
|
|
Put(
|
|
namespaceID string,
|
|
taskQueue string,
|
|
taskQueueType enumspb.TaskQueueType,
|
|
deploymentName string,
|
|
buildID string,
|
|
isMember bool,
|
|
)
|
|
}
|
|
|
|
versionMembershipCacheKey struct {
|
|
namespaceID string
|
|
taskQueue string
|
|
taskQueueType enumspb.TaskQueueType
|
|
deploymentName string
|
|
buildID string
|
|
}
|
|
|
|
VersionMembershipCacheImpl struct {
|
|
cache.Cache
|
|
metricsHandler metrics.Handler
|
|
}
|
|
)
|
|
|
|
// NewVersionMembershipCache wraps the provided cache with a typed API and metrics.
|
|
func NewVersionMembershipCache(c cache.Cache, metricsHandler metrics.Handler) VersionMembershipCache {
|
|
h := metricsHandler.WithTags(metrics.CacheTypeTag(metrics.VersionMembershipCacheTypeTagValue))
|
|
return &VersionMembershipCacheImpl{
|
|
Cache: c,
|
|
metricsHandler: h,
|
|
}
|
|
}
|
|
|
|
func (c *VersionMembershipCacheImpl) Get(
|
|
namespaceID string,
|
|
taskQueue string,
|
|
taskQueueType enumspb.TaskQueueType,
|
|
deploymentName string,
|
|
buildID string,
|
|
) (isMember bool, ok bool) {
|
|
handler := c.metricsHandler.WithTags(metrics.OperationTag(metrics.VersionMembershipCacheGetScope), metrics.NamespaceIDTag(namespaceID))
|
|
metrics.CacheRequests.With(handler).Record(1)
|
|
|
|
key := versionMembershipCacheKey{
|
|
namespaceID: namespaceID,
|
|
taskQueue: taskQueue,
|
|
taskQueueType: taskQueueType,
|
|
deploymentName: deploymentName,
|
|
buildID: buildID,
|
|
}
|
|
v := c.Cache.Get(key)
|
|
if v == nil {
|
|
metrics.CacheMissCounter.With(handler).Record(1)
|
|
return false, false
|
|
}
|
|
isMember, ok = v.(bool)
|
|
if !ok {
|
|
// Unexpected type: treat as miss to avoid false positives.
|
|
metrics.CacheMissCounter.With(handler).Record(1)
|
|
return false, false
|
|
}
|
|
return isMember, true
|
|
}
|
|
|
|
func (c *VersionMembershipCacheImpl) Put(
|
|
namespaceID string,
|
|
taskQueue string,
|
|
taskQueueType enumspb.TaskQueueType,
|
|
deploymentName string,
|
|
buildID string,
|
|
isMember bool,
|
|
) {
|
|
handler := c.metricsHandler.WithTags(metrics.OperationTag(metrics.VersionMembershipCachePutScope), metrics.NamespaceIDTag(namespaceID))
|
|
metrics.CacheRequests.With(handler).Record(1)
|
|
|
|
key := versionMembershipCacheKey{
|
|
namespaceID: namespaceID,
|
|
taskQueue: taskQueue,
|
|
taskQueueType: taskQueueType,
|
|
deploymentName: deploymentName,
|
|
buildID: buildID,
|
|
}
|
|
c.Cache.Put(key, isMember)
|
|
}
|