mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
## What changed? Cherry-pick versioning PRs - #9168 - Cache for system protection - #9262 - Cache for system protection - #9239 - Critical PR to enable sending `TargetVersionChanged` flag for Upgrade-on-CaN feature - #9147 - Tracks version drainage properly when version receives workflows via `VersioningOverride`. Needed for automated worker controllers to correctly scale versioned workers that received workflows via `VersioningOverride`. - #9300 - Needed for `approximate_backlog_count` metric to track Current and Ramping version tasks correctly - #9316 - Needed for `approximate_backlog_count` metric to track Current and Ramping version tasks correctly - #8957 - Contains minor metric improvement. Included because it adds a test harness that is used in the two metrics PRs above - #9250 - Bug fix of task rescheduling edge case during AutoUpgrade Transition ## Why? For OSS v1.30.2 ## How did you test it? - [x] built - [ ] run locally and tested manually - [x] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s) --- > [!NOTE] > **Medium Risk** > Touches history/matching worker-versioning paths, adding new caches and changing workflow task/start handling and backlog metric emission; incorrect caching or signaling could affect dispatch/upgrade behavior and observability. > > **Overview** > Adds new worker-versioning protections and upgrade signaling: workflow task started events now persist a `workflow_task_target_worker_deployment_version_changed` flag (and emit a new `workflow_target_version_changed_count` metric) under a new `EnableSendTargetVersionChanged` dynamic config. > > Introduces two new caches with metrics and dynamic config knobs: a `RoutingInfoCache` to avoid repeated `GetTaskQueueUserData` lookups during activity start/transition logic, and a `ReactivationSignalCache` plus `EnableVersionReactivationSignals` to dedupe and asynchronously send “reactivation” signals when workflows are pinned (via start/signal-with-start/reset/update-options) to potentially drained/inactive worker versions. > > Extends matching backlog metrics to support version-attributed reporting by adding `BacklogMetricsEmitInterval` and switching queue DB emission to *physical* backlog gauges (`physical_approximate_backlog_*`) when attribution is enabled, while keeping legacy gauges when disabled. > > Adds frontend scaffolding for a new visibility RPC `CountSchedules` (client plumbing, interception/metadata/quota wiring) but leaves the frontend handler unimplemented, and bumps `go.temporal.io/api` to `v1.62.2`. > > <sup>Written by [Cursor Bugbot]() for commit cb8ae14c86666654c51dd66ae91cb225722e1ba7. This will update automatically on new commits. Configure [here]().</sup> --------- Co-authored-by: Shahab Tajik <[email protected]> Co-authored-by: Shivam <[email protected]>
66 lines
1.8 KiB
Go
66 lines
1.8 KiB
Go
//nolint:staticcheck
|
|
package worker_versioning
|
|
|
|
import (
|
|
"go.temporal.io/server/common/cache"
|
|
"go.temporal.io/server/common/metrics"
|
|
)
|
|
|
|
// ReactivationSignalCache deduplicates reactivation signals to version workflows.
|
|
//
|
|
// Implementations are expected to be safe for concurrent use.
|
|
type (
|
|
ReactivationSignalCache interface {
|
|
// ShouldSendSignal returns true if signal should be sent (not recently sent)
|
|
// and atomically marks it as sent. Returns false if recently sent.
|
|
ShouldSendSignal(namespaceID, deploymentName, buildID string) bool
|
|
}
|
|
|
|
reactivationSignalCacheKey struct {
|
|
namespaceID string
|
|
deploymentName string
|
|
buildID string
|
|
}
|
|
|
|
ReactivationSignalCacheImpl struct {
|
|
cache.Cache
|
|
metricsHandler metrics.Handler
|
|
}
|
|
)
|
|
|
|
// NewReactivationSignalCache wraps the provided cache with a typed API and metrics.
|
|
func NewReactivationSignalCache(c cache.Cache, metricsHandler metrics.Handler) ReactivationSignalCache {
|
|
h := metricsHandler.WithTags(metrics.CacheTypeTag(metrics.VersionReactivationSignalCacheTypeTagValue))
|
|
return &ReactivationSignalCacheImpl{
|
|
Cache: c,
|
|
metricsHandler: h,
|
|
}
|
|
}
|
|
|
|
func (c *ReactivationSignalCacheImpl) ShouldSendSignal(
|
|
namespaceID, deploymentName, buildID string,
|
|
) bool {
|
|
handler := c.metricsHandler.WithTags(
|
|
metrics.OperationTag(metrics.VersionReactivationSignalCacheShouldSendScope),
|
|
metrics.NamespaceIDTag(namespaceID),
|
|
)
|
|
metrics.CacheRequests.With(handler).Record(1)
|
|
|
|
key := reactivationSignalCacheKey{
|
|
namespaceID: namespaceID,
|
|
deploymentName: deploymentName,
|
|
buildID: buildID,
|
|
}
|
|
|
|
// Check if we recently sent a signal for this version
|
|
if c.Cache.Get(key) != nil {
|
|
// Entry exists, signal was recently sent - deduplicate
|
|
return false
|
|
}
|
|
|
|
// No recent signal, mark as sent and return true
|
|
metrics.CacheMissCounter.With(handler).Record(1)
|
|
c.Cache.Put(key, true)
|
|
return true
|
|
}
|