Files
tasks/components/callbacks/executors.go
Roey BermanandGitHub da2fd2cd6c Clean up Nexus CHASM completion code (#8692)
## What changed?

- Move the CHASM / Nexus code back into the `chasm` package.
- Remove wrong and unused callback `Archetype` constant.
- Read the callback header using the case insensitive header util from
the Nexus SDK.

## How did you test it?
- [ ] covered by existing tests
2025-11-25 09:40:08 -08:00

222 lines
5.9 KiB
Go

package callbacks
import (
"context"
"fmt"
"net/http"
"go.temporal.io/server/chasm"
"go.temporal.io/server/common/log"
"go.temporal.io/server/common/metrics"
"go.temporal.io/server/common/namespace"
commonnexus "go.temporal.io/server/common/nexus"
"go.temporal.io/server/common/resource"
"go.temporal.io/server/service/history/hsm"
queuescommon "go.temporal.io/server/service/history/queues/common"
queueserrors "go.temporal.io/server/service/history/queues/errors"
"go.uber.org/fx"
)
// HTTPCaller is a method that can be used to invoke HTTP requests.
type HTTPCaller func(*http.Request) (*http.Response, error)
type HTTPCallerProvider func(queuescommon.NamespaceIDAndDestination) HTTPCaller
func RegisterExecutor(
registry *hsm.Registry,
executorOptions TaskExecutorOptions,
) error {
exec := taskExecutor{executorOptions}
if err := hsm.RegisterImmediateExecutor(
registry,
exec.executeInvocationTask,
); err != nil {
return err
}
return hsm.RegisterTimerExecutor(
registry,
exec.executeBackoffTask,
)
}
type TaskExecutorOptions struct {
fx.In
Config *Config
NamespaceRegistry namespace.Registry
MetricsHandler metrics.Handler
Logger log.Logger
HTTPCallerProvider HTTPCallerProvider
HTTPTraceProvider commonnexus.HTTPClientTraceProvider
HistoryClient resource.HistoryClient
ChasmEngine chasm.Engine
}
type taskExecutor struct {
TaskExecutorOptions
}
// invocationResult is a marker for the callbackInvokable.Invoke result to indicate to the executor how to handle the
// invocation outcome.
type invocationResult interface {
// A marker for all possible implementations.
mustImplementInvocationResult()
error() error
}
// invocationResultFail marks an invocation as successful.
type invocationResultOK struct{}
func (invocationResultOK) mustImplementInvocationResult() {}
func (invocationResultOK) error() error {
return nil
}
// invocationResultFail marks an invocation as permanently failed.
type invocationResultFail struct {
err error
}
func (invocationResultFail) mustImplementInvocationResult() {}
func (r invocationResultFail) error() error {
return r.err
}
// invocationResultRetry marks an invocation as failed with the intent to retry.
type invocationResultRetry struct {
err error
}
func (invocationResultRetry) mustImplementInvocationResult() {}
func (r invocationResultRetry) error() error {
return r.err
}
type callbackInvokable interface {
// Invoke executes the callback logic and returns the invocation result.
Invoke(ctx context.Context, ns *namespace.Namespace, e taskExecutor, task InvocationTask) invocationResult
// WrapError provides each variant the opportunity to wrap the error returned by the task executor for, e.g. to
// trigger the circuit breaker.
WrapError(result invocationResult, err error) error
}
func (e taskExecutor) executeInvocationTask(
ctx context.Context,
env hsm.Environment,
ref hsm.Ref,
task InvocationTask,
) error {
ns, err := e.NamespaceRegistry.GetNamespaceByID(namespace.ID(ref.WorkflowKey.NamespaceID))
if err != nil {
return fmt.Errorf("failed to get namespace by ID: %w", err)
}
invokable, err := e.loadInvocationArgs(ctx, env, ref)
if err != nil {
return err
}
callCtx, cancel := context.WithTimeout(
ctx,
e.Config.RequestTimeout(ns.Name().String(), task.Destination()),
)
defer cancel()
result := invokable.Invoke(callCtx, ns, e, task)
saveErr := e.saveResult(ctx, env, ref, result)
return invokable.WrapError(result, saveErr)
}
func (e taskExecutor) loadInvocationArgs(
ctx context.Context,
env hsm.Environment,
ref hsm.Ref,
) (invokable callbackInvokable, err error) {
err = env.Access(ctx, ref, hsm.AccessRead, func(node *hsm.Node) error {
callback, err := hsm.MachineData[Callback](node)
if err != nil {
return err
}
variant := callback.GetCallback().GetNexus()
if variant == nil {
return queueserrors.NewUnprocessableTaskError(
fmt.Sprintf("unprocessable callback variant: %v", variant),
)
}
target, err := hsm.MachineData[CanGetNexusCompletion](node.Parent)
if err != nil {
return err
}
completion, err := target.GetNexusCompletion(ctx, callback.GetRequestId())
if err != nil {
return err
}
// CHASM internal callbacks make use of Nexus as their callback delivery
// mechanism, but with the internal delivery URL.
if variant.Url == chasm.NexusCompletionHandlerURL {
invokable = chasmInvocation{
nexus: variant,
attempt: callback.Attempt,
completion: completion,
requestID: callback.RequestId,
}
} else {
invokable = nexusInvocation{
nexus: variant,
completion: completion,
workflowID: ref.WorkflowKey.WorkflowID,
runID: ref.WorkflowKey.RunID,
attempt: callback.Attempt,
}
}
return nil
})
return
}
func (e taskExecutor) saveResult(
ctx context.Context,
env hsm.Environment,
ref hsm.Ref,
result invocationResult,
) error {
return env.Access(ctx, ref, hsm.AccessWrite, func(node *hsm.Node) error {
return hsm.MachineTransition(node, func(callback Callback) (hsm.TransitionOutput, error) {
switch result.(type) {
case invocationResultOK:
return TransitionSucceeded.Apply(callback, EventSucceeded{
Time: env.Now(),
})
case invocationResultRetry:
return TransitionAttemptFailed.Apply(callback, EventAttemptFailed{
Time: env.Now(),
Err: result.error(),
RetryPolicy: e.Config.RetryPolicy(),
})
case invocationResultFail:
return TransitionFailed.Apply(callback, EventFailed{
Time: env.Now(),
Err: result.error(),
})
default:
return hsm.TransitionOutput{}, queueserrors.NewUnprocessableTaskError(fmt.Sprintf("unrecognized callback result %v", result))
}
})
})
}
func (e taskExecutor) executeBackoffTask(
env hsm.Environment,
node *hsm.Node,
task BackoffTask,
) error {
return hsm.MachineTransition(node, func(callback Callback) (hsm.TransitionOutput, error) {
return TransitionRescheduled.Apply(callback, EventRescheduled{})
})
}