Files
tasks/service/fx.go
michaely520andGitHub 6528fb3e9c Set IsCloseTransferTaskAcked and IsForceReplication on replication (#8480)
## What changed?

1. Impl to write IsCloseTransferTaskAcked and IsForceReplication flags
on replication stream.
2. Impl for a replication stream interceptor, which fully intercepts
client and server and stores calls in-memory for us to assert against.
Also writes to log files so we can reason about/follow logs without
touching server code (this impl does not immediately log to file for
perf reasons).
3. Accompanying tests (unit and functional)


## Why?
This is part of a larger change to optimize passive task processing by
no-oping side-effects of task processing depending on if we can deem
that the task has already been processed on the parent. Will expand
further in the next PR.

## How did you test it?
- [x] built
- [x] run locally and tested manually
- [x] covered by existing tests
- [x] added new unit test(s)
- [x] added new functional test(s)

`michaely520 ~/projects/temporal % go test -v -tags test_dep ./tests/xdc
-run
TestStreamBasedReplicationTestSuite/EnableTransitionHistory/TestCloseTransferTaskAckedReplication
-timeout 10m -count=1`
2025-10-16 14:24:41 -07:00

171 lines
6.1 KiB
Go

package service
import (
"sync/atomic"
"go.temporal.io/server/common"
"go.temporal.io/server/common/dynamicconfig"
"go.temporal.io/server/common/log"
"go.temporal.io/server/common/log/tag"
"go.temporal.io/server/common/membership"
"go.temporal.io/server/common/metrics"
persistenceClient "go.temporal.io/server/common/persistence/client"
"go.temporal.io/server/common/primitives"
"go.temporal.io/server/common/quotas/calculator"
"go.temporal.io/server/common/rpc"
"go.temporal.io/server/common/rpc/interceptor"
"go.temporal.io/server/common/telemetry"
"go.uber.org/fx"
"google.golang.org/grpc"
)
type (
PersistenceLazyLoadedServiceResolver struct {
*atomic.Value // value type is membership.ServiceResolver
}
PersistenceRateLimitingParams struct {
fx.Out
PersistenceMaxQps persistenceClient.PersistenceMaxQps
PersistenceNamespaceMaxQps persistenceClient.PersistenceNamespaceMaxQps
PersistencePerShardNamespaceMaxQPS persistenceClient.PersistencePerShardNamespaceMaxQPS
OperatorRPSRatio persistenceClient.OperatorRPSRatio
PersistenceBurstRatio persistenceClient.PersistenceBurstRatio
DynamicRateLimitingParams persistenceClient.DynamicRateLimitingParams
}
GrpcServerOptionsParams struct {
fx.In
Logger log.Logger
RPCFactory common.RPCFactory
RetryableInterceptor *interceptor.RetryableInterceptor
TelemetryInterceptor *interceptor.TelemetryInterceptor
RateLimitInterceptor *interceptor.RateLimitInterceptor
TracingStatsHandler telemetry.ServerStatsHandler
MetricsStatsHandler metrics.ServerStatsHandler
AdditionalInterceptors []grpc.UnaryServerInterceptor `optional:"true"`
AdditionalStreamInterceptors []grpc.StreamServerInterceptor `optional:"true"`
}
)
var PersistenceLazyLoadedServiceResolverModule = fx.Options(
fx.Provide(func() PersistenceLazyLoadedServiceResolver {
return PersistenceLazyLoadedServiceResolver{
Value: &atomic.Value{},
}
}),
fx.Invoke(initPersistenceLazyLoadedServiceResolver),
)
func initPersistenceLazyLoadedServiceResolver(
serviceName primitives.ServiceName,
logger log.SnTaggedLogger,
serviceResolver membership.ServiceResolver,
lazyLoadedServiceResolver PersistenceLazyLoadedServiceResolver,
) {
lazyLoadedServiceResolver.Store(serviceResolver)
logger.Info("Initialized service resolver for persistence rate limiting", tag.Service(serviceName))
}
func (p PersistenceLazyLoadedServiceResolver) AvailableMemberCount() int {
if value := p.Load(); value != nil {
return value.(membership.ServiceResolver).AvailableMemberCount()
}
return 0
}
func NewPersistenceRateLimitingParams(
maxQps dynamicconfig.IntPropertyFn,
globalMaxQps dynamicconfig.IntPropertyFn,
namespaceMaxQps dynamicconfig.IntPropertyFnWithNamespaceFilter,
globalNamespaceMaxQps dynamicconfig.IntPropertyFnWithNamespaceFilter,
perShardNamespaceMaxQps dynamicconfig.IntPropertyFnWithNamespaceFilter,
operatorRPSRatio dynamicconfig.FloatPropertyFn,
burstRatio dynamicconfig.FloatPropertyFn,
dynamicRateLimitingParams dynamicconfig.TypedPropertyFn[dynamicconfig.DynamicRateLimitingParams],
lazyLoadedServiceResolver PersistenceLazyLoadedServiceResolver,
logger log.Logger,
) PersistenceRateLimitingParams {
hostCalculator := calculator.NewLoggedCalculator(
calculator.ClusterAwareQuotaCalculator{
MemberCounter: lazyLoadedServiceResolver,
PerInstanceQuota: maxQps,
GlobalQuota: globalMaxQps,
},
log.With(logger, tag.ComponentPersistence, tag.ScopeHost),
)
namespaceCalculator := calculator.NewLoggedNamespaceCalculator(
calculator.ClusterAwareNamespaceQuotaCalculator{
MemberCounter: lazyLoadedServiceResolver,
PerInstanceQuota: namespaceMaxQps,
GlobalQuota: globalNamespaceMaxQps,
},
log.With(logger, tag.ComponentPersistence, tag.ScopeNamespace),
)
return PersistenceRateLimitingParams{
PersistenceMaxQps: func() int {
return int(hostCalculator.GetQuota())
},
PersistenceNamespaceMaxQps: func(namespace string) int {
return int(namespaceCalculator.GetQuota(namespace))
},
PersistencePerShardNamespaceMaxQPS: persistenceClient.PersistencePerShardNamespaceMaxQPS(perShardNamespaceMaxQps),
OperatorRPSRatio: persistenceClient.OperatorRPSRatio(operatorRPSRatio),
PersistenceBurstRatio: persistenceClient.PersistenceBurstRatio(burstRatio),
DynamicRateLimitingParams: persistenceClient.DynamicRateLimitingParams(dynamicRateLimitingParams),
}
}
func GrpcServerOptionsProvider(
params GrpcServerOptionsParams,
) []grpc.ServerOption {
grpcServerOptions, err := params.RPCFactory.GetInternodeGRPCServerOptions()
if err != nil {
params.Logger.Fatal("creating gRPC server options failed", tag.Error(err))
}
multiStats := rpc.MultiStatsHandler{}
if params.TracingStatsHandler != nil {
multiStats = append(multiStats, params.TracingStatsHandler)
}
if params.MetricsStatsHandler != nil {
multiStats = append(multiStats, params.MetricsStatsHandler)
}
if len(multiStats) > 0 {
grpcServerOptions = append(grpcServerOptions, grpc.StatsHandler(multiStats))
}
streamInterceptors := []grpc.StreamServerInterceptor{
params.TelemetryInterceptor.StreamIntercept,
interceptor.CustomErrorStreamInterceptor,
}
if len(params.AdditionalStreamInterceptors) > 0 {
streamInterceptors = append(streamInterceptors, params.AdditionalStreamInterceptors...)
}
return append(
grpcServerOptions,
grpc.ChainUnaryInterceptor(getUnaryInterceptors(params)...),
grpc.ChainStreamInterceptor(streamInterceptors...),
)
}
func getUnaryInterceptors(params GrpcServerOptionsParams) []grpc.UnaryServerInterceptor {
interceptors := []grpc.UnaryServerInterceptor{
interceptor.ServiceErrorInterceptor,
metrics.NewServerMetricsContextInjectorInterceptor(),
metrics.NewServerMetricsTrailerPropagatorInterceptor(params.Logger),
params.TelemetryInterceptor.UnaryIntercept,
}
interceptors = append(interceptors, params.AdditionalInterceptors...)
return append(
interceptors,
params.RateLimitInterceptor.Intercept,
params.RetryableInterceptor.Intercept)
}