mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
ebef6c2be8
## Summary - add the activity task stamp to `IsActivityTaskValidRequest` and generated API stubs - require history's activity validation logic to match the stored stamp - plumb the stamp from matching task validation and cover the new behavior with tests - increment activity stamps for each retry attempt and extend tests for paused retries ## Testing - `GOTOOLCHAIN=local go test -tags test_dep ./service/history/workflow -run TestRetryActivity` *(fails: go.mod requires go >= 1.25.0 and local toolchain is go1.24.3)* ------ https://chatgpt.com/codex/tasks/task_b_68faffae045c832c9d8220bcbe50bac7 --------- Co-authored-by: Michael Youssef <[email protected]>
127 lines
3.8 KiB
Go
127 lines
3.8 KiB
Go
package isactivitytaskvalid
|
|
|
|
import (
|
|
"math/rand"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
"github.com/stretchr/testify/suite"
|
|
"go.temporal.io/api/serviceerror"
|
|
persistencespb "go.temporal.io/server/api/persistence/v1"
|
|
"go.temporal.io/server/common"
|
|
"go.temporal.io/server/service/history/api"
|
|
historyi "go.temporal.io/server/service/history/interfaces"
|
|
"go.uber.org/mock/gomock"
|
|
)
|
|
|
|
type (
|
|
apiSuite struct {
|
|
suite.Suite
|
|
*require.Assertions
|
|
|
|
controller *gomock.Controller
|
|
workflowLease api.WorkflowLease
|
|
workflowContext *historyi.MockWorkflowContext
|
|
mutableState *historyi.MockMutableState
|
|
}
|
|
)
|
|
|
|
func TestAPISuite(t *testing.T) {
|
|
s := new(apiSuite)
|
|
suite.Run(t, s)
|
|
}
|
|
|
|
func (s *apiSuite) SetupTest() {
|
|
s.Assertions = require.New(s.T())
|
|
|
|
s.controller = gomock.NewController(s.T())
|
|
s.workflowContext = historyi.NewMockWorkflowContext(s.controller)
|
|
s.mutableState = historyi.NewMockMutableState(s.controller)
|
|
s.workflowLease = api.NewWorkflowLease(
|
|
s.workflowContext,
|
|
func(err error) {},
|
|
s.mutableState,
|
|
)
|
|
}
|
|
|
|
func (s *apiSuite) TeardownTest() {
|
|
s.controller.Finish()
|
|
}
|
|
|
|
func (s *apiSuite) TestWorkflowCompleted() {
|
|
s.mutableState.EXPECT().IsWorkflowExecutionRunning().Return(false)
|
|
|
|
_, err := isActivityTaskValid(s.workflowLease, rand.Int63(), rand.Int31())
|
|
s.Error(err)
|
|
s.IsType(&serviceerror.NotFound{}, err)
|
|
}
|
|
|
|
func (s *apiSuite) TestWorkflowRunning_ActivityTaskNotStarted() {
|
|
s.mutableState.EXPECT().IsWorkflowExecutionRunning().Return(true)
|
|
activityScheduleEventID := rand.Int63()
|
|
stamp := rand.Int31()
|
|
s.mutableState.EXPECT().GetActivityInfo(activityScheduleEventID).Return(&persistencespb.ActivityInfo{
|
|
ScheduledEventId: activityScheduleEventID,
|
|
StartedEventId: common.EmptyEventID,
|
|
Stamp: stamp,
|
|
}, true)
|
|
|
|
valid, err := isActivityTaskValid(s.workflowLease, activityScheduleEventID, stamp)
|
|
s.NoError(err)
|
|
s.True(valid)
|
|
}
|
|
|
|
func (s *apiSuite) TestWorkflowRunning_ActivityTaskStarted() {
|
|
s.mutableState.EXPECT().IsWorkflowExecutionRunning().Return(true)
|
|
activityScheduleEventID := rand.Int63()
|
|
stamp := rand.Int31()
|
|
s.mutableState.EXPECT().GetActivityInfo(activityScheduleEventID).Return(&persistencespb.ActivityInfo{
|
|
ScheduledEventId: activityScheduleEventID,
|
|
StartedEventId: activityScheduleEventID + 1,
|
|
Stamp: stamp,
|
|
}, true)
|
|
|
|
valid, err := isActivityTaskValid(s.workflowLease, activityScheduleEventID, stamp)
|
|
s.NoError(err)
|
|
s.False(valid)
|
|
}
|
|
|
|
func (s *apiSuite) TestWorkflowRunning_ActivityTaskStampMismatch() {
|
|
s.mutableState.EXPECT().IsWorkflowExecutionRunning().Return(true)
|
|
activityScheduleEventID := rand.Int63()
|
|
const storedStamp = int32(456)
|
|
s.mutableState.EXPECT().GetActivityInfo(activityScheduleEventID).Return(&persistencespb.ActivityInfo{
|
|
ScheduledEventId: activityScheduleEventID,
|
|
StartedEventId: common.EmptyEventID,
|
|
Stamp: storedStamp,
|
|
}, true)
|
|
|
|
valid, err := isActivityTaskValid(s.workflowLease, activityScheduleEventID, storedStamp+1)
|
|
s.NoError(err)
|
|
s.False(valid)
|
|
}
|
|
|
|
func (s *apiSuite) TestWorkflowRunning_ActivityTaskStampLegacy() {
|
|
s.mutableState.EXPECT().IsWorkflowExecutionRunning().Return(true)
|
|
activityScheduleEventID := rand.Int63()
|
|
s.mutableState.EXPECT().GetActivityInfo(activityScheduleEventID).Return(&persistencespb.ActivityInfo{
|
|
ScheduledEventId: activityScheduleEventID,
|
|
StartedEventId: common.EmptyEventID,
|
|
Stamp: 0,
|
|
}, true)
|
|
|
|
valid, err := isActivityTaskValid(s.workflowLease, activityScheduleEventID, 0)
|
|
s.NoError(err)
|
|
s.True(valid)
|
|
}
|
|
|
|
func (s *apiSuite) TestWorkflowRunning_ActivityTaskMissing() {
|
|
s.mutableState.EXPECT().IsWorkflowExecutionRunning().Return(true)
|
|
activityScheduleEventID := rand.Int63()
|
|
s.mutableState.EXPECT().GetActivityInfo(activityScheduleEventID).Return(nil, false)
|
|
|
|
valid, err := isActivityTaskValid(s.workflowLease, activityScheduleEventID, rand.Int31())
|
|
s.NoError(err)
|
|
s.False(valid)
|
|
}
|