Files
tasks/service/history/ndc/buffer_event_flusher_test.go
Chetan GowdaandGitHub 2312f6752f Prevent workflow task and activity task generation when workflow is paused (#8687)
## What changed?
- Prevents workflow task generation when paused (ex: signals, activity
completions, child workflow completions etc)
- Prevents activity task generation when a workflow is paused and an
inflight workflow task comes back with start activity commands.
- Prevents eager activity starts when the workflow is paused.

## Why?
When a workflow is paused, we should not generate any more new activity
and workflow tasks.

## How did you test it?
- [x] built
- [ ] run locally and tested manually
- [x] covered by existing tests
- [ ] added new unit test(s)
- [x] added new functional test(s)


---

> [!NOTE]
> Prevents workflow/activity task creation and certain API operations
when a workflow is paused, adds safeguards and tests across history,
NDC, and task refresh paths.
> 
> - **Behavior/State**:
> - Add `MutableState.IsWorkflowExecutionStatusPaused()` and honor
paused status across scheduling paths.
>   - `workflow/util.ScheduleWorkflowTask` returns early if paused.
> - **API Handlers**:
> - `RespondWorkflowTaskCompleted`: reject `ForceCreateNewWorkflowTask`
when paused; block eager activity and bypass activity task gen when
paused.
> - `SignalWithStartWorkflow`: do not schedule a new workflow task if
paused.
>   - `UpdateWorkflow`: reject updates while paused.
>   - Activity failure/respond paths: avoid new WFT when paused.
> - **NDC/Replication**:
> - Reapply events and buffered-event flusher: skip scheduling WFT if
paused.
> - `ndc.Workflow.FlushBufferedEvents`: don't schedule WFT when paused.
> - **Task Refresher**:
> - Skip refreshing WFT/activity tasks when paused; allow
timers/search-attr updates; skip close tasks for running/paused.
> - **Interfaces/Mocks**:
> - Add `IsWorkflowExecutionStatusPaused` to `MutableState` interface
and update mocks.
> - **Tests**:
> - New unit tests for paused behavior in handlers, NDC, task refresher,
and transfer queue; functional tests for pause/unpause workflow
behavior.
> 
> <sup>Written by [Cursor
Bugbot]() for commit
17c11c687a0d620cc5a77e6ce9369622feb9214b. This will update automatically
on new commits. Configure
[here]().</sup>
2025-12-15 10:45:31 -08:00

175 lines
5.9 KiB
Go

package ndc
import (
"context"
"testing"
"github.com/google/uuid"
"github.com/stretchr/testify/require"
"github.com/stretchr/testify/suite"
enumspb "go.temporal.io/api/enums/v1"
historypb "go.temporal.io/api/history/v1"
enumsspb "go.temporal.io/server/api/enums/v1"
historyspb "go.temporal.io/server/api/history/v1"
persistencespb "go.temporal.io/server/api/persistence/v1"
"go.temporal.io/server/common/cluster"
"go.temporal.io/server/common/log"
"go.temporal.io/server/common/persistence/versionhistory"
"go.temporal.io/server/service/history/consts"
historyi "go.temporal.io/server/service/history/interfaces"
"go.temporal.io/server/service/history/shard"
"go.temporal.io/server/service/history/tests"
"go.uber.org/mock/gomock"
)
type (
bufferEventFlusherSuite struct {
suite.Suite
*require.Assertions
controller *gomock.Controller
mockShard *shard.ContextTest
mockContext *historyi.MockWorkflowContext
mockMutableState *historyi.MockMutableState
mockClusterMetadata *cluster.MockMetadata
logger log.Logger
namespaceID string
workflowID string
runID string
nDCBufferEventFlusher *BufferEventFlusherImpl
}
)
func TestBufferEventFlusherSuite(t *testing.T) {
s := new(bufferEventFlusherSuite)
suite.Run(t, s)
}
func (s *bufferEventFlusherSuite) SetupTest() {
s.Assertions = require.New(s.T())
s.controller = gomock.NewController(s.T())
s.mockContext = historyi.NewMockWorkflowContext(s.controller)
s.mockMutableState = historyi.NewMockMutableState(s.controller)
s.mockShard = shard.NewTestContext(
s.controller,
&persistencespb.ShardInfo{
ShardId: 10,
RangeId: 1,
},
tests.NewDynamicConfig(),
)
s.mockClusterMetadata = s.mockShard.Resource.ClusterMetadata
s.mockClusterMetadata.EXPECT().GetCurrentClusterName().Return(cluster.TestCurrentClusterName).AnyTimes()
s.logger = s.mockShard.GetLogger()
s.namespaceID = uuid.NewString()
s.workflowID = "some random workflow ID"
s.runID = uuid.NewString()
s.nDCBufferEventFlusher = NewBufferEventFlusher(
s.mockShard, s.mockContext, s.mockMutableState, s.logger,
)
}
func (s *bufferEventFlusherSuite) TearDownTest() {
s.controller.Finish()
s.mockShard.StopForTest()
}
func (s *bufferEventFlusherSuite) TestClearTransientWorkflowTask() {
versionHistory := versionhistory.NewVersionHistory([]byte("some random base branch token"), []*historyspb.VersionHistoryItem{
versionhistory.NewVersionHistoryItem(10, 0),
versionhistory.NewVersionHistoryItem(50, 100),
versionhistory.NewVersionHistoryItem(100, 200),
versionhistory.NewVersionHistoryItem(150, 300),
})
versionHistories := versionhistory.NewVersionHistories(versionHistory)
incomingVersionHistory := versionhistory.CopyVersionHistory(versionHistory)
err := versionhistory.AddOrUpdateVersionHistoryItem(
incomingVersionHistory,
versionhistory.NewVersionHistoryItem(200, 300),
)
s.NoError(err)
s.mockMutableState.EXPECT().HasBufferedEvents().Return(false).AnyTimes()
s.mockMutableState.EXPECT().HasStartedWorkflowTask().Return(true).AnyTimes()
s.mockMutableState.EXPECT().IsTransientWorkflowTask().Return(true).AnyTimes()
s.mockMutableState.EXPECT().ClearTransientWorkflowTask().Return(nil).AnyTimes()
s.mockMutableState.EXPECT().GetExecutionInfo().Return(&persistencespb.WorkflowExecutionInfo{
NamespaceId: s.namespaceID,
WorkflowId: s.workflowID,
VersionHistories: versionHistories,
}).AnyTimes()
s.mockMutableState.EXPECT().GetExecutionState().Return(&persistencespb.WorkflowExecutionState{
RunId: s.runID,
}).AnyTimes()
_, _, err = s.nDCBufferEventFlusher.flush(context.Background())
s.NoError(err)
}
func (s *bufferEventFlusherSuite) TestFlushBufferedEvents() {
lastWriteVersion := int64(300)
versionHistory := versionhistory.NewVersionHistory([]byte("some random base branch token"), []*historyspb.VersionHistoryItem{
versionhistory.NewVersionHistoryItem(10, 0),
versionhistory.NewVersionHistoryItem(50, 100),
versionhistory.NewVersionHistoryItem(100, 200),
versionhistory.NewVersionHistoryItem(150, 300),
})
versionHistories := versionhistory.NewVersionHistories(versionHistory)
incomingVersionHistory := versionhistory.CopyVersionHistory(versionHistory)
err := versionhistory.AddOrUpdateVersionHistoryItem(
incomingVersionHistory,
versionhistory.NewVersionHistoryItem(200, 300),
)
s.NoError(err)
s.mockMutableState.EXPECT().IsWorkflow().Return(true).AnyTimes()
s.mockMutableState.EXPECT().GetLastWriteVersion().Return(lastWriteVersion, nil).AnyTimes()
s.mockMutableState.EXPECT().HasBufferedEvents().Return(true).AnyTimes()
s.mockMutableState.EXPECT().IsWorkflowExecutionRunning().Return(true).AnyTimes()
s.mockMutableState.EXPECT().UpdateCurrentVersion(lastWriteVersion, true).Return(nil)
workflowTask := &historyi.WorkflowTaskInfo{
ScheduledEventID: 1234,
StartedEventID: 2345,
}
s.mockMutableState.EXPECT().GetStartedWorkflowTask().Return(workflowTask)
s.mockMutableState.EXPECT().GetExecutionInfo().Return(&persistencespb.WorkflowExecutionInfo{
VersionHistories: versionHistories,
}).AnyTimes()
s.mockMutableState.EXPECT().AddWorkflowTaskFailedEvent(
workflowTask,
enumspb.WORKFLOW_TASK_FAILED_CAUSE_FAILOVER_CLOSE_COMMAND,
nil,
consts.IdentityHistoryService,
nil,
"",
"",
"",
int64(0),
).Return(&historypb.HistoryEvent{}, nil)
s.mockMutableState.EXPECT().IsWorkflowExecutionStatusPaused().Return(false)
s.mockMutableState.EXPECT().AddWorkflowTaskScheduledEvent(
false,
enumsspb.WORKFLOW_TASK_TYPE_NORMAL,
).Return(&historyi.WorkflowTaskInfo{}, nil)
s.mockMutableState.EXPECT().FlushBufferedEvents()
s.mockClusterMetadata.EXPECT().ClusterNameForFailoverVersion(true, lastWriteVersion).Return(cluster.TestCurrentClusterName).AnyTimes()
s.mockClusterMetadata.EXPECT().GetCurrentClusterName().Return(cluster.TestCurrentClusterName).AnyTimes()
s.mockContext.EXPECT().UpdateWorkflowExecutionAsActive(gomock.Any(), s.mockShard).Return(nil)
_, _, err = s.nDCBufferEventFlusher.flush(context.Background())
s.NoError(err)
}