tasks/service/history/ndc/replication_task_test.go at release/v1.30.x

mirror of https://github.com/hanzoai/tasks.git synced 2026-10-30 14:56:19 +00:00

Files

T

Roey BermanandGitHub 243effc6e1 Forbid the use of pborman/uuid and remove uses (#8541 )

## What

Used the `depguard` linter to prevent importing the package and modified
all uses of it.

Also fixed a bug in the membership code where we were not updating the
next page token:

https://github.com/temporalio/temporal/pull/8541/files#diff-985dd64ffa4c6bfe0248b982dc47439b725862baa3e1f2c559b7ff522bf21969R350


## Why?

From the package README in GitHub:

> This package now leverages the github.com/google/uuid package (which
is based off an earlier version of this package).

Also, there's no point in having two uuid implementations in the
codebase.

## Test

Added the invalid import and confirmed it works:

```
../service/frontend/admin_handler_test.go:13:2: import 'github.com/pborman/uuid' is not allowed from list 'main': Importing github.com/pborman/uuid is disallowed; use github.com/google/uuid instead (depguard)
        _ "github.com/pborman/uuid"

```

2025-11-26 01:33:02 +00:00

279 lines

4.7 KiB

Go

Raw Permalink Blame History

 package ndc
 import (
 	"testing"
 	"github.com/google/uuid"
 	"github.com/stretchr/testify/require"
 	"github.com/stretchr/testify/suite"
 	enumspb "go.temporal.io/api/enums/v1"
 	historypb "go.temporal.io/api/history/v1"
 	"go.temporal.io/server/common/cluster"
 	"go.temporal.io/server/common/definition"
 	"go.uber.org/mock/gomock"
 )
 type (
 	replicationTaskSuite struct {
 		suite.Suite
 		*require.Assertions
 		controller      *gomock.Controller
 		clusterMetadata *cluster.MockMetadata
 	}
 )
 func TestReplicationTaskSuite(t *testing.T) {
 	s := new(replicationTaskSuite)
 	suite.Run(t, s)
 }
 func (s *replicationTaskSuite) SetupSuite() {
 	s.Assertions = require.New(s.T())
 	s.controller = gomock.NewController(s.T())
 	s.clusterMetadata = cluster.NewMockMetadata(s.controller)
 	s.clusterMetadata.EXPECT().ClusterNameForFailoverVersion(gomock.Any(), gomock.Any()).Return("some random cluster name").AnyTimes()
 }
 func (s *replicationTaskSuite) TearDownSuite() {
 }
 func (s *replicationTaskSuite) TestValidateEventsSlice() {
 	eS1 := []*historypb.HistoryEvent{
 		{
 			EventId: 1,
 			Version: 2,
 		},
 		{
 			EventId: 2,
 			Version: 2,
 		},
 	}
 	eS2 := []*historypb.HistoryEvent{
 		{
 			EventId: 3,
 			Version: 2,
 		},
 	}
 	eS3 := []*historypb.HistoryEvent{
 		{
 			EventId: 4,
 			Version: 2,
 		},
 	}
 	v, err := validateEventsSlice(eS1, eS2)
 	s.Equal(int64(2), v)
 	s.Nil(err)
 	v, err = validateEventsSlice(eS1, eS3)
 	s.Equal(int64(0), v)
 	s.IsType(ErrEventSlicesNotConsecutive, err)
 	v, err = validateEventsSlice(eS1, nil)
 	s.Equal(int64(0), v)
 	s.IsType(ErrEmptyEventSlice, err)
 }
 func (s *replicationTaskSuite) TestValidateEvents() {
 	eS1 := []*historypb.HistoryEvent{
 		{
 			EventId: 1,
 			Version: 2,
 		},
 		{
 			EventId: 2,
 			Version: 2,
 		},
 	}
 	eS2 := []*historypb.HistoryEvent{
 		{
 			EventId: 1,
 			Version: 2,
 		},
 		{
 			EventId: 3,
 			Version: 2,
 		},
 	}
 	eS3 := []*historypb.HistoryEvent{
 		{
 			EventId: 1,
 			Version: 1,
 		},
 		{
 			EventId: 2,
 			Version: 2,
 		},
 	}
 	v, err := validateEvents(eS1)
 	s.Nil(err)
 	s.Equal(int64(2), v)
 	v, err = validateEvents(eS2)
 	s.Equal(int64(0), v)
 	s.IsType(ErrEventIDMismatch, err)
 	v, err = validateEvents(eS3)
 	s.Equal(int64(0), v)
 	s.IsType(ErrEventVersionMismatch, err)
 }
 func (s *replicationTaskSuite) TestSkipDuplicatedEvents_ValidInput_SkipEvents() {
 	workflowKey := definition.WorkflowKey{
 		WorkflowID: uuid.NewString(),
 		RunID:      uuid.NewString(),
 	}
 	slice1 := []*historypb.HistoryEvent{
 		{
 			EventId: 11,
 		},
 		{
 			EventId: 12,
 		},
 	}
 	slice2 := []*historypb.HistoryEvent{
 		{
 			EventId: 13,
 		},
 		{
 			EventId: 14,
 		},
 	}
 	task, _ := newReplicationTask(
 		s.clusterMetadata,
 		nil,
 		workflowKey,
 		nil,
 		nil,
 		[][]*historypb.HistoryEvent{slice1, slice2},
 		nil,
 		"",
 		nil,
 		false,
 	)
 	err := task.skipDuplicatedEvents(1)
 	s.NoError(err)
 	s.Equal(1, len(task.getEvents()))
 	s.Equal(slice2, task.getEvents()[0])
 	s.Equal(int64(13), task.getFirstEvent().EventId)
 	s.Equal(int64(14), task.getLastEvent().EventId)
 }
 func (s *replicationTaskSuite) TestSkipDuplicatedEvents_InvalidInput_ErrorOut() {
 	workflowKey := definition.WorkflowKey{
 		WorkflowID: uuid.NewString(),
 		RunID:      uuid.NewString(),
 	}
 	slice1 := []*historypb.HistoryEvent{
 		{
 			EventId: 11,
 		},
 		{
 			EventId: 12,
 		},
 	}
 	slice2 := []*historypb.HistoryEvent{
 		{
 			EventId: 13,
 		},
 		{
 			EventId: 14,
 		},
 	}
 	task, _ := newReplicationTask(
 		s.clusterMetadata,
 		nil,
 		workflowKey,
 		nil,
 		nil,
 		[][]*historypb.HistoryEvent{slice1, slice2},
 		nil,
 		"",
 		nil,
 		false,
 	)
 	err := task.skipDuplicatedEvents(2)
 	s.Error(err)
 }
 func (s *replicationTaskSuite) TestSkipDuplicatedEvents_ZeroInput_DoNothing() {
 	workflowKey := definition.WorkflowKey{
 		WorkflowID: uuid.NewString(),
 		RunID:      uuid.NewString(),
 	}
 	slice1 := []*historypb.HistoryEvent{
 		{
 			EventId: 11,
 		},
 		{
 			EventId: 12,
 		},
 	}
 	slice2 := []*historypb.HistoryEvent{
 		{
 			EventId: 13,
 		},
 		{
 			EventId: 14,
 		},
 	}
 	task, _ := newReplicationTask(
 		s.clusterMetadata,
 		nil,
 		workflowKey,
 		nil,
 		nil,
 		[][]*historypb.HistoryEvent{slice1, slice2},
 		nil,
 		"",
 		nil,
 		false,
 	)
 	err := task.skipDuplicatedEvents(0)
 	s.NoError(err)
 	s.Equal(2, len(task.getEvents()))
 	s.Equal(slice1, task.getEvents()[0])
 	s.Equal(slice2, task.getEvents()[1])
 }
 func (s *replicationTaskSuite) TestResetInfo() {
 	workflowKey := definition.WorkflowKey{
 		WorkflowID: uuid.NewString(),
 		RunID:      uuid.NewString(),
 	}
 	slice1 := []*historypb.HistoryEvent{
 		{
 			EventId:   13,
 			EventType: enumspb.EVENT_TYPE_WORKFLOW_TASK_FAILED,
 		},
 		{
 			EventId: 14,
 		},
 	}
 	task, _ := newReplicationTask(
 		s.clusterMetadata,
 		nil,
 		workflowKey,
 		nil,
 		nil,
 		[][]*historypb.HistoryEvent{slice1},
 		nil,
 		"",
 		nil,
 		false,
 	)
 	info := task.getBaseWorkflowInfo()
 	s.Nil(info)
 	s.False(task.isWorkflowReset())
 }

279 lines 4.7 KiB Go Raw Permalink Blame History

279 lines

4.7 KiB

Go

Raw Permalink Blame History