mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-30 14:56:19 +00:00
Yichao YangandGitHub
de3aa87e1a
## What changed? - Introduced a new "move (task) group" action replacing the "incorrect" slice-predicate action. See inline comment for how it works. - Improve task Predicate AND/OR calculation to reduce predicate size. - Skip empty slices when adding queue slices to readers. ## Why? - Better namespace isolation. ## How did you test it? - [x] built - [x] run locally and tested manually - [ ] covered by existing tests - [x] added new unit test(s) - [ ] added new functional test(s) ## Potential risks - The new action can be disabled via dc.
87 lines
2.0 KiB
Go
87 lines
2.0 KiB
Go
package queues
|
|
|
|
import (
|
|
"go.temporal.io/server/common/log"
|
|
"go.temporal.io/server/common/log/tag"
|
|
"go.temporal.io/server/service/history/tasks"
|
|
)
|
|
|
|
var _ Action = (*actionReaderStuck)(nil)
|
|
|
|
type (
|
|
actionReaderStuck struct {
|
|
attributes *AlertAttributesReaderStuck
|
|
logger log.Logger
|
|
}
|
|
)
|
|
|
|
func newReaderStuckAction(
|
|
attributes *AlertAttributesReaderStuck,
|
|
logger log.Logger,
|
|
) *actionReaderStuck {
|
|
return &actionReaderStuck{
|
|
attributes: attributes,
|
|
logger: logger,
|
|
}
|
|
}
|
|
|
|
func (a *actionReaderStuck) Name() string {
|
|
return "reader-stuck"
|
|
}
|
|
|
|
func (a *actionReaderStuck) Run(readerGroup *ReaderGroup) bool {
|
|
reader, ok := readerGroup.ReaderByID(a.attributes.ReaderID)
|
|
if !ok {
|
|
a.logger.Info("Failed to get queue with readerID for reader stuck action", tag.QueueReaderID(a.attributes.ReaderID))
|
|
return false
|
|
}
|
|
|
|
stuckRange := NewRange(
|
|
a.attributes.CurrentWatermark,
|
|
tasks.NewKey(
|
|
a.attributes.CurrentWatermark.FireTime.Add(monitorWatermarkPrecision),
|
|
a.attributes.CurrentWatermark.TaskID,
|
|
),
|
|
)
|
|
|
|
var splitSlices []Slice
|
|
reader.SplitSlices(func(s Slice) ([]Slice, bool) {
|
|
r := s.Scope().Range
|
|
if stuckRange.ContainsRange(r) {
|
|
splitSlices = append(splitSlices, s)
|
|
return nil, true
|
|
}
|
|
|
|
remaining := make([]Slice, 0, 2)
|
|
if s.CanSplitByRange(stuckRange.InclusiveMin) {
|
|
left, right := s.SplitByRange(stuckRange.InclusiveMin)
|
|
remaining = append(remaining, left)
|
|
s = right
|
|
}
|
|
|
|
if s.CanSplitByRange(stuckRange.ExclusiveMax) {
|
|
left, right := s.SplitByRange(stuckRange.ExclusiveMax)
|
|
remaining = append(remaining, right)
|
|
s = left
|
|
}
|
|
|
|
if len(remaining) == 0 {
|
|
// s can't split by both min and max of stuck range,
|
|
// and stuck range does not contain the range of s,
|
|
// the only possible case is s is not overlapping with stuck range at all.
|
|
return nil, false
|
|
}
|
|
|
|
splitSlices = append(splitSlices, s)
|
|
return remaining, true
|
|
})
|
|
|
|
if len(splitSlices) == 0 {
|
|
return false
|
|
}
|
|
|
|
nextReader := readerGroup.GetOrCreateReader(a.attributes.ReaderID + 1)
|
|
nextReader.MergeSlices(splitSlices...)
|
|
return true
|
|
}
|